devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Konrad Dybcio <konrad.dybcio@somainline.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>, Stephen Boyd <swboyd@chromium.org>
Subject: Re: [PATCH 0/3] dt-bindings: arm: qcom: define schema, not devices
Date: Mon, 25 Jul 2022 19:29:17 +0200	[thread overview]
Message-ID: <e3878d93-7c66-1018-ddfc-ab7fd9be1936@linaro.org> (raw)
In-Reply-To: <CAD=FV=XiJd6G0-QExB=SPDNx3TNFyFjyPvUGdkkBGPEe4XYiEw@mail.gmail.com>

On 25/07/2022 19:22, Doug Anderson wrote:
>>>> You cannot do that...
>>>
>>> The bootloader never falls back to just the SoC name.
>>
>> There is no "SoC" part of compatible list. Only by convenience we put it
>> that way, but DT spec does not define first compatible to be for
>> platform because they all are[1], therefore following your earlier
>> description - bootloader should load BAR DTS on FOO device just because
>> qcom,sdm845 matches.
> 
> As documented in "Documentation/arm/google/chromebook-boot-flow.rst",
> the bootloader creates a match list to pick a device tree file. It
> never creates a match list that has just the SoC. It always picks
> based on the board name and never falls back to just the SoC name.

So this means you embedded some custom-interpretation of board
compatibles in bootloader. What stops you to customize it even more,
that the bootloader must always pick the most specific compatible? IOW,
it cannot load DTB from more generic compatible (just like it should not
load qcom,sdm845 DTS)?

I understand the limitation of board compatibles for your case, but I
still believe it is wrong usage of it.
If the usage - by principle - was correct, then you would not need to
add the restriction you mentioned above ("never creates a match list
that has just the SoC").

Because when Linux drivers match, they do not have such restriction...

Best regards,
Krzysztof

  reply	other threads:[~2022-07-25 17:29 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-23  9:09 [PATCH 0/3] dt-bindings: arm: qcom: define schema, not devices Dmitry Baryshkov
2022-07-23  9:09 ` [PATCH 1/3] dt-bindings: arm: qcom: stop describing individual boards Dmitry Baryshkov
2022-07-23 17:49   ` Krzysztof Kozlowski
2022-07-23  9:09 ` [PATCH 2/3] dt-bindings: arm: qcom: merge simple platform definitions Dmitry Baryshkov
2022-07-23 17:50   ` Krzysztof Kozlowski
2022-07-23  9:09 ` [PATCH 3/3] dt-bindings: arm: qcom: drop individual descriptions of Google devices Dmitry Baryshkov
2022-07-23 17:51   ` Krzysztof Kozlowski
2022-07-23 17:48 ` [PATCH 0/3] dt-bindings: arm: qcom: define schema, not devices Krzysztof Kozlowski
2022-07-23 22:50   ` Dmitry Baryshkov
2022-07-25 16:18     ` Krzysztof Kozlowski
2022-07-25 17:13       ` Dmitry Baryshkov
2022-07-25 17:25         ` Krzysztof Kozlowski
2022-07-25 16:25     ` Doug Anderson
2022-07-25 16:41       ` Krzysztof Kozlowski
2022-07-25 16:54         ` Doug Anderson
2022-07-25 17:07           ` Krzysztof Kozlowski
2022-07-25 17:09             ` Doug Anderson
2022-07-25 17:14               ` Krzysztof Kozlowski
2022-07-25 17:22                 ` Doug Anderson
2022-07-25 17:29                   ` Krzysztof Kozlowski [this message]
2022-07-25 17:35                     ` Doug Anderson
2022-07-25 16:56         ` Krzysztof Kozlowski
2022-07-25 17:30     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3878d93-7c66-1018-ddfc-ab7fd9be1936@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).