From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jonas Karlman <jonas@kwiboo.se>, Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add Xunlong Orange Pi 3B
Date: Mon, 6 May 2024 08:17:55 +0200 [thread overview]
Message-ID: <e3a58e55-25cc-42dd-aa6d-6a436d615a87@linaro.org> (raw)
In-Reply-To: <20240505202522.2999503-3-jonas@kwiboo.se>
On 05/05/2024 22:25, Jonas Karlman wrote:
> The Xunlong Orange Pi 3B is a single-board computer based on the
> Rockchip RK3566 SoC.
> +
> + vcc5v0_sys: vcc5v0-sys-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0_sys";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + };
> +
> + vcc5v0_usb_host: vcc5v0-usb-host-regulator {
Please use name for all fixed regulators which matches current format
recommendation: 'regulator-[0-9]+v[0-9]+'
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/?id=b6d4b3500d57370f5b3abf0701c9166b384db976
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-06 6:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-05 20:25 [PATCH 0/2] arm64: dts: rockchip: Add Xunlong Orange Pi 3B Jonas Karlman
2024-05-05 20:25 ` [PATCH 1/2] dt-bindings: arm: " Jonas Karlman
2024-05-06 6:15 ` Krzysztof Kozlowski
2024-05-05 20:25 ` [PATCH 2/2] arm64: dts: " Jonas Karlman
2024-05-06 6:17 ` Krzysztof Kozlowski [this message]
2024-05-06 20:40 ` [PATCH 0/2] " Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3a58e55-25cc-42dd-aa6d-6a436d615a87@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox