From: Stephen Boyd <sboyd@kernel.org>
To: Jan Dakinevich <jan.dakinevich@salutedevices.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v2 1/5] clk: meson: axg: move reset controller's code to separate module
Date: Sun, 07 Apr 2024 19:39:30 -0700 [thread overview]
Message-ID: <e3a85852b911fdf16dd9ae158f42b3ef.sboyd@kernel.org> (raw)
In-Reply-To: <1j7chfiz8e.fsf@starbuckisacylon.baylibre.com>
Quoting Jerome Brunet (2024-04-02 07:52:38)
>
> On Thu 28 Mar 2024 at 04:08, Jan Dakinevich <jan.dakinevich@salutedevices.com> wrote:
>
> > This code will by reused by A1 SoC.
>
> Could expand a bit please ?
>
> >
> > Signed-off-by: Jan Dakinevich <jan.dakinevich@salutedevices.com>
>
> In general, I like the idea.
>
> We do have a couple a reset registers lost in middle of clocks and this
> change makes it possible to re-use the code instead duplicating it.
>
> The exported function would be used by audio clock controllers, but the
> module created would be purely about reset.
>
> One may wonder how it ended up in the clock tree, especially since the
> kernel as a reset tree too.
>
> I'm not sure if this should move to the reset framework or if it would
> be an unnecessary churn. Stephen, Philipp, do you have an opinion on
> this ?
>
I'd prefer it be made into an auxiliary device and the driver put in
drivers/reset/ so we can keep reset code in the reset directory. The
auxiliary device creation function can also be in the drivers/reset/
directory so that the clk driver calls some function to create and
register the device.
next prev parent reply other threads:[~2024-04-08 2:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 1:08 [RFC PATCH v2 0/5] Add A1 Soc audio clock controller driver Jan Dakinevich
2024-03-28 1:08 ` [RFC PATCH v2 1/5] clk: meson: axg: move reset controller's code to separate module Jan Dakinevich
2024-04-02 14:52 ` Jerome Brunet
2024-04-08 2:39 ` Stephen Boyd [this message]
2024-04-08 8:21 ` Philipp Zabel
2024-04-08 9:52 ` Stephen Boyd
2024-04-08 17:05 ` Conor Dooley
2024-04-09 12:05 ` Conor Dooley
2024-04-10 2:27 ` Stephen Boyd
2024-04-10 8:56 ` Philipp Zabel
2024-04-10 9:17 ` Jerome Brunet
2024-04-10 9:50 ` Conor Dooley
2024-03-28 1:08 ` [RFC PATCH v2 2/5] clk: meson: axg: share the audio helper macro Jan Dakinevich
2024-03-28 1:08 ` [RFC PATCH v2 3/5] dt-bindings: clock: meson: document A1 SoC audio clock controller driver Jan Dakinevich
2024-03-28 9:01 ` Krzysztof Kozlowski
2024-03-28 9:02 ` Krzysztof Kozlowski
2024-03-28 19:43 ` Jan Dakinevich
2024-03-29 12:24 ` Jerome Brunet
2024-03-30 19:42 ` Jan Dakinevich
2024-03-28 1:08 ` [RFC PATCH v2 4/5] clk: meson: a1: add the " Jan Dakinevich
2024-04-02 15:11 ` Jerome Brunet
2024-04-08 1:07 ` Jan Dakinevich
2024-03-28 1:08 ` [RFC PATCH v2 5/5] arm64: dts: meson: a1: add the audio clock controller Jan Dakinevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3a85852b911fdf16dd9ae158f42b3ef.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jan.dakinevich@salutedevices.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=neil.armstrong@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).