From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: MD Danish Anwar <danishanwar@ti.com>
Cc: Nishanth Menon <nm@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
"Tero Kristo" <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <s-vadapalli@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-j722s-evm: Fix USB2.0_MUX_SEL hog polarity for Type-C
Date: Fri, 20 Nov 2026 17:56:10 +0530 [thread overview]
Message-ID: <e3ab607d-577c-4e34-bd76-565c6e640f03@ti.com> (raw)
In-Reply-To: <20261120122303.38795-1-danishanwar@ti.com>
On 11/20/26 5:53 PM, MD Danish Anwar wrote:
> According to the "USB Type-C Mux" section of the J722S EVM Schematic
> within the Evaluation Module Design Files package [0], the Type-C
> connector is connected to USB0 when USB2.0_MUX_SEL, Pin P05 of GPIO
> Expander 1 (I2C0/0x23), is low.
>
> Commit 65ba2a6e77e9 ("arm64: dts: ti: k3-j722s-evm: Fix USB gpio-hog
> level for Type-C") changed the p05-hog from output-high to output-low
> while keeping GPIO_ACTIVE_LOW. As the polarity flag is applied before the
> level, output-low with GPIO_ACTIVE_LOW drives the pin physically high.
> USB0 then does not work on the Type-C port: with the gadget bound, the UDC
> stays "not attached" and the host sees no device.
>
> Use GPIO_ACTIVE_HIGH with output-low, so that P05 is driven physically
> low as the schematic requires to select Type-C, and the devicetree reads
> the same as the schematic.
>
> [0]: https://www.ti.com/lit/zip/sprr495
>
> Fixes: 65ba2a6e77e9 ("arm64: dts: ti: k3-j722s-evm: Fix USB gpio-hog level for Type-C")
> Signed-off-by: MD Danish Anwar <danishanwar@ti.com>
Thank you for fixing this.
Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Regards,
Siddharth.
> ---
> arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> index c6486cf5a05c..80a915925c1c 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> @@ -586,7 +586,7 @@ exp1: gpio@23 {
> p05-hog {
> /* P05 - USB2.0_MUX_SEL */
> gpio-hog;
> - gpios = <5 GPIO_ACTIVE_LOW>;
> + gpios = <5 GPIO_ACTIVE_HIGH>;
> output-low;
> };
>
>
> base-commit: adcad7f4e6332cff3d6d7165f41584899f598534
prev parent reply other threads:[~2026-11-20 12:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 12:23 [PATCH] arm64: dts: ti: k3-j722s-evm: Fix USB2.0_MUX_SEL hog polarity for Type-C MD Danish Anwar
2026-11-20 12:26 ` Siddharth Vadapalli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3ab607d-577c-4e34-bd76-565c6e640f03@ti.com \
--to=s-vadapalli@ti.com \
--cc=conor+dt@kernel.org \
--cc=danishanwar@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox