From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28299C4332F for ; Mon, 12 Dec 2022 18:51:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233167AbiLLSvp (ORCPT ); Mon, 12 Dec 2022 13:51:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233032AbiLLSvM (ORCPT ); Mon, 12 Dec 2022 13:51:12 -0500 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FCFB186E0 for ; Mon, 12 Dec 2022 10:48:52 -0800 (PST) Received: by mail-lj1-x22c.google.com with SMTP id b9so816134ljr.5 for ; Mon, 12 Dec 2022 10:48:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2/ZS2AFgbeUqbIyP+vspk/7zGGQh523qi91eWgk2+pE=; b=mh2mMApK/v/DCOdDC/e9YBRqOUf6HnCOJPs29ijhdu8YOGGTAc1qW7GRtqnfGn+Z5s DvgsKNgx65roIYwQsnXBy1aHurvg3TZoTYvSknprl2xRx+JFRf+Uz2JD70ptKczO4EzI Wig3h3LWGg+mjm8fPszUCoKer85CY5m5h9e9u8eZZi7a+Dz0G78vY3cAnoKaPJIC1H1V F+lm98E9Mpro7/5tLMcLOwxduLu/zPXtCVlPtuJmwT0c7hNupdJuJrdKYHBqeYww5J5F Zlx5abNmf3LqwZZEhDs84LJIqDgRz26HhBvZkfaIKTy0a0w2k91EGbofaRU4eN5PerXF 2P7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2/ZS2AFgbeUqbIyP+vspk/7zGGQh523qi91eWgk2+pE=; b=R35RU0wZLTBH5nGU1RUPyzK/sVtqeXTfM3C3CraJXP4bf4Plt+AIXufq8MfjCLNJgb kfd4alAfkHIqYEsXIlk+fl+3h8Ss2cZmjSeJPM7VUquPP3IjGu5z+jM7VZFx/TgevOPB 30eXYpKqmQgXOzE4kxKgbSsCjDmHu+UjXkW2m/Sqcb+TPY4WdLQ3z0kNq8pm+Q+5qPuE sE6nKYXLczjaPrqQL1mIRW4Ig09DTSDmapwbw2ZIi9I7X9vbXpzOjWmVCpG5c8j6UUo1 5I6xpoz0zL2k7uGNM7ZFooOjNEvQ4ks4f3SFYuUUSnWsBA/mwCd8uIqKTLR3fNSpE4Xz LvFw== X-Gm-Message-State: ANoB5pnmCyXPgg5GKjsOwCwbrAqbZSS4OfXIPAufT+4ME3DJRTExclYp npmuqCatcxT/uQtJBkSbHhde0w== X-Google-Smtp-Source: AA0mqf78O+abfksMWJHo7jefNo/CTbXNSgyYKih0mcpFTWplw5xsRH0KzjV6ld2EOCXpMBA9xr9ypA== X-Received: by 2002:a2e:be85:0:b0:26f:db34:a151 with SMTP id a5-20020a2ebe85000000b0026fdb34a151mr5515664ljr.20.1670870931208; Mon, 12 Dec 2022 10:48:51 -0800 (PST) Received: from [192.168.1.101] (abxh44.neoplus.adsl.tpnet.pl. [83.9.1.44]) by smtp.gmail.com with ESMTPSA id 11-20020a2eb94b000000b0027776efa48csm56327ljs.91.2022.12.12.10.48.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 10:48:50 -0800 (PST) Message-ID: Date: Mon, 12 Dec 2022 19:48:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH 1/4] arm64: dts: qcom: sc8280xp: rename i2c5 to i2c21 Content-Language: en-US To: Brian Masney , andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: robh+dt@kernel.org, johan+linaro@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, ahalaney@redhat.com, echanude@redhat.com, quic_shazhuss@quicinc.com References: <20221212182314.1902632-1-bmasney@redhat.com> <20221212182314.1902632-2-bmasney@redhat.com> From: Konrad Dybcio In-Reply-To: <20221212182314.1902632-2-bmasney@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12.12.2022 19:23, Brian Masney wrote: > According to the downstream 5.4 kernel sources for the sa8540p, > i2c@894000 is labeled i2c bus 21, not 5. The interrupts and clocks > also match. Let's go ahead and correct the name that's used in the > three files where this is listed. > > Signed-off-by: Brian Masney > Fixes: 152d1faf1e2f3 ("arm64: dts: qcom: add SC8280XP platform") > Fixes: ccd3517faf183 ("arm64: dts: qcom: sc8280xp: Add reference device") > Fixes: 32c231385ed43 ("arm64: dts: qcom: sc8280xp: add Lenovo Thinkpad X13s devicetree") > --- Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 6 +++--- > arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 6 +++--- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 2 +- > 3 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > index 551768f97729..1ab76724144d 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts > @@ -326,11 +326,11 @@ &qup2 { > status = "okay"; > }; > > -&qup2_i2c5 { > +&qup2_i2c21 { > clock-frequency = <400000>; > > pinctrl-names = "default"; > - pinctrl-0 = <&qup2_i2c5_default>; > + pinctrl-0 = <&qup2_i2c21_default>; > > status = "okay"; > > @@ -598,7 +598,7 @@ qup0_i2c4_default: qup0-i2c4-default-state { > drive-strength = <16>; > }; > > - qup2_i2c5_default: qup2-i2c5-default-state { > + qup2_i2c21_default: qup2-i2c21-default-state { > pins = "gpio81", "gpio82"; > function = "qup21"; > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > index 568c6be1ceaa..284adf60386a 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > @@ -531,11 +531,11 @@ &qup2 { > status = "okay"; > }; > > -&qup2_i2c5 { > +&qup2_i2c21 { > clock-frequency = <400000>; > > pinctrl-names = "default"; > - pinctrl-0 = <&qup2_i2c5_default>; > + pinctrl-0 = <&qup2_i2c21_default>; > > status = "okay"; > > @@ -801,7 +801,7 @@ qup0_i2c4_default: qup0-i2c4-default-state { > drive-strength = <16>; > }; > > - qup2_i2c5_default: qup2-i2c5-default-state { > + qup2_i2c21_default: qup2-i2c21-default-state { > pins = "gpio81", "gpio82"; > function = "qup21"; > bias-disable; > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index 109c9d2b684d..875cc91324ce 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -827,7 +827,7 @@ qup2_uart17: serial@884000 { > status = "disabled"; > }; > > - qup2_i2c5: i2c@894000 { > + qup2_i2c21: i2c@894000 { > compatible = "qcom,geni-i2c"; > reg = <0 0x00894000 0 0x4000>; > clock-names = "se";