From: Krzysztof Kozlowski <krzk@kernel.org>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Kukjin Kim <kgene@kernel.org>,
linux-samsung-soc@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards
Date: Thu, 01 Sep 2016 11:05:59 +0200 [thread overview]
Message-ID: <e3cdab3d-f1ef-f751-b169-e3328178b835@kernel.org> (raw)
In-Reply-To: <c043b569-fbad-23bb-5807-5dda9cc8b37f@osg.samsung.com>
On 09/01/2016 10:43 AM, Javier Martinez Canillas wrote:
>>> --- a/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>> +++ b/arch/arm/boot/dts/exynos5440-ssdk5440.dts
>>> @@ -21,6 +21,11 @@
>>> bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>> };
>>>
>>> + memory {
>>> + device_type = "memory";
>>> + reg = <0 0>;
>>> + };
>>
>> This looks okay, but the default size and address cells won't be
>> present. Won't that be a problem?
>>
>
> They will be present since at this point exynos5440.dtsi is still including
> exynos5440.dtsi, we are just overriding the memory node with the same values
> than skeleton.dtsi so this can be removed later in patch 7/7.
I don't get it. exynos5440.dtsi does not set size/address cells in top node.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-09-01 9:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 12:14 [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Javier Martinez Canillas
2016-08-31 12:14 ` [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards Javier Martinez Canillas
2016-08-31 17:22 ` Bartlomiej Zolnierkiewicz
2016-09-01 8:30 ` Javier Martinez Canillas
2016-08-31 17:46 ` Krzysztof Kozlowski
2016-09-01 8:43 ` Javier Martinez Canillas
2016-09-01 9:05 ` Krzysztof Kozlowski [this message]
[not found] ` <e3cdab3d-f1ef-f751-b169-e3328178b835-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-09-01 9:19 ` Javier Martinez Canillas
[not found] ` <0e8e0b3c-0dd9-c44b-d1ad-03c840d3a725-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-09-01 9:28 ` Krzysztof Kozlowski
2016-09-01 9:36 ` Javier Martinez Canillas
[not found] ` <184ad5f6-5528-2ad7-7c2b-46beda9b6dc9-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-09-01 9:48 ` Krzysztof Kozlowski
2016-08-31 12:14 ` [PATCH 2/7] ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos3 Javier Martinez Canillas
2016-08-31 12:14 ` [PATCH 3/7] ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos4 Javier Martinez Canillas
2016-08-31 12:14 ` [PATCH 4/7] ARM: dts: exynos: Remove skeleton.dtsi usage for Exynos5 Javier Martinez Canillas
2016-08-31 12:14 ` [PATCH 5/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos3 DTS Javier Martinez Canillas
[not found] ` <1472645679-5696-1-git-send-email-javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-08-31 12:14 ` [PATCH 6/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos4 DTS Javier Martinez Canillas
2016-08-31 12:55 ` [PATCH 0/7] ARM: dts: exynos: Remove skeleton.dtsi usage and fix memory node DTC warnings Krzysztof Kozlowski
[not found] ` <5366f8a4-b4fb-ec2d-eb1e-5534f24c4a07-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-08-31 13:45 ` Javier Martinez Canillas
[not found] ` <0da13ae1-90a8-912b-227e-0e94439953d5-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-08-31 17:40 ` Bartlomiej Zolnierkiewicz
2016-09-01 8:35 ` Javier Martinez Canillas
2016-09-01 9:59 ` Bartlomiej Zolnierkiewicz
2016-09-01 11:40 ` Mark Rutland
2016-09-01 11:59 ` Bartlomiej Zolnierkiewicz
2016-08-31 17:47 ` Krzysztof Kozlowski
2016-08-31 12:14 ` [PATCH 7/7] ARM: dts: exynos: Add missing unit name to memory nodes in Exynos5 DTS Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3cdab3d-f1ef-f751-b169-e3328178b835@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).