devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Michael Walle <michael@walle.cc>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Ludovic Desroches <ludovic.desroches@microchip.com>
Subject: Re: [PATCH] dt-bindings: arm: at91: add Kontron's new KSwitches
Date: Thu, 10 Feb 2022 14:03:51 +0100	[thread overview]
Message-ID: <e3cebd32-689d-f74e-f53a-b24e1bf71f6f@canonical.com> (raw)
In-Reply-To: <20220210125705.481612-1-michael@walle.cc>

On 10/02/2022 13:57, Michael Walle wrote:
> The Kontron KSwitch D10 MMT series ethernet switches features a LAN9668
> SoC with either 8 copper ports or 6 copper port and two SFP cages.
> 
> Signed-off-by: Michael Walle <michael@walle.cc>
> ---
>  .../devicetree/bindings/arm/atmel-at91.yaml        | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> index c612e1f48dba..e019e79f9551 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> @@ -174,6 +174,20 @@ properties:
>            - const: microchip,lan9668
>            - const: microchip,lan966
>  
> +      - description: Kontron KSwitch D10 MMT 8G industrial ethernet switch
> +        items:
> +          - const: kontron,kswitch-d10-mmt-8g
> +          - const: kontron,s1921
> +          - const: microchip,lan9668
> +          - const: microchip,lan966
> +
> +      - description: Kontron KSwitch D10 MMT 6G-2GS industrial ethernet switch
> +        items:
> +          - const: kontron,kswitch-d10-mmt-6g-2gs
> +          - const: kontron,s1921
> +          - const: microchip,lan9668
> +          - const: microchip,lan966
> +

This should be just one entry with an enum.

>        - items:
>            - enum:
>                - atmel,sams70j19


Best regards,
Krzysztof

      reply	other threads:[~2022-02-10 13:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-10 12:57 [PATCH] dt-bindings: arm: at91: add Kontron's new KSwitches Michael Walle
2022-02-10 13:03 ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3cebd32-689d-f74e-f53a-b24e1bf71f6f@canonical.com \
    --to=krzysztof.kozlowski@canonical.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=michael@walle.cc \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).