From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6FABC7EE23 for ; Thu, 18 May 2023 14:34:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231346AbjEROeo (ORCPT ); Thu, 18 May 2023 10:34:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231298AbjEROen (ORCPT ); Thu, 18 May 2023 10:34:43 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C252E109 for ; Thu, 18 May 2023 07:34:41 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-510ede0f20aso645694a12.3 for ; Thu, 18 May 2023 07:34:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684420480; x=1687012480; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hGuVJGDyUJXoppRxO19U57zqQ8R180tIuC1i2XY1D7Y=; b=DL/8Doq0uyeD+OsBh0RcgR7j0Zbc5M3bQbV5Ej/5FiofKZqpQWCIGt8J3dWm0KL3oM uxNZ9+BnCHBxsPdJsnPOaZSwpe60JqP5XVN7uOAxvj8o0nlB/V4oDfNeIarsqBgI77te JkzhImiM3GTygK8k/lx/cWScVQfgAqLnUn+v2eT78/e+HFvp2nDwHrzrE4m1QfR4l1Xj grI4BvCnb9D+iaXC5ZGOiN4tF+Oyg3fkirHDdjaIIFt50vmgCCAV1Yk9IysDWY4yOBhg 3unhKsvr+fvxE8x9eqEP1Reapq2y+XM+QhapV5PMWuZ0KF1/9QeQF8+0W2qLD5iZ6Vt4 sGYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684420480; x=1687012480; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hGuVJGDyUJXoppRxO19U57zqQ8R180tIuC1i2XY1D7Y=; b=iVrvx3IiRRqN/TGT4DTK5+k0kRo5fbBC0YtMfaCY23SpZhXCyK1PWTFGaH06R0fOlH PACZpECnL07mYNDqKVj2u81SlJw04Qa8PmgqLsO5PpWYuwb8CYSPjh9vq+fjEzXxotzY BOTH7k0dct3xqSg+heu4QQqe57udb+v5RyQgqqpe9PjdM688TQGWRA9zxMdXOB3EEYRD qX8BdCUk3UayrXFuMQv/BNSBUEQFGiolGGKGGSdlcy5lhRxXD6FmD+RjG198BWjyiGdW uj2mh+YqK0f/23Ln+Rs+eFIN5mNCM/+2jwHiObnPc5M0qQNESvBtkZHq1ruGOGAbsUON BwcQ== X-Gm-Message-State: AC+VfDxL3eXXwyD8oDtBltxFUp6pXdtlMrhcI8xWOQLsm5GJn4t8iFkr N4K75yuux5JHm0O40BrUoxtAeg== X-Google-Smtp-Source: ACHHUZ5G9MyGkK/5LFq43LkHmyyn4r1xGaGdyZNVFZApq0jhDgVEa6qFGGDv5Q+PqgLUJ5hNn5kCwQ== X-Received: by 2002:a05:6402:b2f:b0:510:e902:9678 with SMTP id bo15-20020a0564020b2f00b00510e9029678mr1508591edb.8.1684420480248; Thu, 18 May 2023 07:34:40 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:7e24:6d1b:6bf:4249? ([2a02:810d:15c0:828:7e24:6d1b:6bf:4249]) by smtp.gmail.com with ESMTPSA id i17-20020a056402055100b0050c524253dasm643254edx.20.2023.05.18.07.34.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 May 2023 07:34:39 -0700 (PDT) Message-ID: Date: Thu, 18 May 2023 16:34:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH net-next V7] dt-bindings: net: xlnx,axi-ethernet: convert bindings document to yaml Content-Language: en-US To: "Gaddam, Sarath Babu Naidu" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" Cc: "michal.simek@xilinx.com" , "radhey.shyam.pandey@xilinx.com" , "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "Sarangi, Anirudha" , "Katakam, Harini" , "git (AMD-Xilinx)" References: <20230308061223.1358637-1-sarath.babu.naidu.gaddam@amd.com> <5d074e6b-7fe1-ab7f-8690-cfb1bead6927@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/05/2023 08:17, Gaddam, Sarath Babu Naidu wrote: > > >> -----Original Message----- >> From: Gaddam, Sarath Babu Naidu >> Sent: Wednesday, May 3, 2023 3:01 PM >> To: Krzysztof Kozlowski ; >> davem@davemloft.net; edumazet@google.com; kuba@kernel.org; >> pabeni@redhat.com; robh+dt@kernel.org; >> krzysztof.kozlowski+dt@linaro.org >> Cc: michal.simek@xilinx.com; radhey.shyam.pandey@xilinx.com; >> netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- >> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Sarangi, >> Anirudha ; Katakam, Harini >> ; git (AMD-Xilinx) >> Subject: RE: [PATCH net-next V7] dt-bindings: net: xlnx,axi-ethernet: >> convert bindings document to yaml >> >> >> >>> -----Original Message----- >>> From: Krzysztof Kozlowski >>> Sent: Tuesday, May 2, 2023 3:56 PM >>> To: Gaddam, Sarath Babu Naidu >>> ; davem@davemloft.net; >>> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; >>> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org >>> Cc: michal.simek@xilinx.com; radhey.shyam.pandey@xilinx.com; >>> netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- >>> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Sarangi, >>> Anirudha ; Katakam, Harini >>> ; git (AMD-Xilinx) >>> Subject: Re: [PATCH net-next V7] dt-bindings: net: xlnx,axi-ethernet: >>> convert bindings document to yaml >>> >>> On 28/03/2023 14:52, Gaddam, Sarath Babu Naidu wrote: >>>> >>>> >>>>> -----Original Message----- >>>>> From: Krzysztof Kozlowski >>>>> Sent: Tuesday, March 14, 2023 9:22 PM >>>>> To: Gaddam, Sarath Babu Naidu >>>>> ; davem@davemloft.net; >>>>> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; >>>>> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org >>>>> Cc: michal.simek@xilinx.com; radhey.shyam.pandey@xilinx.com; >>>>> netdev@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- >>>>> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Sarangi, >>>>> Anirudha ; Katakam, Harini >>>>> ; git (AMD-Xilinx) >>>>> Subject: Re: [PATCH net-next V7] dt-bindings: net: xlnx,axi-ethernet: >>>>> convert bindings document to yaml >>>>> >>>>> On 08/03/2023 07:12, Sarath Babu Naidu Gaddam wrote: >>>>>> From: Radhey Shyam Pandey >>>>>> >>>>>> Convert the bindings document for Xilinx AXI Ethernet Subsystem >>> from >>>>>> txt to yaml. No changes to existing binding description. >>>>>> >>>>> >>>>> (...) >>>>> >>>>>> +properties: >>>>>> + compatible: >>>>>> + enum: >>>>>> + - xlnx,axi-ethernet-1.00.a >>>>>> + - xlnx,axi-ethernet-1.01.a >>>>>> + - xlnx,axi-ethernet-2.01.a >>>>>> + >>>>>> + reg: >>>>>> + description: >>>>>> + Address and length of the IO space, as well as the address >>>>>> + and length of the AXI DMA controller IO space, unless >>>>>> + axistream-connected is specified, in which case the reg >>>>>> + attribute of the node referenced by it is used. >>>>> >>>>> Did you test it with axistream-connected? The schema and >>>>> description feel contradictory and tests would point the issue. >>>> >>>> Thanks for review comments. We tested with axistream-connected >> and >>> did >>>> not observe any errors. Do you anticipate any issues/errors ? >>> >>> Yes, I anticipate errors. What you wrote here looks incorrect based on >>> the schema. >>> >>> Also, See also my further comments (or you ignored them?). >>> >>> You can come many months after my review to ask about details, to be >>> sure I will forget the topic. >> >> >> Hi Krzysztof, Apologies for miscommunication. I replied to this thread on >> March 28 and said that I would address remaining review comments in >> the next version. >> >> Lore link: >> https://lore.kernel.org/all/MW5PR12MB559880B0E220BDBD64E06D24 >> 87889@MW5PR12MB5598.namprd12.prod.outlook.com/ >> https://lore.kernel.org/all/MW5PR12MB5598678BB9AB6EC2FFC424F48 >> 7889@MW5PR12MB5598.namprd12.prod.outlook.com/ >> >> I planned to send next version with phy-mode and pcs-handle maxItems >> fixed.but I wanted to close on the axistream-connected discussion before >> doing so. >> >> Related to axistream-connected discussion: >> I already ran dt binding check for schema and dts node validation. I >> assume this should point any errors on it. And how do we know that you tested correct DTS with it? >> > > Hi Krzysztof, Could you please comment on this ? Please let me if I missed > any changes or comments. I don't think anything improved in this patchset. The binding has incomplete and I believe incorrect constraints for axistream-connected. You did not provide DTS to prove me otherwise. If you are not going to fix the issue nor provide DTS, what I can say more? Looks wrong. Best regards, Krzysztof