From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEAD5EB64DD for ; Mon, 14 Aug 2023 19:55:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232271AbjHNTzN (ORCPT ); Mon, 14 Aug 2023 15:55:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34680 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232258AbjHNTzH (ORCPT ); Mon, 14 Aug 2023 15:55:07 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9496210F for ; Mon, 14 Aug 2023 12:55:06 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-997c4107d62so630074466b.0 for ; Mon, 14 Aug 2023 12:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692042905; x=1692647705; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RykofCguml6rSMpJYe0VPw+oopELw4ZN/ghN42VwsP4=; b=Md6ABwFmuunlVk+OyZekSEThFF9OwW/PY+wmBONune03X4WdEZk+I9BGLMPGrn1T26 7kzogeviAVaxf38nOX1up595rjblj8oaP0LLshPZ5a2rcxY9kbisZMr2WXgWGOl9S3Py 8n6D+ma22EtAAl79X6qXxsN0zag7Pa3N2Gc87NbTe9/N2ejQeKxtr0hXvBn2PCTy8tvV 6oY2khWUg+f9S6xz/plJOu/sxwyUt6btOnNcjsREEQK87Qkk/CpK8Y8ztJTn0+gTuAG8 +aJujmwl+tS/qWKkSItKBYW8f5J+7tS5Ab8OxJDyoUyiCv24wEYDDXBWlRi/FggwjtHq c6PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692042905; x=1692647705; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RykofCguml6rSMpJYe0VPw+oopELw4ZN/ghN42VwsP4=; b=kLc0mxsztCPk3bDIwPXYJYzr4zD4dsDNcb5Dpbt/tWNLqVGL5/XVCl5iG0dgz6LmNt s6+4bl2WodPJC8RE516gXxKYhDa+5XxEO4TgK3bAvGvXSsPo35Ej2fE+KDWdoOueo8W5 7LQ+hdh7+aNfUj57LSs7GsV21hLQ3lOMCTDAOes559ZwNMDe0DSdb1Hg636M8kaG/OJm raZxuT4K5M/7DKyYPPLQv5mQm0T0pH6Sb6oKtTuxp8DXUXJBbk/GFegjd0AAaox8zjfs dQi58DId8j8g7UFl5PNsNsA/fAJk1NUAqycgfh4WwLPjp+7UDrZZMiqcyAjssfe+7XoJ W+AA== X-Gm-Message-State: AOJu0Yy2w9dR0aw4w3Hm5UfcQRDNpMGsXU9gDiMU5Ft5cXIse6L8TIho iiQV2IDo5dYihZv2Z+DM/Wpq3A== X-Google-Smtp-Source: AGHT+IFxdS8jB/vXR9RW8EAGNbjE/bRPZ4ed13Lyl3ZWTg86j0xk6ItclZVeE1vRwpbXZh8Gv0Ca6w== X-Received: by 2002:a17:906:315b:b0:99c:a23b:b4f5 with SMTP id e27-20020a170906315b00b0099ca23bb4f5mr9496008eje.53.1692042905042; Mon, 14 Aug 2023 12:55:05 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id os5-20020a170906af6500b00993a37aebc5sm5972415ejb.50.2023.08.14.12.55.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Aug 2023 12:55:04 -0700 (PDT) Message-ID: Date: Mon, 14 Aug 2023 21:55:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 4/4] arm64: dts: fsd: Add Ethernet support for PERIC Block of FSD SoC Content-Language: en-US To: Sriranjani P , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, pankaj.dubey@samsung.com, alim.akhtar@samsung.com, ravi.patel@samsung.com, 'Jayati Sahu' , swathi.ks@samsung.com References: <20230111075422.107173-1-sriranjani.p@samsung.com> <20230111075422.107173-5-sriranjani.p@samsung.com> <7d74a96e-e3a5-118c-04a9-e8ed95fffa54@linaro.org> <000101d9ce99$f454da20$dcfe8e60$@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <000101d9ce99$f454da20$dcfe8e60$@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/08/2023 12:27, Sriranjani P wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org] >> Sent: 12 January 2023 15:07 >> To: Sriranjani P ; davem@davemloft.net; >> edumazet@google.com; kuba@kernel.org; pabeni@redhat.com; >> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; >> alexandre.torgue@foss.st.com; peppe.cavallaro@st.com; >> joabreu@synopsys.com; mcoquelin.stm32@gmail.com >> Cc: netdev@vger.kernel.org; devicetree@vger.kernel.org; linux- >> kernel@vger.kernel.org; pankaj.dubey@samsung.com; >> alim.akhtar@samsung.com; ravi.patel@samsung.com; Jayati Sahu >> >> Subject: Re: [PATCH v2 4/4] arm64: dts: fsd: Add Ethernet support for PERIC >> Block of FSD SoC >> >> On 11/01/2023 08:54, Sriranjani P wrote: >>> The FSD SoC contains two instances of Synopsys DWC QoS Ethernet IP, >>> one in >>> FSYS0 block and other in PERIC block. >>> >>> Adds device tree node for Ethernet in PERIC Block and enables the same >>> for FSD platform. >>> >>> Signed-off-by: Pankaj Dubey >>> Signed-off-by: Jayati Sahu >>> Signed-off-by: Sriranjani P >>> --- >>> arch/arm64/boot/dts/tesla/fsd-evb.dts | 9 ++++ >>> arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi | 56 >> ++++++++++++++++++++++ >>> arch/arm64/boot/dts/tesla/fsd.dtsi | 29 +++++++++++ >>> 3 files changed, 94 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts >>> b/arch/arm64/boot/dts/tesla/fsd-evb.dts >>> index ca0c1a28d562..2c0cbe775e04 100644 >>> --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts >>> +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts >>> @@ -39,6 +39,15 @@ >>> }; >>> }; >>> >>> +ðernet_1 { >>> + status = "okay"; >>> + >>> + fixed-link { >>> + speed = <1000>; >>> + full-duplex; >>> + }; >>> +}; >>> + >>> &fin_pll { >>> clock-frequency = <24000000>; >>> }; >>> diff --git a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >>> b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >>> index 7ccc0738a149..c955bf159786 100644 >>> --- a/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >>> +++ b/arch/arm64/boot/dts/tesla/fsd-pinctrl.dtsi >>> @@ -395,6 +395,62 @@ >>> samsung,pin-pud = ; >>> samsung,pin-drv = ; >>> }; >>> + >>> + eth1_tx_clk: eth1-tx-clk-pins { >>> + samsung,pins = "gpf2-0"; >>> + samsung,pin-function = ; >>> + samsung,pin-pud = ; >>> + samsung,pin-drv = ; >>> + }; >>> + >>> + eth1_tx_data: eth1-tx-data-pins { >>> + samsung,pins = "gpf2-1", "gpf2-2", "gpf2-3", "gpf2-4"; >>> + samsung,pin-function = ; >>> + samsung,pin-pud = ; >>> + samsung,pin-drv = ; >>> + }; >>> + >>> + eth1_tx_ctrl: eth1-tx-ctrl-pins { >>> + samsung,pins = "gpf2-5"; >>> + samsung,pin-function = ; >>> + samsung,pin-pud = ; >>> + samsung,pin-drv = ; >>> + }; >>> + >>> + eth1_phy_intr: eth1-phy-intr-pins { >>> + samsung,pins = "gpf2-6"; >>> + samsung,pin-function = ; >>> + samsung,pin-pud = ; >>> + samsung,pin-drv = ; >>> + }; >>> + >>> + eth1_rx_clk: eth1-rx-clk-pins { >>> + samsung,pins = "gpf3-0"; >>> + samsung,pin-function = ; >>> + samsung,pin-pud = ; >>> + samsung,pin-drv = ; >>> + }; >>> + >>> + eth1_rx_data: eth1-rx-data-pins { >>> + samsung,pins = "gpf3-1", "gpf3-2", "gpf3-3", "gpf3-4"; >>> + samsung,pin-function = ; >>> + samsung,pin-pud = ; >>> + samsung,pin-drv = ; >>> + }; >>> + >>> + eth1_rx_ctrl: eth1-rx-ctrl-pins { >>> + samsung,pins = "gpf3-5"; >>> + samsung,pin-function = ; >>> + samsung,pin-pud = ; >>> + samsung,pin-drv = ; >>> + }; >>> + >>> + eth1_mdio: eth1-mdio-pins { >>> + samsung,pins = "gpf3-6", "gpf3-7"; >>> + samsung,pin-function = ; >>> + samsung,pin-pud = ; >>> + samsung,pin-drv = ; >>> + }; >>> }; >>> >>> &pinctrl_pmu { >>> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi >>> b/arch/arm64/boot/dts/tesla/fsd.dtsi >>> index ade707cc646b..8807055807dd 100644 >>> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi >>> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi >>> @@ -33,6 +33,7 @@ >>> spi1 = &spi_1; >>> spi2 = &spi_2; >>> eth0 = ðernet_0; >>> + eth1 = ðernet_1; >> >> Nope for the reasons I explained last time. > Sorry somehow I'm not able to find my previous mail chain. If you reply like this after half a year, what can I say? Is that a reason to ignore the feedback? No. Just use the lore and find it: https://lore.kernel.org/all/4fd9dabb-c8f3-b826-2eb2-ab8b5816102a@linaro.org/ > I had replied to your comment in the previous version of the mail. > In this case alias id is used to differentiate between Ethernet instance 0 and 1 in the driver code. NAK. >> >>> }; >>> >>> cpus { >>> @@ -882,6 +883,34 @@ >>> phy-mode = "rgmii"; >>> status = "disabled"; >>> }; >>> + >>> + ethernet_1: ethernet@14300000 { >> >> Do not add nodes to the end. > If you mean to say that the nodes are supposed to be in the increasing order of physical address, > I can see that the existing file is not arranged in that format. If that is required I can first fix the > existing file and post the revised patch for the same. You can drop it in some place more or less matching its address, just not to the end. Best regards, Krzysztof