public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shawn Guo <shengchao.guo@oss.qualcomm.com>
Cc: Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
	Bjorn Andersson <andersson@kernel.org>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com,
	trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Subject: Re: [PATCH v3 3/5] dt-bindings: remoteproc: qcom,pas: Document pas for SoCCP on Kaanapali and Glymur platforms
Date: Thu, 26 Feb 2026 18:12:35 +0100	[thread overview]
Message-ID: <e3dcadb3-0239-4a49-a5ee-3c20ff97ea4e@kernel.org> (raw)
In-Reply-To: <aY582M8dgOrKW39w@QCOM-aGQu4IUr3Y>

On 13/02/2026 02:22, Shawn Guo wrote:
> On Wed, Dec 24, 2025 at 09:34:30AM +0100, Krzysztof Kozlowski wrote:
>>> the interrupt for soccp is defined as 
>>> "wdog","fatal","ready","handover","stop-ack","pong","wake-ack"
>>> while other pas could be:
>>> "wdog","fatal","ready","handover","stop-ack","shutdown-ack"
>>>
>>> so grow existing list is not work for this,
>>>
>>> In the v1, got your comments to adjust pas-common.yaml for the interrupt:
>>> https://lore.kernel.org/all/861b6ede-f168-44e6-85bd-10cf04dbcec7@kernel.org/
>>>
>>> and in v2, interrupt are moved as part to the "allOf" with if-else and
>>> also got NAK:
>>> https://lore.kernel.org/all/20251030-venomous-apricot-falcon-b3fd64@kuoka/
>>>
>>> Could you please share a example for us to understand how to maintain it in
>>> pas-common.yaml, not define if-else and has strict order at the same time?
>>> That will be very helpful.
> 
> I guess something like this would work?
> 
>   interrupt-names:
>     minItems: 5
>     maxItems: 7
>     oneOf:
>       - items:
>           - const: wdog
>           - const: fatal
>           - const: ready
>           - const: handover
>           - const: stop-ack
>           - const: shutdown-ack
>       - items:
>           - const: wdog
>           - const: fatal
>           - const: ready
>           - const: handover
>           - const: stop-ack
>           - const: pong
>           - const: wake-ack

This is good for pas-common, but you also need in the same commit update
all schemas having $ref to pas-common to have explicit list. For example
milos has six elements and your change would basically allow the sixth
item to be pong.

Also several files need maxItems for interrupts, since the upper limit
is now 7.



Best regards,
Krzysztof

  reply	other threads:[~2026-02-26 17:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-23  9:13 [PATCH v3 0/5] Add initial remoteproc support for Kaanapali SoC Jingyi Wang
2025-12-23  9:13 ` [PATCH v3 1/5] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali ADSP Jingyi Wang
2025-12-23 13:02   ` Krzysztof Kozlowski
2025-12-23  9:13 ` [PATCH v3 2/5] dt-bindings: remoteproc: qcom,sm8550-pas: Add Kaanapali CDSP Jingyi Wang
2025-12-23 13:07   ` Krzysztof Kozlowski
2025-12-24  2:44     ` Jingyi Wang
2025-12-23  9:13 ` [PATCH v3 3/5] dt-bindings: remoteproc: qcom,pas: Document pas for SoCCP on Kaanapali and Glymur platforms Jingyi Wang
2025-12-23 13:29   ` Krzysztof Kozlowski
2025-12-24  3:16     ` Jingyi Wang
2025-12-24  8:34       ` Krzysztof Kozlowski
2026-02-13  1:22         ` Shawn Guo
2026-02-26 17:12           ` Krzysztof Kozlowski [this message]
2026-02-27  5:52             ` Jingyi Wang
2026-02-27  7:35               ` Krzysztof Kozlowski
2025-12-23  9:13 ` [PATCH v3 4/5] remoteproc: qcom: pas: Add late attach support for subsystems Jingyi Wang
2025-12-23 20:15   ` Dmitry Baryshkov
2025-12-24  3:20     ` Jingyi Wang
2025-12-23 22:15   ` Stephan Gerhold
2025-12-24  4:43     ` Jingyi Wang
2025-12-26  2:10   ` kernel test robot
2025-12-23  9:13 ` [PATCH v3 5/5] remoteproc: qcom_q6v5_pas: Add SoCCP node on Kaanapali Jingyi Wang
2025-12-23 20:15   ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3dcadb3-0239-4a49-a5ee-3c20ff97ea4e@kernel.org \
    --to=krzk@kernel.org \
    --cc=aiqun.yu@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jingyi.wang@oss.qualcomm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=robh@kernel.org \
    --cc=shengchao.guo@oss.qualcomm.com \
    --cc=sibi.sankar@oss.qualcomm.com \
    --cc=tingwei.zhang@oss.qualcomm.com \
    --cc=trilok.soni@oss.qualcomm.com \
    --cc=yijie.yang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox