Re: [PATCH 2/2] drm/panel: add BOE tv101wum-ll2 panel driver

[Neil Armstrong <neil.armstrong@linaro.org>]

On 24/07/2024 09:50, Neil Armstrong wrote:
> On 23/07/2024 21:17, Doug Anderson wrote:
>> Hi,
>>
>> On Tue, Jul 9, 2024 at 6:06 AM Neil Armstrong <neil.armstrong@linaro.org> wrote:
>>>

<snip>

>>
>>> +static int boe_tv101wum_ll2_get_modes(struct drm_panel *panel,
>>> +                                     struct drm_connector *connector)
>>> +{
>>> +       return drm_connector_helper_get_modes_fixed(connector, &boe_tv101wum_ll2_mode);
>>
>> Random question for you: on panels that don't use the
>> drm_connector_helper the "bpc" gets set here. Is there a reason why
>> some panel drivers (like this one) don't set bpc?
> 
> Good question, I'll check

Ok so the documentation says :
https://elixir.bootlin.com/linux/v6.11-rc5/source/include/drm/drm_connector.h#L698
	 * @bpc: Maximum bits per color channel. Used by HDMI and DP outputs.

and looking at the code, all drivers considers bpc=8 when unset.

but yeah ultimately drm_connector_helper_get_modes_fixed should have a variant to set the bpc
when != 8.

In this case it's useless.

Neil


<snip>