From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 186A0C433F5 for ; Thu, 28 Apr 2022 08:00:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343725AbiD1IDv (ORCPT ); Thu, 28 Apr 2022 04:03:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343727AbiD1IDn (ORCPT ); Thu, 28 Apr 2022 04:03:43 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 106859BADE for ; Thu, 28 Apr 2022 01:00:29 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id y3so7865901ejo.12 for ; Thu, 28 Apr 2022 01:00:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=hoO0z6ox/0MpErRBciBUS6KXmSs/8Ul8Shji/6D5s6Y=; b=jZR3MnpAJ0mog/qurS4zjfNeTVjwu1R7dSeZynWmrRUlEZfEoirRMAK3v6lTFs5aVR K/IrQ+bSRwQLSvEehuSzvgPTugl+v8t7cVjMD6NekHDNTbNmUGJIjGwK30LFkBdg48I/ mFEfqXI64C1SFJMPO3C7VNKI/9Xu8sN7YCfO/8g6Z6qTDHL/JaAXK9BKv+kdpnb5M7CQ 4MGS0X/j5eZ17YI1xOUk4alTxSK4qStpr7lX8GXDmhLB+qzov5iAeomdKLn5cFhbu5Pf LIqJV62giHlfnTfPfbUC/Z2SeHwsjm1udPgr43A8zInqYCW2xVtBRqLK23maRIk07asU s4PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hoO0z6ox/0MpErRBciBUS6KXmSs/8Ul8Shji/6D5s6Y=; b=GhiqQiHevqTi9cUbvqPM2i8eA1l216gUn4nbNZzp/AyYLURzGOXnsbabbDDFZbmUu7 dp8qoOSWi3Ft2ISNnoEA6a4q2q9sy4f2AY30OXafm1xAWvilzg5LEu+nsWhx9izxydsR JPcvbJud3aKbS5gI5d9jrpGNc2ohrAMJ4aXAbihKDPDQj316YX+MRaXvB9LBF/knZpCO UQOfSKws052B4tPy/isR0oE4pJ++VKo6s67lQ4ckBqJCED8GlZo+3kqaSB0aVkqlZ5d8 pdMTyt5yROH77HZTBRaKvI3fC5of7mebQAm9mx7n0wQGGPCXc2XqM5B+OApZJlJBK4gO cZNQ== X-Gm-Message-State: AOAM53112Q/6xBin6+pcf+o+uJfs+ev+aoa3pyjuw+LMmD7+WPMUzqUs uaUbJFpg7+nObeDf7KFqQZwb3w== X-Google-Smtp-Source: ABdhPJxY0l6cGk55GfOnpY/HEIBGRKGps3VQWZY7889JQ0r8sNS6Iig2RknQXv0yzdCXTzT7tNj+Nw== X-Received: by 2002:a17:906:2294:b0:6f3:bd02:95a3 with SMTP id p20-20020a170906229400b006f3bd0295a3mr9758882eja.201.1651132827289; Thu, 28 Apr 2022 01:00:27 -0700 (PDT) Received: from [192.168.0.161] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id h7-20020a1709060f4700b006e8d0746969sm7855860ejj.222.2022.04.28.01.00.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 01:00:26 -0700 (PDT) Message-ID: Date: Thu, 28 Apr 2022 10:00:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v5 3/3] dt-bindings: clock: qcom,gcc-apq8064: split tsens to the child node Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Amit Kucheria , Thara Gopinath , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, quic_tdas@quicinc.com References: <20220427125423.3166138-1-dmitry.baryshkov@linaro.org> <20220427125423.3166138-4-dmitry.baryshkov@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220427125423.3166138-4-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/04/2022 14:54, Dmitry Baryshkov wrote: > Split tsens properties to the child node of the gcc. This follows the > lead of ipq8064 (which also uses a separate node for tsens) and makes > device tree closer to other platforms, where tsens is a completely > separate device. > > Signed-off-by: Dmitry Baryshkov > --- > .../bindings/clock/qcom,gcc-apq8064.yaml | 49 +++++++++---------- > 1 file changed, 22 insertions(+), 27 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml > index bd7b04c75e50..3a8bb5a5b37f 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,gcc-apq8064.yaml > @@ -23,47 +23,42 @@ description: | > > properties: > compatible: > - enum: > - - qcom,gcc-apq8064 > - - qcom,gcc-msm8960 > - > - nvmem-cells: > - minItems: 1 > - maxItems: 2 > - description: > - Qualcomm TSENS (thermal sensor device) on some devices can > - be part of GCC and hence the TSENS properties can also be part > - of the GCC/clock-controller node. > - For more details on the TSENS properties please refer > - Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > - > - nvmem-cell-names: All these properties (and old compatible list) should be rather instead made deprecated:true. These bindings exists since some time, so it's not like refactoring during development. > - minItems: 1 > items: > - - const: calib > - - const: calib_backup > + - enum: > + - qcom,gcc-apq8064 > + - qcom,gcc-msm8960 > + - const: syscon > + > + thermal-sensor: > + type: object > > - '#thermal-sensor-cells': > - const: 1 > + allOf: > + - $ref: /schemas/thermal/qcom-tsens.yaml# No need for allOf and type, just $ref and description. > > required: > - compatible > - - nvmem-cells > - - nvmem-cell-names > - - '#thermal-sensor-cells' > > unevaluatedProperties: false Best regards, Krzysztof