From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4279C4332F for ; Mon, 21 Nov 2022 08:50:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230059AbiKUIuS (ORCPT ); Mon, 21 Nov 2022 03:50:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229590AbiKUIuR (ORCPT ); Mon, 21 Nov 2022 03:50:17 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD5277ECB4 for ; Mon, 21 Nov 2022 00:50:16 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id g7so17809786lfv.5 for ; Mon, 21 Nov 2022 00:50:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=k+tVJyc1L1GHiwD6JNInxUbkk05ZPiRwgmjlT/SkiMs=; b=gKGZQu2y6mg/8WHMd//eEFJILPyHxaZ2cRHFgJz6kT2msFXq4g2wX2d5YF0ssbr04d osoEN8dmIBl6od9V5UdHJ7xLiSrp6LaCgK7PJ4PdVE+LpsS6xGH+qKqCmAReatUGB2xT TfYShpuRvqqcDkvcAqtb48/MwpxEBuMIayo9h3rZZtWzTkphZXXdamjP2uMyX0mkA5km 73yXC2w83xl092duhGELypFZOFwzlbizkXg0wfoP+7loHzvaWAwRyGqyRyRDdcJ8EHzE 4qGy5vorawf6vIHOjsgvCcq7SzOEfzU9nMU11efa8d3B7ek0SNarfpAoLzA8w7Bl3wV1 8pYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=k+tVJyc1L1GHiwD6JNInxUbkk05ZPiRwgmjlT/SkiMs=; b=hUOd1h15tQoby88Lys8ghpwKI2aNmEBGjIL1bbppZM4cWHsIZC2v0MVKDgK48t0LkS sAlcLJMSkAlUEblbuWgGNnGS1I5NwYiUQV3hEjIC2lHy1LqmXFKGmHERF268U063Tvjo CuTsd69OtBYc2lter0I3pE1eAgUAx80thkpJXEh+qChN3E3kqbGfJaFg3ea/zbpJ6en5 KpY8JJwm0J58yvn8gmhnP4HxIwAUdwhZY8mifKGdO5wJPzfYNdEl8LHn51vnsMSlb2s1 9og7bXmMNxTsTPpU2vU/oFY3phOI0Msc9kx6Dykis104CDLxT+bPUQk/ZjJinqtdwCxt Q6/Q== X-Gm-Message-State: ANoB5pkqxTbqL9tPSAaagt3N2gvjpf3YmKKOI5KSGq49FyRRpORhAdau IkZKWmLtyzWmxjzjXXMCGjEPYQ== X-Google-Smtp-Source: AA0mqf58KjMdv56Ofm6F9NuTs0Nbk9Pu3XnmSVj7yu0e6lJ2r5xkwkF38bsTGDcua+lPe1NMFfJtUw== X-Received: by 2002:a19:4f02:0:b0:4a2:1d18:45d8 with SMTP id d2-20020a194f02000000b004a21d1845d8mr5383607lfb.330.1669020615158; Mon, 21 Nov 2022 00:50:15 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id d14-20020a056512368e00b00494706193adsm1949906lfs.208.2022.11.21.00.50.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Nov 2022 00:50:14 -0800 (PST) Message-ID: Date: Mon, 21 Nov 2022 09:50:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 08/14] dt-bindings: reset: Add StarFive JH7110 system and always-on reset definitions Content-Language: en-US To: Hal Feng , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Cc: Conor Dooley , Palmer Dabbelt , Rob Herring , Krzysztof Kozlowski , Stephen Boyd , Michael Turquette , Philipp Zabel , Emil Renner Berthing , linux-kernel@vger.kernel.org References: <20221118010627.70576-1-hal.feng@starfivetech.com> <20221118010627.70576-9-hal.feng@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20221118010627.70576-9-hal.feng@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/11/2022 02:06, Hal Feng wrote: > From: Emil Renner Berthing > > Add resets for the StarFive JH7110 system (SYS) and always-on (AON) > reset controller. > > Signed-off-by: Emil Renner Berthing > Signed-off-by: Hal Feng > --- > MAINTAINERS | 5 +- > include/dt-bindings/reset/starfive-jh7110.h | 154 ++++++++++++++++++++ > 2 files changed, 157 insertions(+), 2 deletions(-) > create mode 100644 include/dt-bindings/reset/starfive-jh7110.h > Thank you for your patch. There is something to discuss/improve. > +#define JH7110_SYSRST_TIMER0 118 > +#define JH7110_SYSRST_TIMER1 119 > +#define JH7110_SYSRST_TIMER2 120 > +#define JH7110_SYSRST_TIMER3 121 > +#define JH7110_SYSRST_INT_CTRL_APB 122 > +#define JH7110_SYSRST_TEMP_APB 123 > +#define JH7110_SYSRST_TEMP_CORE 124 > +#define JH7110_SYSRST_JTAG_CERTIFICATION 125 > + > +#define JH7110_SYSRST_END 126 Drop weird indentation in the middle of syntax. > + > +/* AONCRG resets */ > +#define JH7110_AONRST_GMAC0_AXI 0 > +#define JH7110_AONRST_GMAC0_AHB 1 > +#define JH7110_AONRST_AON_IOMUX 2 > +#define JH7110_AONRST_PMU_APB 3 > +#define JH7110_AONRST_PMU_WKUP 4 > +#define JH7110_AONRST_RTC_APB 5 > +#define JH7110_AONRST_RTC_CAL 6 > +#define JH7110_AONRST_RTC_32K 7 > + > +#define JH7110_AONRST_END 8 Ditto > + > +#endif /* __DT_BINDINGS_RESET_STARFIVE_JH7110_H__ */ Best regards, Krzysztof