From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67EBAC4332F for ; Fri, 15 Oct 2021 13:47:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F77D611C8 for ; Fri, 15 Oct 2021 13:47:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239979AbhJONti (ORCPT ); Fri, 15 Oct 2021 09:49:38 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:34886 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239990AbhJONth (ORCPT ); Fri, 15 Oct 2021 09:49:37 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 869101F4536F Subject: Re: [PATCH v4 03/13] memory: mtk-smi: Use clk_bulk clock ops To: Krzysztof Kozlowski , Yong Wu , Rob Herring , Matthias Brugger Cc: Krzysztof Kozlowski , Joerg Roedel , Will Deacon , Robin Murphy , Tomasz Figa , linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org, youlin.pei@mediatek.com, anan.sun@mediatek.com, ming-fan.chen@mediatek.com, yi.kuo@mediatek.com, anthony.huang@mediatek.com, Ikjoon Jang References: <20210914113703.31466-1-yong.wu@mediatek.com> <20210914113703.31466-4-yong.wu@mediatek.com> From: AngeloGioacchino Del Regno Message-ID: Date: Fri, 15 Oct 2021 15:47:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Il 15/10/21 15:43, Krzysztof Kozlowski ha scritto: > On 15/10/2021 15:38, AngeloGioacchino Del Regno wrote: >>> Use clk_bulk interface instead of the orginal one to simplify the code. >>> >>> For SMI larbs: Require apb/smi clocks while gals is optional. >>> For SMI common: Require apb/smi/gals0/gal1 in has_gals case. Otherwise, >>> also only require apb/smi, No optional clk here. >>> >>> About the "has_gals" flag, for smi larbs, the gals clock also may be >>> optional even this platform support it. thus it always use >>> *_bulk_get_optional, then the flag has_gals is unnecessary. Remove it. >>> The smi_common's has_gals still keep it. >>> >>> Also remove clk fail logs since bulk interface already output fail log. >>> >>> Signed-off-by: Yong Wu >> >> Hello Yong, >> thanks for the patch! However, I have an improvement to point out: >> >>> --- >>> drivers/memory/mtk-smi.c | 143 +++++++++++++++------------------------ >>> 1 file changed, 55 insertions(+), 88 deletions(-) >>> >>> diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c >>> index c5fb51f73b34..f91eaf5c3ab0 100644 >>> --- a/drivers/memory/mtk-smi.c >>> +++ b/drivers/memory/mtk-smi.c >>> @@ -60,6 +60,20 @@ enum mtk_smi_gen { >>> MTK_SMI_GEN2 >>> }; >>> >>> +#define MTK_SMI_CLK_NR_MAX 4 >> >> This refers to mtk_smi_common_clks[] and should be probably moved after that. >> In any case, I don't think that there's any need to manually define this as 4, >> as you can simply use the macro ARRAY_SIZE(mtk_smi_common_clks). >> Using that will make you able to not update this definition everytime an update >> occurs to the mtk_smi_common_clks array. >> >>> + >>> +/* larbs: Require apb/smi clocks while gals is optional. */ >>> +static const char * const mtk_smi_larb_clks[] = {"apb", "smi", "gals"}; >>> +#define MTK_SMI_LARB_REQ_CLK_NR 2 >>> +#define MTK_SMI_LARB_OPT_CLK_NR 1 >>> + >>> +/* >>> + * common: Require these four clocks in has_gals case. Otherwise, only apb/smi are required. >>> + */ >>> +static const char * const mtk_smi_common_clks[] = {"apb", "smi", "gals0", "gals1"}; >>> +#define MTK_SMI_COM_REQ_CLK_NR 2 >>> +#define MTK_SMI_COM_GALS_REQ_CLK_NR MTK_SMI_CLK_NR_MAX >>> + >> >> Apart from that, >> Acked-By: AngeloGioacchino Del Regno > > The patchset was merged around a month ago: > https://lore.kernel.org/lkml/163229303729.7874.4095337797772755570.b4-ty@canonical.com/ > > > Best regards, > Krzysztof > Whoops. Sorry for that. I'll send a patch to address what I pointed out, unless the original author of this series wants to. Thanks, - Angelo