From: Krzysztof Kozlowski <krzk@kernel.org>
To: Javier Carrasco <javier.carrasco.cruz@gmail.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Julia Lawall <julia.lawall@inria.fr>
Cc: "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
devicetree@vger.kernel.org,
"Péter Ujfalusi" <peter.ujfalusi@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: DT schema bindings conversion mentorships (was Re: [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema)
Date: Thu, 23 May 2024 08:12:56 +0200 [thread overview]
Message-ID: <e43b0e4f-4eae-4667-9fe7-7d1f07c46b68@kernel.org> (raw)
In-Reply-To: <292d220d-2177-4516-a391-4695bffc2ab5@gmail.com>
On 22/05/2024 19:47, Javier Carrasco wrote:
>> https://social.kernel.org/notice/Ai9hYRUKo8suzX3zNY
>>
>> 1. Please convert bindings which have active DTS users. First choose
>> bindings with DTS built by arm64 defconfig, then next choice by arm
>> multi_v7 defconfig. Then any other ARM or different architecture DTS.
>>
>> 2. Be sure dt_bindings_check (including yamllint) and checkpatch pass
>> without any warnings. See writing-schema.rst document.
>>
>> 3. Be sure DTS using these bindings passes dtbs_check validation. If
>> this means binding needs to be adapted during conversion, mention
>> briefly in the commit message changes done comparing to pure TXT->DT
>> schema conversion.
>>
>> Best regards,
>> Krzysztof
>>
>
>
> Hello Krzysztof,
>
> Several mentees from the Linux Kernel Mentorship Program have been
> converting bindings within the last weeks, but it was not a programmed
> task from the mentorship as such. They are free to choose the areas
> where they want to contribute, and some of them chose that one.
> Therefore no direct contact with the subsystem maintainers was
> established. We will keep an eye on that too, so we can anticipate such
> misunderstandings and additional work for the maintainers.
>
> Nonetheless, I saw that some our mentees sent such faulty/pointless
> conversions a few days ago, and they received some guidelines and links
> to the official documentation yesterday. All points you mentioned were
> covered, so the next patches should look better.
>
> Usually their patches are sent to the mentors first for a preliminary
> review, but sometimes that step gets "bypassed". We will insist on the
> preliminary review, at least for the first conversions.
>
> Apologies for any faulty patch they might still send directly/not taking
> those points into account.
>
> Thank you so much for your patience and feedback.
Sounds good, thanks Javier!
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-05-23 6:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-22 7:52 [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema Mighty
2024-05-22 8:42 ` Krzysztof Kozlowski
2024-05-22 13:46 ` Mithil
2024-05-22 14:15 ` Krzysztof Kozlowski
2024-05-22 13:56 ` Péter Ujfalusi
2024-05-22 14:16 ` Krzysztof Kozlowski
2024-05-22 14:43 ` Péter Ujfalusi
2024-05-22 15:22 ` Krzysztof Kozlowski
2024-05-22 16:01 ` Péter Ujfalusi
2024-05-22 16:42 ` Krzysztof Kozlowski
2024-05-22 17:02 ` Mithil
2024-05-22 17:07 ` Mithil
2024-05-22 17:07 ` Krzysztof Kozlowski
2024-05-22 17:30 ` Mithil
2024-05-22 17:47 ` Mithil
2024-05-22 18:49 ` Péter Ujfalusi
2024-05-22 18:39 ` Péter Ujfalusi
2024-05-23 6:08 ` Krzysztof Kozlowski
2024-05-22 17:05 ` DT schema bindings conversion mentorships (was Re: [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema) Krzysztof Kozlowski
2024-05-22 17:47 ` Javier Carrasco
2024-05-23 6:12 ` Krzysztof Kozlowski [this message]
2024-05-22 18:36 ` Conor Dooley
2024-05-23 12:33 ` Daniel Baluta
2024-05-23 12:30 ` Daniel Baluta
2024-05-23 16:24 ` Rob Herring
2024-05-23 16:31 ` Javier Carrasco
2024-05-22 14:22 ` [PATCH v5] ASoC: dt-bindings: omap-mcpdm: Convert to DT schema Rob Herring
2024-05-22 14:39 ` Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e43b0e4f-4eae-4667-9fe7-7d1f07c46b68@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=julia.lawall@inria.fr \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@gmail.com \
--cc=robh@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).