From: Stephen Boyd <sboyd@kernel.org>
To: Jacky Huang <ychuang570808@gmail.com>,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
krzysztof.kozlowski+dt@linaro.org, lee@kernel.org,
mturquette@baylibre.com, p.zabel@pengutronix.de,
robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
arnd@arndb.de, schung@nuvoton.com, mjchen@nuvoton.com,
Jacky Huang <ychuang3@nuvoton.com>
Subject: Re: [PATCH v6 08/12] arm64: dts: nuvoton: Add initial ma35d1 device tree
Date: Wed, 29 Mar 2023 10:52:01 -0700 [thread overview]
Message-ID: <e45cd7bb6dce2b8b2f08d3b3bd96bb06.sboyd@kernel.org> (raw)
In-Reply-To: <458d454e-64ba-849a-38cb-88bf016f5a2e@gmail.com>
Quoting Jacky Huang (2023-03-28 23:02:31)
>
> On 2023/3/29 上午 11:54, Stephen Boyd wrote:
> > Quoting Jacky Huang (2023-03-28 20:43:23)
> >
> >> We just employ regmap mechansim for the access to REG_SYS_RLKTZNS register.
> >> Is this implementation OK for you? Thank you.
> >>
> > No. Why can't that be a hwspinlock? Or why can't it be unlocked all the
> > time and rely on software spinlocks in the kernel to prevent concurrent
> > access to the registers accessed by a driver, like a lock for the clk
> > registers and a lock for the reset registers, etc. Or if no two clks or
> > resets exist within one 32-bit word then no lock is necessary.
>
> You gave a good suggestion here. Yes, of course we can let it be
> unlocked all the time.
> We can unlock the "register lock" before entering Linux.
> As a result, the unlonk and lock register related code is not required.
> Thus, we can remove syscon from the clock controller node.
>
> If you agree with this, we will modify it in the next version.
>
Sure, that works.
next prev parent reply other threads:[~2023-03-29 17:52 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 2:19 [PATCH v6 00/12] Introduce Nuvoton ma35d1 SoC Jacky Huang
2023-03-28 2:19 ` [PATCH v6 01/12] arm64: Kconfig.platforms: Add config for Nuvoton MA35 platform Jacky Huang
2023-03-28 2:19 ` [PATCH v6 02/12] arm64: defconfig: Add support for Nuvoton MA35 family SoCs Jacky Huang
2023-03-28 2:19 ` [PATCH v6 03/12] dt-bindings: clock: nuvoton: add binding for ma35d1 clock controller Jacky Huang
2023-03-29 8:14 ` Krzysztof Kozlowski
2023-03-28 2:19 ` [PATCH v6 04/12] dt-bindings: reset: nuvoton: add binding for ma35d1 IP reset control Jacky Huang
2023-03-28 17:48 ` Stephen Boyd
2023-03-29 8:53 ` Jacky Huang
2023-03-29 8:17 ` Krzysztof Kozlowski
2023-03-29 9:12 ` Jacky Huang
2023-03-29 9:27 ` Krzysztof Kozlowski
2023-03-29 9:33 ` Jacky Huang
2023-03-28 2:19 ` [PATCH v6 05/12] dt-bindings: mfd: syscon: Add nuvoton,ma35d1-sys compatible Jacky Huang
2023-04-05 15:27 ` Lee Jones
2023-03-28 2:19 ` [PATCH v6 06/12] dt-bindings: arm: Add initial bindings for Nuvoton platform Jacky Huang
2023-03-28 15:41 ` kernel test robot
2023-03-29 8:19 ` Krzysztof Kozlowski
2023-03-29 8:32 ` Jacky Huang
2023-03-29 13:07 ` Rob Herring
2023-03-30 10:41 ` Jacky Huang
2023-03-30 13:25 ` Krzysztof Kozlowski
2023-03-31 2:15 ` Jacky Huang
2023-04-03 20:33 ` Rob Herring
2023-04-06 2:09 ` Jacky Huang
2023-03-28 2:19 ` [PATCH v6 07/12] dt-bindings: serial: Document ma35d1 uart controller Jacky Huang
2023-03-29 8:20 ` Krzysztof Kozlowski
2023-03-29 8:44 ` Jacky Huang
2023-03-30 7:33 ` Krzysztof Kozlowski
2023-03-30 10:52 ` Jacky Huang
2023-03-30 13:12 ` Rob Herring
2023-03-31 2:03 ` Jacky Huang
2023-03-28 2:19 ` [PATCH v6 08/12] arm64: dts: nuvoton: Add initial ma35d1 device tree Jacky Huang
2023-03-28 17:57 ` Stephen Boyd
2023-03-29 2:03 ` Jacky Huang
2023-03-29 2:19 ` Stephen Boyd
2023-03-29 2:39 ` Jacky Huang
2023-03-29 2:46 ` Stephen Boyd
2023-03-29 3:13 ` Jacky Huang
2023-03-29 3:25 ` Stephen Boyd
2023-03-29 3:43 ` Jacky Huang
2023-03-29 3:54 ` Stephen Boyd
2023-03-29 6:02 ` Jacky Huang
2023-03-29 17:52 ` Stephen Boyd [this message]
2023-03-29 8:21 ` Krzysztof Kozlowski
2023-03-29 8:36 ` Jacky Huang
2023-03-28 2:19 ` [PATCH v6 09/12] clk: nuvoton: Add clock driver for ma35d1 clock controller Jacky Huang
2023-03-28 18:18 ` Stephen Boyd
2023-03-30 10:36 ` Jacky Huang
2023-03-28 2:19 ` [PATCH v6 10/12] reset: Add Nuvoton ma35d1 reset driver support Jacky Huang
2023-04-24 20:02 ` Philipp Zabel
2023-04-25 1:22 ` Jacky Huang
2023-03-28 2:19 ` [PATCH v6 11/12] tty: serial: Add Nuvoton ma35d1 serial " Jacky Huang
2023-03-28 9:23 ` Jiri Slaby
2023-03-29 8:06 ` Jacky Huang
2023-03-31 0:29 ` kernel test robot
2023-03-28 2:19 ` [PATCH v6 12/12] MAINTAINERS: Add entry for NUVOTON MA35 Jacky Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e45cd7bb6dce2b8b2f08d3b3bd96bb06.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mjchen@nuvoton.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=schung@nuvoton.com \
--cc=ychuang3@nuvoton.com \
--cc=ychuang570808@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).