From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B502BC7EE24 for ; Tue, 9 May 2023 06:25:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234881AbjEIGZR (ORCPT ); Tue, 9 May 2023 02:25:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234872AbjEIGZR (ORCPT ); Tue, 9 May 2023 02:25:17 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 448D9A5F4 for ; Mon, 8 May 2023 23:25:13 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-50db7f0a1b4so678127a12.3 for ; Mon, 08 May 2023 23:25:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683613511; x=1686205511; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TfYutvSnmG0xToTn7QuW3dip61h04rlgqKGBarW0D6c=; b=FFt4aoW2plUl9LBzp86tsiKAP2L9t6isoWwmEom+HSgYeKssPi9XIK42kNricy7P+d MenvmyDOSxmQfo42+yeLTxiENNbV6LdR5IBOq+d0oFgBQ8iiXrhxJoI+NtIjnN73LVoQ FpjsGop5ymBBpkI+eedhjaFngehkvES2xMjyEr+aBnsUB596DBooBZCAlP8OL3jGuSsP Jg1wn+ipDeALdiXOUFNo2YoekShzOd17yOfh/SsV3Ce96nNDkwDw3ZYcOTVNj4X2S6kb cY/p0/U/JF2g1dKzbKQ9HkMC0+VHSd48LurAB2fDzEf6hZ/Gf5/SRU3cIX2aPfqEZXSs CqhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683613511; x=1686205511; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TfYutvSnmG0xToTn7QuW3dip61h04rlgqKGBarW0D6c=; b=e1PVF/TAaWJgh9xpya6fN4k1DbAmLEkmZd4gSbi2brmRgcnLq0o20w7fKUmxRaJeOL ++059c8rq33Ws7ynxkUDU/lFFMMSHvo5KWP8cUveh1CJSlV5UmGQLsPBVPkODQt4QklI VWGT0xdPSzyza6w8SNPgLJYJeM+JsAAcOGYirFUMI3K48VbjJT2bQU6tb8pJAGOVrW3X Y2oG1qiWKrMoJxBRkBB3a/dUNnbheVNSkRURsd+AOwjZuN+vaWWoKhZuSw2jn/GWdTOA x054Zl33wHqmZBkZY6n3/hTRtwx8ximcRbsCKe/1zDOpBqbiccoM4mXqUOi+0MaU9A1X Sekg== X-Gm-Message-State: AC+VfDyBJKWlTlBWVky0h/zEDfwPhiadrKtoAhjm9G5ysI3SR1OFFmeT yQSotrABt6uDV3m5wWYVm+RcYg== X-Google-Smtp-Source: ACHHUZ4c7ZhS+2SHxTATjrVi07zz9QxVLQYPzgHka/2yGmY9HGKxWiS52td6vghMy16CRpuFKbm8AA== X-Received: by 2002:a50:fe8c:0:b0:506:ba8d:c317 with SMTP id d12-20020a50fe8c000000b00506ba8dc317mr9294753edt.40.1683613511519; Mon, 08 May 2023 23:25:11 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:d0d5:7818:2f46:5e76? ([2a02:810d:15c0:828:d0d5:7818:2f46:5e76]) by smtp.gmail.com with ESMTPSA id j10-20020aa7ca4a000000b005066cadcc54sm360829edt.43.2023.05.08.23.25.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 23:25:11 -0700 (PDT) Message-ID: Date: Tue, 9 May 2023 08:25:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3 2/5] dt-bindings: clocks: atmel,at91rm9200-pmc: convert to yaml Content-Language: en-US To: Claudiu Beznea , mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230509052757.539274-1-claudiu.beznea@microchip.com> <20230509052757.539274-3-claudiu.beznea@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <20230509052757.539274-3-claudiu.beznea@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 09/05/2023 07:27, Claudiu Beznea wrote: > Convert Atmel PMC documentation to yaml. Along with it clock names > were adapted according to the current available device trees as > different controller versions accept different clocks (some of them > have 3 clocks as input, some has 2 clocks as inputs and some with 2 > input clocks uses different clock names). > Thank you for your patch. There is something to discuss/improve. > +title: Atmel Power Management Controller (PMC) > + > +maintainers: > + - Claudiu Beznea > + > +description: > + The power management controller optimizes power consumption by controlling all > + system and user peripheral clocks. The PMC enables/disables the clock inputs > + to many of the peripherals and to the processor. > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - atmel,at91sam9g15-pmc > + - atmel,at91sam9g20-pmc > + - atmel,at91sam9g25-pmc > + - atmel,at91sam9g35-pmc > + - atmel,at91sam9x25-pmc > + - atmel,at91sam9x35-pmc > + - enum: > + - atmel,at91sam9260-pmc > + - atmel,at91sam9x5-pmc I missed it last time - why you have two enums? We never talked about this. It's usually wrong... are you sure this is real hardware: atmel,at91sam9g20-pmc, atmel,at91sam9260-pmc ? > + - const: syscon > + - items: > + - enum: > + - atmel,at91rm9200-pmc > + - atmel,at91sam9260-pmc > + - atmel,at91sam9g45-pmc > + - atmel,at91sam9n12-pmc > + - atmel,at91sam9rl-pmc > + - atmel,sama5d2-pmc > + - atmel,sama5d3-pmc > + - atmel,sama5d4-pmc > + - microchip,sam9x60-pmc > + - microchip,sama7g5-pmc > + - const: syscon > + Best regards, Krzysztof