From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A95FC4167B for ; Tue, 29 Nov 2022 08:54:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbiK2IyP (ORCPT ); Tue, 29 Nov 2022 03:54:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231540AbiK2IyE (ORCPT ); Tue, 29 Nov 2022 03:54:04 -0500 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D4CE4AF1F for ; Tue, 29 Nov 2022 00:53:52 -0800 (PST) Received: by mail-lf1-x12c.google.com with SMTP id be13so21438135lfb.4 for ; Tue, 29 Nov 2022 00:53:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/392GykBtHnWPhSp8IdLCn51RY5siGcKVRp0TZIw73Y=; b=AfYOt9xgm8N8sshzqyj5GnPwFJ+Ud+2wHuhE1yU3oqhrEDFnCD4wJ2lbOzn4uBuEqA MmcMBM/HS258xdVZOPmlsr5Uas2/bX4R7UcVjJFhEweaWCbGW0YGXzQizUo8Y/N9EluR m8vQaDohkKsTnOb2yYTpBzNB9LwCda3WIj/pzf1uZyzvjCJWWHazyjFIAc2dl8otHUre +TwGaKsmEzid8rfKECqH9ajtV48SGwvPjZ9Amehm/jOcLDuvTXO63YEqq96IfoZjvgoc I+gdbV5hF9a31nqhycfBvK+iWVglwEoi459sE6Z1PNunrHNbIBL0PwPLup+s6WQK1nAg 6kog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/392GykBtHnWPhSp8IdLCn51RY5siGcKVRp0TZIw73Y=; b=jJyU3X0qZ7gWBNopJsFMlcxim2g2Hs5hzeimPQIZIs3zAW42SCMmG4Fgz6hieXiixg t/+VZUt9JZN+/FG0pigPcIGpJV4RE3kv7FC26Wi2ihgcl20E06i8ebfMBlfU9Q6tOhYQ BuZh49B5QVlto0rxIG+ywGUgxcOzfS5QGmd//NFPMI5O+03r08QKLcZENXXdPsct4CYB ulFXnkBxIauGYo0Z44xYjBC8ECd70zPTyGbUscwWmlcSgy3F2x2UaB4PNVkWIOKVb+P4 spPUrCcqcx2OYQFBI1rIGsgv1gujIp951vI/Zgb1c0opvnoYfcCU4SX98rkJ9SnEIy+4 2t2A== X-Gm-Message-State: ANoB5pnlcu7Xc5ZWMkGC16MPqxgD1DeMjMyyL8bAVXSjZ1PSClr9Kp31 xt7EugaqP7NWBuTh/uSuDHF5Ug== X-Google-Smtp-Source: AA0mqf6qdim8gakdaimBGD+ZKNfFkTChiA2i2Pgz4m5bIeVxjSENpVtYCe5fSjJHTQfXRwe9Xutn2A== X-Received: by 2002:a05:6512:3703:b0:4a2:22cf:f44d with SMTP id z3-20020a056512370300b004a222cff44dmr13149775lfr.118.1669712030458; Tue, 29 Nov 2022 00:53:50 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id c13-20020a056512324d00b004b40f2e25d3sm2133465lfr.122.2022.11.29.00.53.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 00:53:50 -0800 (PST) Message-ID: Date: Tue, 29 Nov 2022 09:53:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 2/2] ethernet: stmicro: stmmac: Add SGMII/QSGMII support for RK3568 Content-Language: en-US To: Chukun Pan , "David S . Miller" Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , David Wu , Rob Herring , Heiko Stuebner , Krzysztof Kozlowski , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20221129072714.22880-1-amadeus@jmu.edu.cn> <20221129072714.22880-2-amadeus@jmu.edu.cn> From: Krzysztof Kozlowski In-Reply-To: <20221129072714.22880-2-amadeus@jmu.edu.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/11/2022 08:27, Chukun Pan wrote: > From: David Wu > > The gmac of RK3568 supports RGMII/SGMII/QSGMII interface. > This patch adds the remaining SGMII/QSGMII support. Do not use "This commit/patch". https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > Run-tested-on: Ariaboard Photonicat (GMAC0 SGMII) > > Signed-off-by: David Wu > [rebase, rewrite commit message] > Signed-off-by: Chukun Pan > --- > .../net/ethernet/stmicro/stmmac/dwmac-rk.c | 210 +++++++++++++++++- > 1 file changed, 207 insertions(+), 3 deletions(-) > > > -static int phy_power_on(struct rk_priv_data *bsp_priv, bool enable) > +static int rk_gmac_phy_power_on(struct rk_priv_data *bsp_priv, bool enable) > { > struct regulator *ldo = bsp_priv->regulator; > int ret; > @@ -1728,6 +1909,18 @@ static struct rk_priv_data *rk_gmac_setup(struct platform_device *pdev, > "rockchip,grf"); > bsp_priv->php_grf = syscon_regmap_lookup_by_phandle(dev->of_node, > "rockchip,php-grf"); > + bsp_priv->xpcs = syscon_regmap_lookup_by_phandle(dev->of_node, > + "rockchip,xpcs"); > + if (!IS_ERR(bsp_priv->xpcs)) { > + struct phy *comphy; > + > + comphy = devm_of_phy_get(&pdev->dev, dev->of_node, NULL); So instead of having PHY driver, you added a syscon and implemented PHY driver here. No. Make a proper PHY driver. Best regards, Krzysztof