From: Sumit Gupta <sumitg@nvidia.com>
To: Rob Herring <robh@kernel.org>
Cc: <linux-tegra@vger.kernel.org>, <devicetree@vger.kernel.org>,
<thierry.reding@gmail.com>, <robh+dt@kernel.org>,
<linux-kernel@vger.kernel.org>, <jonathanh@nvidia.com>,
<jsequeira@nvidia.com>, <bbasu@nvidia.com>, <vsethi@nvidia.com>,
Sumit Gupta <sumitg@nvidia.com>
Subject: Re: [Patch Resend v1 5/8] dt-bindings: arm: tegra: Add NVIDIA Tegra234 CBB2.0 binding
Date: Fri, 10 Dec 2021 12:56:58 +0530 [thread overview]
Message-ID: <e46a73c0-df70-fd8d-82e2-b29a8f6fb917@nvidia.com> (raw)
In-Reply-To: <1639083359.670183.3925943.nullmailer@robh.at.kernel.org>
Hi Rob,
>> Add device-tree binding documentation to represent CBB2.0 (Control
>> Backbone) error handling driver. The driver prints debug information
>> about failed transaction on receiving interrupt from CBB2.0.
>>
>> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
>> ---
>> .../arm/tegra/nvidia,tegra234-cbb.yaml | 80 +++++++++++++++++++
>> 1 file changed, 80 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/arm/tegra/nvidia,tegra234-cbb.yaml
>>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
Ok. Will check and correct this in v2.
>
> yamllint warnings/errors:
> ./Documentation/devicetree/bindings/arm/tegra/nvidia,tegra234-cbb.yaml:73:1: [error] syntax error: found character '\t' that cannot start any token (syntax)
>
> dtschema/dtc warnings/errors:
> make[1]: *** Deleting file 'Documentation/devicetree/bindings/arm/tegra/nvidia,tegra234-cbb.example.dts'
> Traceback (most recent call last):
> File "/usr/local/bin/dt-extract-example", line 45, in <module>
> binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
> File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 434, in load
> return constructor.get_single_data()
> File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 119, in get_single_data
> node = self.composer.get_single_node()
> File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
> File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
> File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
> File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
> File "_ruamel_yaml.pyx", line 773, in _ruamel_yaml.CParser._compose_node
> File "_ruamel_yaml.pyx", line 848, in _ruamel_yaml.CParser._compose_sequence_node
> File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
> ruamel.yaml.scanner.ScannerError: while scanning a block scalar
> in "<unicode string>", line 71, column 5
> found a tab character where an indentation space is expected
> in "<unicode string>", line 73, column 1
> make[1]: *** [Documentation/devicetree/bindings/Makefile:25: Documentation/devicetree/bindings/arm/tegra/nvidia,tegra234-cbb.example.dts] Error 1
> make[1]: *** Waiting for unfinished jobs....
> ./Documentation/devicetree/bindings/arm/tegra/nvidia,tegra234-cbb.yaml: while scanning a block scalar
> in "<unicode string>", line 71, column 5
> found a tab character where an indentation space is expected
> in "<unicode string>", line 73, column 1
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra234-cbb.yaml: ignoring, error parsing file
> warning: no schema found in file: ./Documentation/devicetree/bindings/arm/tegra/nvidia,tegra234-cbb.yaml
> make: *** [Makefile:1413: dt_binding_check] Error 2
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/patch/1565951
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
next prev parent reply other threads:[~2021-12-10 7:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-09 17:21 [Patch Resend v1 0/8] CBB driver for Tegra194, Tegra234 & Tegra-Grace Sumit Gupta
2021-12-09 17:21 ` [Patch Resend v1 1/8] soc: tegra: set ERD bit to mask inband errors Sumit Gupta
2021-12-09 17:22 ` [Patch Resend v1 2/8] dt-bindings: arm: tegra: Add NVIDIA Tegra194 CBB1.0 binding Sumit Gupta
2021-12-09 20:55 ` Rob Herring
2021-12-09 17:22 ` [Patch Resend v1 3/8] arm64: tegra: Add node for CBB1.0 in Tegra194 SOC Sumit Gupta
2021-12-09 17:22 ` [Patch Resend v1 4/8] soc: tegra: cbb: Add CBB1.0 driver for Tegra194 Sumit Gupta
2021-12-09 17:22 ` [Patch Resend v1 5/8] dt-bindings: arm: tegra: Add NVIDIA Tegra234 CBB2.0 binding Sumit Gupta
2021-12-09 20:55 ` Rob Herring
2021-12-10 7:26 ` Sumit Gupta [this message]
2021-12-16 11:30 ` Thierry Reding
2021-12-16 15:06 ` Sumit Gupta
2021-12-16 16:38 ` Thierry Reding
2021-12-16 18:35 ` Sumit Gupta
2021-12-09 17:22 ` [Patch Resend v1 6/8] arm64: tegra: Add node for CBB2.0 in Tegra234 SOC Sumit Gupta
2021-12-09 17:22 ` [Patch Resend v1 7/8] soc: tegra: cbb: Add driver for Tegra234 CBB2.0 Sumit Gupta
2021-12-09 17:22 ` [Patch Resend v1 8/8] soc: tegra: cbb: Add support for tegra-grace SOC Sumit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e46a73c0-df70-fd8d-82e2-b29a8f6fb917@nvidia.com \
--to=sumitg@nvidia.com \
--cc=bbasu@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=jsequeira@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vsethi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).