devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vikash Garodia <vgarodia@codeaurora.org>
To: Stanimir Varbanov <stanimir.varbanov@linaro.org>
Cc: hverkuil@xs4all.nl, mchehab@kernel.org, robh@kernel.org,
	mark.rutland@arm.com, andy.gross@linaro.org, arnd@arndb.de,
	bjorn.andersson@linaro.org, linux-media@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-soc@vger.kernel.org, devicetree@vger.kernel.org,
	acourbot@chromium.org, linux-media-owner@vger.kernel.org
Subject: Re: [PATCH v3 3/4] venus: firmware: add no TZ boot and shutdown routine
Date: Mon, 06 Aug 2018 13:48:52 +0530	[thread overview]
Message-ID: <e482a9af27288c9e8a8ffb5c1de8a209@codeaurora.org> (raw)
In-Reply-To: <4727000d-96ef-2dc5-50df-6bdadcaa156e@linaro.org>

Hi Stanimir,

Thanks for your review.

On 2018-07-25 15:06, Stanimir Varbanov wrote:
> Hi Vikash,
> 
> On 07/04/2018 10:06 PM, Vikash Garodia wrote:
> 
<snip>

>> 
>>  #define VENUS_PAS_ID			9
>> -#define VENUS_FW_MEM_SIZE		(6 * SZ_1M)
>> +#define VENUS_FW_MEM_SIZE		(5 * SZ_1M)
> 
> This change should be subject to a separate patch.
Ok.

> 
<snip>

>> +	writel_relaxed(reg, reg_base + WRAPPER_A9SS_SW_RESET);
>> +
>> +	/* Make sure reset is asserted before the mapping is removed */
>> +	mb();
> 
> mb() is used for compiler barrier as far as I know, isn't better to 
> just
> read the register and keep the comment?

mb() can ensure that the instructions are ordered. This is needed to 
ensure
reset before the mapping is removed.

Thanks,
Vikash

  reply	other threads:[~2018-08-06  8:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04 19:06 [PATCH v3 0/4] Venus updates - PIL Vikash Garodia
2018-07-04 19:06 ` [PATCH v3 1/4] venus: firmware: add routine to reset ARM9 Vikash Garodia
2018-07-25  9:35   ` Stanimir Varbanov
2018-07-25 11:14   ` Stanimir Varbanov
2018-07-04 19:06 ` [PATCH v3 2/4] venus: firmware: move load firmware in a separate function Vikash Garodia
2018-07-25  9:35   ` Stanimir Varbanov
2018-08-06  8:24     ` Vikash Garodia
2018-08-06 13:38     ` Vikash Garodia
2018-07-04 19:06 ` [PATCH v3 3/4] venus: firmware: add no TZ boot and shutdown routine Vikash Garodia
2018-07-25  9:36   ` Stanimir Varbanov
2018-08-06  8:18     ` Vikash Garodia [this message]
2018-07-04 19:06 ` [PATCH v3 4/4] venus: firmware: register separate driver for firmware device Vikash Garodia
2018-07-05 23:36   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e482a9af27288c9e8a8ffb5c1de8a209@codeaurora.org \
    --to=vgarodia@codeaurora.org \
    --cc=acourbot@chromium.org \
    --cc=andy.gross@linaro.org \
    --cc=arnd@arndb.de \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media-owner@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=stanimir.varbanov@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).