From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5801DC4BA13 for ; Wed, 26 Feb 2020 15:42:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 30EA824670 for ; Wed, 26 Feb 2020 15:42:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=walle.cc header.i=@walle.cc header.b="Rw6O4cXA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728260AbgBZPmL (ORCPT ); Wed, 26 Feb 2020 10:42:11 -0500 Received: from ssl.serverraum.org ([176.9.125.105]:37419 "EHLO ssl.serverraum.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727763AbgBZPmK (ORCPT ); Wed, 26 Feb 2020 10:42:10 -0500 Received: from ssl.serverraum.org (web.serverraum.org [172.16.0.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ssl.serverraum.org (Postfix) with ESMTPSA id 00FA222F99; Wed, 26 Feb 2020 16:42:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2016061301; t=1582731726; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OybAC1ie3ULLOgfyed6GVmBGKTLvuJmNw8c9juOBYDc=; b=Rw6O4cXAi1oD1WapLdBFR3Pi64r6hDmgb5fE678jG7yk2FS49u3p/ME/MERVE4hgqqVKZ7 Q4PyevRoNtLJJiP8SamwzQVw7nK1cOo20vWjkL/ixZqrIFSzKDDlPgtJz9+FSoT9ljxfZJ dPcneue9tDlgdJl43mgt/vnhStzQ6s0= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 26 Feb 2020 16:42:05 +0100 From: Michael Walle To: "Z.q. Hou" Cc: Shawn Guo , Xiaowei Bao , bhelgaas@google.com, devicetree@vger.kernel.org, Leo Li , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, "M.h. Lian" , Mingkai Hu , robh+dt@kernel.org, Roy Zang Subject: Re: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller DT nodes In-Reply-To: References: <20190902034319.14026-2-xiaowei.bao@nxp.com> <20200224081105.13878-1-michael@walle.cc> <20200224084307.GD27688@dragon> Message-ID: X-Sender: michael@walle.cc User-Agent: Roundcube Webmail/1.3.10 X-Spamd-Bar: + X-Rspamd-Server: web X-Rspamd-Queue-Id: 00FA222F99 X-Spamd-Result: default: False [1.40 / 15.00]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TAGGED_RCPT(0.00)[dt]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[]; RCPT_COUNT_TWELVE(0.00)[16]; NEURAL_HAM(-0.00)[-0.401]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; SUSPICIOUS_RECIPS(1.50)[] Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Am 2020-02-24 10:22, schrieb Z.q. Hou: > Hi Michael and Shawn, > > I'll update the patch with iommu-map property. friendly ping :) -michael > > Thanks, > Zhiqiang > >> -----Original Message----- >> From: Michael Walle >> Sent: 2020年2月24日 16:54 >> To: Shawn Guo >> Cc: Xiaowei Bao ; Z.q. Hou >> ; bhelgaas@google.com; >> devicetree@vger.kernel.org; Leo Li ; >> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; >> linux-pci@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; >> lorenzo.pieralisi@arm.com; mark.rutland@arm.com; M.h. Lian >> ; Mingkai Hu ; >> robh+dt@kernel.org; Roy Zang >> Subject: Re: [PATCH v6 2/3] arm64: dts: ls1028a: Add PCIe controller >> DT >> nodes >> >> Hi Shawn, all, >> >> Am 2020-02-24 09:43, schrieb Shawn Guo: >> > On Mon, Feb 24, 2020 at 09:11:05AM +0100, Michael Walle wrote: >> >> Hi Xiaowei, Hi Shawn, >> >> >> >> > LS1028a implements 2 PCIe 3.0 controllers. >> >> >> >> Patch 1/3 and 3/3 are in Linus' tree but nobody seems to care about >> >> this patch anymore :( >> >> >> >> This doesn't work well with the IOMMU, because the iommu-map property >> >> is missing. The bootloader needs the &smmu phandle to fixup the >> >> entry. >> >> See >> >> below. >> >> >> >> Shawn, will you add this patch to your tree once its fixed, >> >> considering it just adds the device tree node for the LS1028A? >> > >> > The patch/thread is a bit aged. You may want to send an updated patch >> > for discussion. >> >> So should I just pick up the patch add my two fixes and send it again? >> What about >> the Signed-off-by tags? Leave them? Replace them? Add mine? >> >> -michael