From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42134C61DA4 for ; Wed, 22 Feb 2023 09:13:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231626AbjBVJNZ (ORCPT ); Wed, 22 Feb 2023 04:13:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59758 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231425AbjBVJNY (ORCPT ); Wed, 22 Feb 2023 04:13:24 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F7421B56B for ; Wed, 22 Feb 2023 01:13:23 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id j2so6808881wrh.9 for ; Wed, 22 Feb 2023 01:13:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zkY3+fA5exA5Ft5hxJp+6msoshzayibJtkPbdEoBQjA=; b=iX1FgI4n78XMb3xWIvCi6aaiDmyMYym3I/GjFQMirsg6gjzLdzXb0gScQs9JQb7LXj ZSzMvaSkGIBawDHrdVHCUg/e9P79wolm2spyoNWR8kFDawL4RkOVJzIHEEX/WFSWdf/M eKEZ/zN+U2JIv+FAjLhVJYN6DtguRSH0DhEwoOk8ZarsZWBjTXacFHggHFNsuDekx8JS xbHflz5Vh0obbQZNAyCUM1zzVB8rajon/nqu5nuK81LMh8kI9OMjoyIhHuyfhFjoVGgq FaDN+KCKCw78nDJFR+L6guVXQxltuIjAUKA4O3oO7z9LK1h/nrVk9b2GVaWJ0U0FBIHJ Bggg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zkY3+fA5exA5Ft5hxJp+6msoshzayibJtkPbdEoBQjA=; b=arHl1Zg9ts7Ct9ImA7y8JP1O6Mb8WJh95eTMR8h5c/5bGm39wyK2NPAJV0leeQsQJx EUSW432ir3C81qvlPiWzJDIUypevrLia5zyVle32NNiLFZ2qgDEOdyxi4nI7lb/72nF7 L/aA3zWIhbVxKPUrk7tmwtzcRCBcwh2/26aGON//iwGpdOx/h24BOnK3UQTAV1oyL95r 7XJ68fQXindRXdfppdchWn4zsW3XMN557SdaSWVay6jNulpgBrRQtWeUxLDFRs7Al/p+ D9M52DyYxlioEc7VfTXKa5zp/JrEM3884ocpFG8tIbc5G3rp0rxol3n0OGna9tE8sqBL VAlQ== X-Gm-Message-State: AO0yUKWG3D3+h/aXG+e2fTXBD6aHefXUnkTZecIbG0o3vHt1ttn2oTsF MJQmFQvZOecAGr2hdHA2IkFWBg== X-Google-Smtp-Source: AK7set9NdN0jgccs0XCvI84qLhB/QtaTW7Q1bVfwm/0xYU+1PLcj/iDaoh0n6AnhTu7COH1UYeqHIw== X-Received: by 2002:adf:f70b:0:b0:2c6:67c9:860a with SMTP id r11-20020adff70b000000b002c667c9860amr7122152wrp.44.1677057201532; Wed, 22 Feb 2023 01:13:21 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id x4-20020adfdd84000000b002c556a4f1casm6329920wrl.42.2023.02.22.01.13.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Feb 2023 01:13:21 -0800 (PST) Message-ID: Date: Wed, 22 Feb 2023 10:13:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 09/19] dt-bindings: clock: Add StarFive JH7110 system clock and reset generator Content-Language: en-US To: Hal Feng , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org Cc: Stephen Boyd , Michael Turquette , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Palmer Dabbelt , Paul Walmsley , Albert Ou , Ben Dooks , Daniel Lezcano , Thomas Gleixner , Marc Zyngier , Emil Renner Berthing , linux-kernel@vger.kernel.org References: <20230221024645.127922-1-hal.feng@starfivetech.com> <20230221024645.127922-10-hal.feng@starfivetech.com> From: Krzysztof Kozlowski In-Reply-To: <20230221024645.127922-10-hal.feng@starfivetech.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/02/2023 03:46, Hal Feng wrote: > From: Emil Renner Berthing > > Add bindings for the system clock and reset generator (SYSCRG) on the > JH7110 RISC-V SoC by StarFive Ltd. > > Reviewed-by: Rob Herring > Signed-off-by: Emil Renner Berthing > Signed-off-by: Hal Feng I don't know what is happening here as neither this nor other patchset explains anything. Please stop writing what you do in the patches, but explain why. What is easy to get. (...) > + > +#define JH7110_SYSCLK_PLL0_OUT 190 > +#define JH7110_SYSCLK_PLL1_OUT 191 > +#define JH7110_SYSCLK_PLL2_OUT 192 NAK. Do not add incorrect bindings just to remove it THE SAME TIME. Best regards, Krzysztof