Re: [PATCH 5/7] media: nxp: add DesignWare MIPI CSI2 controller driver

Krzysztof Kozlowski
2025-07-02T06:35:52Z

On 02/07/2025 00:06, Frank Li wrote:
> +
> +static const struct of_device_id dwc_csi_device_of_match[] = {
> + { .compatible = "snps,dw-mipi-csi2-v150" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, dwc_csi_device_of_match);
> +
> +static struct platform_driver dwc_csi_device_driver = {
> + .driver = {
> + .owner = THIS_MODULE,

That's 12 or 15 year old downstream code. Drop.

> + .name = "dwc-mipi-csi2",
> + .of_match_table = dwc_csi_device_of_match,
> + .pm = &dwc_csi_device_pm_ops,
> + },
> + .probe = dwc_csi_device_probe,
> + .remove = dwc_csi_device_remove,
> +};
> +
> +module_platform_driver(dwc_csi_device_driver);
> +
> +MODULE_DESCRIPTION("DesignWare Core MIPI CSI2 driver");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform: dwc-mipi-csi2");

No, drop.

> +MODULE_AUTHOR("NXP Semiconductor, Inc.");
>

Best regards,
Krzysztof