Re: [PATCH 1/7] dt-bindings: media: add DW MIPI CSI-2 Host support

Krzysztof Kozlowski
2025-07-02T06:38:37Z

On 02/07/2025 00:06, Frank Li wrote:
> From: Eugen Hristev <eugen.hristev@linaro.org>

Linaro?

>
> Add bindings for Synopsys DesignWare MIPI CSI-2 host, which used at i.MX93
> and i.MX95 platform.
>
> Signed-off-by: Luis Oliveira <lolivei@synopsys.com>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>

Microchip?

Sorry, these two must match.

> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> This is continue previous thread
> https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221216143717.1002015-2-eugen.hristev@microchip.com/#3023663
>
> change in v1 (compared to previous post)
> - add reg-names
> - remove clk surfix
> - add imx93,dw-csi compatible string
> - add dphys subnode name
> - use compatible string snps,dw-mipi-csi2-v150 to avoid use general fallback
> compatible string.
> ---
> .../bindings/media/snps,dw-mipi-csi2-v150.yaml | 161 +++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 162 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/snps,dw-mipi-csi2-v150.yaml b/Documentation/devicetree/bindings/media/snps,dw-mipi-csi2-v150.yaml
> new file mode 100644
> index 0000000000000..2a93bd72498f8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/snps,dw-mipi-csi2-v150.yaml
> @@ -0,0 +1,161 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/snps,dw-mipi-csi2-v150.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Synopsys DesignWare CSI-2 Host controller (csi2host)
> +
> +maintainers:
> + - Frank Li <Frank.Li@nxp.com>
> + - Eugen Hristev <eugen.hristev@microchip.com>

For sure does not work. Also, needs some sort of Ack from Eugen now.

> +
> +description:
> + CSI2HOST is used to receive image coming from an MIPI CSI-2 compatible
> + camera. It will convert the incoming CSI-2 stream into a dedicated
> + interface called the Synopsys IDI (Image Data Interface).
> + This interface is a 32-bit SoC internal only, and can be assimilated
> + with a CSI-2 interface.
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - fsl,imx93-mipi-csi2
> + - const: snps,dw-mipi-csi2-v150
> + - const: snps,dw-mipi-csi2-v150

Same comment as before, you need SoC compatible. Drop the last one. You
cannot use DW in a DW soc, can you?

> +
> + reg:
> + items:
> + - description: MIPI CSI-2 core register
> +
> + reg-names:
> + items:
> + - const: core
> +
> + clocks:
> + maxItems: 2
> +
> + clock-names:
> + items:
> + - const: per
> + - const: pixel
> +
> + phys:
> + maxItems: 1
> + description: MIPI D-PHY
> +
> + phy-names:
> + items:
> + - const: rx
> +
> + resets:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> + description:
> + Input port node, single endpoint describing the input port.
> +
> + properties:
> + endpoint:
> + $ref: video-interfaces.yaml#
> + unevaluatedProperties: false
> + description: Endpoint connected to input device
> +
> + properties:
> + bus-type:
> + const: 4
> +
> + data-lanes:
> + minItems: 1
> + maxItems: 4
> + items:
> + maximum: 4
> +
> + clock-lanes:
> + maxItems: 1
> +
> + remote-endpoint: true
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + unevaluatedProperties: false
> + description:
> + Output port node, single endpoint describing the output port.
> +
> + properties:
> + endpoint:
> + unevaluatedProperties: false
> + $ref: video-interfaces.yaml#
> + description: Endpoint connected to output device
> +
> + properties:
> + bus-type:
> + const: 4
> +
> + remote-endpoint: true
> +
> + required:
> + - port@0
> + - port@1
> +
> +additionalProperties: false

This goes after required: block.

> +
>

Best regards,
Krzysztof