From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52B26230BDB for ; Tue, 25 Aug 2026 03:25:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787628323; cv=none; b=XQJQpyLpzHJ62HBOsUKNfZOxWZJgwWpX7+RatWzDFLlbZ31ORkH/mzlJw/YY2YFLeBYgNUEMGSIJOXTpxmaGdTrOA94Y4BmoBTDoeyXHryLb0lrRRSuE7lVyK4Rba9tVm5VceCRat/GN+HaEsxOyLBGzqjL9raM8z4Q/UbDI2c0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787628323; c=relaxed/simple; bh=5sC65HxqHy2q6gQj1Q4zZfKf/D1v64cBmlCVI0LSeQw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=joC8KpYwh4Fx14y4ows+XEJlIy7OTYgq720pTifCFChkMzBQt4XTAQtIJhd/M27IS4sg49PDJYoPbz7h6ccVUAC5QFyopEVMd3tH0b2jUK/CG7U+A71Qv2wvKAk5XO71IiEfqwZGC6phM5efFvd4t0YZtf3cVMYszCUvfcPtPYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V6OD9ZtO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YYUd21C4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V6OD9ZtO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YYUd21C4" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67P2Qxd6624777 for ; Tue, 25 Aug 2026 03:25:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7MYeqv+ALj6Cfd1bCbQ++2ZAswFiG0g5XGZYlJ4WVnU=; b=V6OD9ZtOhTIn3JKB kNq+UJQYved8AOGPa85qisU9WJIlRsXI0h9cYCGJ2yQueinunnZM29aRgbxOwRNu wpwFOjJsQK5Vbg43pX2t8lu+31aD3Er4XQVcxkblA65XTfzROIO7OO5GG/eJIca4 56714EtHPU9+biAhlKVgxcV2n3k56XluKCUs09AXJr731Z7K+fJXkmOnMhJjxsvH KOIdnnceJyw69XXVdeTS4sa1Ml7EcrTF57ZECMMNNoxGPSgVkbcv32uG8TN+Cgg0 khPeWrcZcYMsdBd85jBVsHH5nQAkjoEzToDNovHa0VVfk4iw8PNtsl+oT8TFccfJ os14Jw== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g8pkdjyad-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 25 Aug 2026 03:25:20 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-381250979d5so4521537a91.0 for ; Mon, 24 Aug 2026 20:25:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787628320; x=1788233120; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=7MYeqv+ALj6Cfd1bCbQ++2ZAswFiG0g5XGZYlJ4WVnU=; b=YYUd21C4xv3RyMwPdeWC9pYF1yyMOlpi5JeFx/vx1b1pRTv6tXv5D5/IzR74tP1WzE 7g6hNj9SCzrR4cmhSKEL2NqIkBwf5rng+jPK75WahRcdnLfzl7RGM0Pi2xZruRFXW1Gi DqmYcNddpBLlzGgCXZCjJX0CbH/N/aPMtR6NmQFolAHr7T5+QjzxBmyV9GKm/4vFa7cG jTqOHNMsc0vqp/oCP5Tn1lOAImq7iCPRZi4cguXG5RdNQizIE/4wYLdahf6G3NZwOz0t OEv1XEeu9B/RDKwaTk0ZqsaWkyndM/cv7vCbChGmCf/052SiviVKjaFJgcK0CNbnwW0D Hhzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787628320; x=1788233120; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7MYeqv+ALj6Cfd1bCbQ++2ZAswFiG0g5XGZYlJ4WVnU=; b=bJveIZ3TEzeuiUhny46ej1XCztxgYZ2KffQ8gLviVLKNzfnAuELdhAluocbyRsDMOr JFj91rdMFb8WWbgrVD1V6h9iPeQ7+JbRfbWfCjmv5V0fWwnTnGSfChlAaezSaRwqqMmm +bYlZQbSuzxTUfUk+hufCzZyBpx4kPXXDholhSfuzmCeejT/hgtbAhG9hgjXFE9pOQVW vH1viZv5CblIXwsoAMJEhVn+6zKt75pXVTH0aQmjJaqd59dMinRzxKBezGUD+FEcHlH/ 7whqFApCcoB0+3rXIbyzNGmPVDJ3fr2OX6tSN/TXzqCb4O75ghyK5bd55wFnLxhCTwI/ Ua7A== X-Forwarded-Encrypted: i=1; AHgh+Rp/mcY/Fu2jTCwNXq6ezgqTsDm3V/zz5k9cjybmirzLaG2LjGndQs4He7wlq75aqPWx/0DDxw+FIaCg@vger.kernel.org X-Gm-Message-State: AFuF++mqhiSODcz521C8TkJb/47FCHHpir4FL7uXOd7gwh0g+9t8mLgB fzFd46J741y5w8VcJBbkjOL2FqTATN/2fgpLrR45evn2IbqH45BlgpppoFwdv5Pe5/K2F3FL1e8 8oCWhxgXCFDD4nmKqRqV8zLx2W7ClpHgH0Wm/B4yvKhtVzj/Fv8J7auN0z4ya8aYI X-Gm-Gg: AR+sD13ViVR27Wcl0mo682QYdyOqgt6fiwsPQSKbnk6JUQvROFJydsR1oqx9YRLu8uR WUvGkSX+Dkk5sveaFriRmS40zVA6HchrkJPVW6+t8Ou/V+vlJlfM1xmRU7d37YDLBwtvvI4zk9a b/QCc9gZVUhZfDIfTrxfCtGMZBFjddtmhgIdIxteIxKkYp4MHRTCRiyAnyzdjakjFDlkNPQ8fhJ b0gIwmKBU+kSpY0+D+OGtDkY7xJSOJORjmEpF0YGZD2ZEf+FEYoK3fg2NDZ2Xdoa7Hh5mbuXJLf Kh/eIioPRxoHtBx/FlrPmknyJshDxZ9ocFjpBOUrQtgLclFAizXBpXE2dlHK1WTPlGGq6PUz7xa p79k2TiDSHoDfsCmRkLdX7Q5ad0SZw9Goh8PAsYEOp3w4cFmFDU/tWymBfhqtD4hfWC3k X-Received: by 2002:a17:90b:17c4:b0:392:6638:2e6a with SMTP id 98e67ed59e1d1-39646519363mr6263294a91.13.1787628320011; Mon, 24 Aug 2026 20:25:20 -0700 (PDT) X-Received: by 2002:a17:90b:17c4:b0:392:6638:2e6a with SMTP id 98e67ed59e1d1-39646519363mr6263184a91.13.1787628319525; Mon, 24 Aug 2026 20:25:19 -0700 (PDT) Received: from [10.133.33.69] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39645bbf440sm1944627a91.14.2026.08.24.20.25.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Aug 2026 20:25:19 -0700 (PDT) Message-ID: Date: Tue, 25 Aug 2026 11:25:14 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/2] input: misc: Add Qualcomm SPMI PMIC haptics driver To: David Heidelberg , linux-arm-msm@vger.kernel.org, Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lee Jones , Stephen Boyd , Bjorn Andersson , Konrad Dybcio Cc: David Collins , Subbaraman Narayanamurthy , Kamal Wadhwa , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260806-qcom-spmi-haptics-v6-0-19fcecd5204f@oss.qualcomm.com> <20260806-qcom-spmi-haptics-v6-2-19fcecd5204f@oss.qualcomm.com> <214bbcf7-38ba-458b-81ba-d7f3a42cb73d@ixit.cz> Content-Language: en-US From: Fenglin Wu In-Reply-To: <214bbcf7-38ba-458b-81ba-d7f3a42cb73d@ixit.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwODI1MDAyNSBTYWx0ZWRfXybvgv/wNpbTk ZtvDerN2gMhYJw0dMvFBSJebXYKkfQN7B3VzuQvw+/y+fARn3cGRdIMhdPlzggDh59MBIPxmKAT BlY8AMvn1VnXXcWUUPbMSN9Bj/bqK04= X-Proofpoint-ORIG-GUID: SZ3NK8tVFRJ9MPpuRiOQuTAWC6IPzSo3 X-Proofpoint-GUID: SZ3NK8tVFRJ9MPpuRiOQuTAWC6IPzSo3 X-Authority-Analysis: v=2.4 cv=Kq19H2WN c=1 sm=1 tr=0 ts=6a8d0b20 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=ovy1QOkU2M_fSUD7NcMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI1MDAyNSBTYWx0ZWRfXwouWpE1MmNq2 ddZZZR6lP146tMSPyhMdUGa2u3w8P70Pa2yDNNrJUiX52cQei2vc15Bj2bw3ie0hYuBs/6hOkkS PKtzw2MbCgaGEv/Swyx/RDJFCXZx/MQmahdhxIxEQcgPASanlqes3EesZNQqmHP1crfx530FlGu DryCkkcB90yarfudDRf7uJP/hbmv6d38Rl3+fdJ5sHok0qOQIN3X18/YBuMY1twwgHNueCQsi03 imypaHqQaP+n+9RjovLAamVxtKYc5ihhVzyDuw22BlUZguSTVkbYD2kSEC4PjW+LVGFg6y0Ff8T 4uAe3G7vnxTSMIf8C+CHWgVbBj+lwtfHxgxuL8KyJK9+/LLI6SZD40M9Y4uszzXIolCmPFwNJZ5 fJNuf313CXNl+eeLcDKla64OuPMxGS9fCsX+54lvNw3TTku91HGQ7FfGpJia0FHkQgL+2ejJ4xn 1iFhxrdCX9uXODCRRpA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-25_01,2026-08-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 bulkscore=0 clxscore=1015 adultscore=0 spamscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608250025 On 8/17/2026 8:08 PM, David Heidelberg wrote: >> +static const struct dev_pm_ops qcom_haptics_pm_ops = { >> + SYSTEM_SLEEP_PM_OPS(qcom_haptics_suspend, qcom_haptics_resume) >> + RUNTIME_PM_OPS(qcom_haptics_runtime_suspend, qcom_haptics_runtime_resume, >> + NULL) >> +}; >> + >> +static const struct of_device_id qcom_haptics_of_match[] = { >> + { .compatible = "qcom,spmi-haptics" }, > I assume this won't work for the Snapdragon 845 (and related arch) SPMI haptics. > > Should be the assigned compatible (and relevant data) wired to the PMIH0108 > compatible only? > At the moment, this only works for haptics inside pmih0108 PMIC, which contains the newest haptics module among Qcom PMICs. That said, with some code changes, it should also support the older haptics modules in pm8350b, pm8550b, and pm8750b, since those PMICs all support DIRECT_PLAY and FIFO play modes. I expect this change to be applied first, and then I or someone else can work on adding support for the older haptics modules in the same driver. It might be very difficult to support the haptics module inside pmi8998 which is used on SDM845 platform, as it has very different control logic than the newer ones. Thanks Fenglin > Thanks > David > > P.S. I'll be upstreaming SPMI haptics in approximatelly 2 months for the older > chips, please feel free to +Cc me on followups! 🙂 > >> + { } >> +}; >> +MODULE_DEVICE_TABLE(of, qcom_haptics_of_match); >> + >> +static struct platform_driver qcom_haptics_driver = {