From: Fabio Estevam <festevam@denx.de>
To: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Cc: Fabio Estevam <festevam@gmail.com>,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, martink@posteo.de,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v2] media: dt-bindings: hynix,hi846: Document orientation and rotation
Date: Thu, 28 Sep 2023 12:14:58 -0300 [thread overview]
Message-ID: <e5002417d8d3ed29a0289d3895213f64@denx.de> (raw)
In-Reply-To: <avoixz5pqixr366cqks672akniv7h7ewix4edoyikg23dv24fd@bquxelr53t7t>
Hi Jacopo,
On 28/09/2023 11:57, Jacopo Mondi wrote:
> Counterproof: It's very easy to break validation of, in example,
> ov5640
>
> --- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml
> @@ -109,6 +109,7 @@ examples:
> powerdown-gpios = <&gpio1 19 GPIO_ACTIVE_HIGH>;
> reset-gpios = <&gpio1 20 GPIO_ACTIVE_LOW>;
> rotation = <180>;
> + orientation = <0>;
>
> port {
> /* MIPI CSI-2 bus endpoint */
>
> $ make ARCH=arm64 dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml
> DTC_CHK
> Documentation/devicetree/bindings/media/i2c/ovti,ov5640.example.dtb
> 'orientation' does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id:
> http://devicetree.org/schemas/media/i2c/ovti,ov5640.yaml#
Should we use unevaluatedProperties: false instead?
--- a/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5640.yaml
@@ -85,7 +85,7 @@ required:
- DOVDD-supply
- port
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
@@ -109,6 +109,7 @@ examples:
powerdown-gpios = <&gpio1 19 GPIO_ACTIVE_HIGH>;
reset-gpios = <&gpio1 20 GPIO_ACTIVE_LOW>;
rotation = <180>;
+ orientation = <0>;
port {
/* MIPI CSI-2 bus endpoint */
next prev parent reply other threads:[~2023-09-28 15:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 12:14 [PATCH v2] media: dt-bindings: hynix,hi846: Document orientation and rotation Fabio Estevam
2023-09-28 14:57 ` Jacopo Mondi
2023-09-28 15:14 ` Fabio Estevam [this message]
2023-09-28 15:54 ` Rob Herring
2023-09-29 6:30 ` Jacopo Mondi
2023-09-29 12:04 ` Fabio Estevam
2023-09-29 14:36 ` Jacopo Mondi
2023-09-29 14:47 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5002417d8d3ed29a0289d3895213f64@denx.de \
--to=festevam@denx.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=martink@posteo.de \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).