* [PATCH v4 0/4] arm64: renesas: enable H3ULCB board peripherals
@ 2016-09-02 12:04 Vladimir Barinov
2016-09-02 12:05 ` [PATCH v4 1/4] arm64: dts: h3ulcb: enable GPIO leds Vladimir Barinov
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Vladimir Barinov @ 2016-09-02 12:04 UTC (permalink / raw)
To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland
Cc: devicetree, linux-renesas-soc, Vladimir Barinov
Hello,
This adds the folowing:
- R8A7795 SoC based H3ULCB board peripherals
Vladimir Barinov (4):
[1/4] arm64: dts: h3ulcb: enable GPIO leds
[2/4] arm64: dts: h3ulcb: enable GPIO keys
[3/4] arm64: dts: h3ulcb: enable SDHI0
[4/4] arm64: dts: h3ulcb: Sound SSI support
---
This patchset is against the 'kernel/git/horms/renesas.git' repo.
arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 189 +++++++++++++++++++++++++
1 file changed, 189 insertions(+)
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v4 1/4] arm64: dts: h3ulcb: enable GPIO leds 2016-09-02 12:04 [PATCH v4 0/4] arm64: renesas: enable H3ULCB board peripherals Vladimir Barinov @ 2016-09-02 12:05 ` Vladimir Barinov [not found] ` <1472817909-11901-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> [not found] ` <1472817881-11860-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> ` (2 subsequent siblings) 3 siblings, 1 reply; 9+ messages in thread From: Vladimir Barinov @ 2016-09-02 12:05 UTC (permalink / raw) To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland Cc: devicetree, linux-renesas-soc, Vladimir Barinov This supports GPIO leds on H3ULCB board Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Changes in version 3: - initially added Changes in version 4: - removed led4 in favor of gpio-keys - added label arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts index fb694b8..3329f78 100644 --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts @@ -31,6 +31,19 @@ /* first 128MB is reserved for secure area. */ reg = <0x0 0x48000000 0x0 0x38000000>; }; + + leds { + compatible = "gpio-leds"; + + led5 { + label = "LED5"; + gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>; + }; + led6 { + label = "LED6"; + gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>; + }; + }; }; &extal_clk { -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
[parent not found: <1472817909-11901-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>]
* Re: [PATCH v4 1/4] arm64: dts: h3ulcb: enable GPIO leds [not found] ` <1472817909-11901-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> @ 2016-09-02 16:28 ` Sergei Shtylyov 0 siblings, 0 replies; 9+ messages in thread From: Sergei Shtylyov @ 2016-09-02 16:28 UTC (permalink / raw) To: Vladimir Barinov, Simon Horman, Magnus Damm, Rob Herring, Mark Rutland Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA Hello. On 09/02/2016 03:05 PM, Vladimir Barinov wrote: > This supports GPIO leds on H3ULCB board > > Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> > Reviewed-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org> > --- > Changes in version 3: > - initially added > Changes in version 4: > - removed led4 in favor of gpio-keys > - added label > > arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > index fb694b8..3329f78 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > @@ -31,6 +31,19 @@ > /* first 128MB is reserved for secure area. */ > reg = <0x0 0x48000000 0x0 0x38000000>; > }; > + > + leds { > + compatible = "gpio-leds"; > + > + led5 { > + label = "LED5"; Do we need the "label" prop? Based on the feedback to my former LED patches, no? > + gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>; > + }; > + led6 { > + label = "LED6"; > + gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>; > + }; > + }; > }; > > &extal_clk { MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <1472817881-11860-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>]
* [PATCH v4 2/4] arm64: dts: h3ulcb: enable GPIO keys [not found] ` <1472817881-11860-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> @ 2016-09-02 12:05 ` Vladimir Barinov 0 siblings, 0 replies; 9+ messages in thread From: Vladimir Barinov @ 2016-09-02 12:05 UTC (permalink / raw) To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA, Vladimir Barinov This supports GPIO keys on H3ULCB board Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> --- Changes in version 4: - initially added arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 14 +++++++++++++ 1 file changed, 14 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts index fb694b8..3329f78 100644 --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts @@ -12,6 +12,7 @@ /dts-v1/; #include "r8a7795.dtsi" #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> / { model = "Renesas H3ULCB board based on r8a7795"; @@ -31,6 +31,18 @@ /* first 128MB is reserved for secure area. */ reg = <0x0 0x48000000 0x0 0x38000000>; }; + + keyboard { + compatible = "gpio-keys"; + + key-1 { + linux,code = <KEY_1>; + label = "SW3"; + wakeup-source; + debounce-interval = <20>; + gpios = <&gpio6 11 GPIO_ACTIVE_LOW>; + }; + }; leds { compatible = "gpio-leds"; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v4 3/4] arm64: dts: h3ulcb: enable SDHI0 2016-09-02 12:04 [PATCH v4 0/4] arm64: renesas: enable H3ULCB board peripherals Vladimir Barinov 2016-09-02 12:05 ` [PATCH v4 1/4] arm64: dts: h3ulcb: enable GPIO leds Vladimir Barinov [not found] ` <1472817881-11860-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> @ 2016-09-02 12:05 ` Vladimir Barinov 2016-09-02 12:05 ` [PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support Vladimir Barinov 3 siblings, 0 replies; 9+ messages in thread From: Vladimir Barinov @ 2016-09-02 12:05 UTC (permalink / raw) To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland Cc: devicetree, linux-renesas-soc, Vladimir Barinov This supports SDHI0 on H3ULCB board SD card slot Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Changes in version 3: - initially added Changes in version 4: - added sd-uhs-sdr50 --- arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 49 ++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts index 6842597..babe41c 100644 --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts @@ -44,6 +44,30 @@ gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>; }; }; + + vcc_sdhi0: regulator-vcc-sdhi0 { + compatible = "regulator-fixed"; + + regulator-name = "SDHI0 Vcc"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + + gpio = <&gpio5 2 GPIO_ACTIVE_HIGH>; + enable-active-high; + }; + + vccq_sdhi0: regulator-vccq-sdhi0 { + compatible = "regulator-gpio"; + + regulator-name = "SDHI0 VccQ"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <3300000>; + + gpios = <&gpio5 1 GPIO_ACTIVE_HIGH>; + gpios-states = <1>; + states = <3300000 1 + 1800000 0>; + }; }; &extal_clk { @@ -78,6 +102,18 @@ function = "avb"; }; + sdhi0_pins_3v3: sd0_3v3 { + groups = "sdhi0_data4", "sdhi0_ctrl"; + function = "sdhi0"; + power-source = <3300>; + }; + + sdhi0_pins_1v8: sd0_1v8 { + groups = "sdhi0_data4", "sdhi0_ctrl"; + function = "sdhi0"; + power-source = <1800>; + }; + usb1_pins: usb1 { groups = "usb1"; function = "usb1"; @@ -108,6 +144,19 @@ status = "okay"; }; +&sdhi0 { + pinctrl-0 = <&sdhi0_pins_3v3>; + pinctrl-1 = <&sdhi0_pins_1v8>; + pinctrl-names = "default", "state_uhs"; + + vmmc-supply = <&vcc_sdhi0>; + vqmmc-supply = <&vccq_sdhi0>; + cd-gpios = <&gpio3 12 GPIO_ACTIVE_LOW>; + bus-width = <4>; + sd-uhs-sdr50; + status = "okay"; +}; + &wdt0 { timeout-sec = <60>; status = "okay"; -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support 2016-09-02 12:04 [PATCH v4 0/4] arm64: renesas: enable H3ULCB board peripherals Vladimir Barinov ` (2 preceding siblings ...) 2016-09-02 12:05 ` [PATCH v4 3/4] arm64: dts: h3ulcb: enable SDHI0 Vladimir Barinov @ 2016-09-02 12:05 ` Vladimir Barinov [not found] ` <1472817933-12018-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 3 siblings, 1 reply; 9+ messages in thread From: Vladimir Barinov @ 2016-09-02 12:05 UTC (permalink / raw) To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland Cc: devicetree, linux-renesas-soc, Vladimir Barinov This supports SSI sound for H3ULCB board. SSI DMA mode used. CS2000 used as AUDIO_CLK_B. Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- Changes in version 3: - initially added Changes in version 4: - added comment for audio_clkout arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 115 +++++++++++++++++++++++++ 1 file changed, 115 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts index bbd7928..a254231 100644 --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts @@ -45,6 +45,12 @@ }; }; + x12_clk: x12_clk { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <24576000>; + }; + vcc_sdhi0: regulator-vcc-sdhi0 { compatible = "regulator-fixed"; @@ -68,6 +74,32 @@ states = <3300000 1 1800000 0>; }; + + audio_clkout: audio_clkout { + /* + * This is same as <&rcar_sound 0> + * but needed to avoid cs2000/rcar_sound probe dead-lock + */ + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <11289600>; + }; + + rsnd_ak4613: sound { + compatible = "simple-audio-card"; + + simple-audio-card,format = "left_j"; + simple-audio-card,bitclock-master = <&sndcpu>; + simple-audio-card,frame-master = <&sndcpu>; + + sndcpu: simple-audio-card,cpu { + sound-dai = <&rcar_sound>; + }; + + sndcodec: simple-audio-card,codec { + sound-dai = <&ak4613>; + }; + }; }; &extal_clk { @@ -113,6 +141,17 @@ power-source = <1800>; }; + sound_pins: sound { + groups = "ssi01239_ctrl", "ssi0_data", "ssi1_data_a"; + function = "ssi"; + }; + + sound_clk_pins: sound_clk { + groups = "audio_clk_a_a", "audio_clk_b_a", "audio_clk_c_a", + "audio_clkout_a", "audio_clkout3_a"; + function = "audio_clk"; + }; + usb1_pins: usb1 { groups = "usb1"; function = "usb1"; @@ -136,6 +176,73 @@ pinctrl-names = "default"; status = "okay"; + + clock-frequency = <100000>; + + ak4613: codec@10 { + compatible = "asahi-kasei,ak4613"; + #sound-dai-cells = <0>; + reg = <0x10>; + clocks = <&rcar_sound 3>; + + asahi-kasei,in1-single-end; + asahi-kasei,in2-single-end; + asahi-kasei,out1-single-end; + asahi-kasei,out2-single-end; + asahi-kasei,out3-single-end; + asahi-kasei,out4-single-end; + asahi-kasei,out5-single-end; + asahi-kasei,out6-single-end; + }; + + cs2000: clk_multiplier@4f { + #clock-cells = <0>; + compatible = "cirrus,cs2000-cp"; + reg = <0x4f>; + clocks = <&audio_clkout>, <&x12_clk>; + clock-names = "clk_in", "ref_clk"; + + assigned-clocks = <&cs2000>; + assigned-clock-rates = <24576000>; /* 1/1 divide */ + }; +}; + +&rcar_sound { + pinctrl-0 = <&sound_pins &sound_clk_pins>; + pinctrl-names = "default"; + + /* Single DAI */ + #sound-dai-cells = <0>; + + /* audio_clkout0/1/2/3 */ + #clock-cells = <1>; + clock-frequency = <11289600>; + + status = "okay"; + + /* update <audio_clk_b> to <cs2000> */ + clocks = <&cpg CPG_MOD 1005>, + <&cpg CPG_MOD 1006>, <&cpg CPG_MOD 1007>, + <&cpg CPG_MOD 1008>, <&cpg CPG_MOD 1009>, + <&cpg CPG_MOD 1010>, <&cpg CPG_MOD 1011>, + <&cpg CPG_MOD 1012>, <&cpg CPG_MOD 1013>, + <&cpg CPG_MOD 1014>, <&cpg CPG_MOD 1015>, + <&cpg CPG_MOD 1022>, <&cpg CPG_MOD 1023>, + <&cpg CPG_MOD 1024>, <&cpg CPG_MOD 1025>, + <&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>, + <&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>, + <&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>, + <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>, + <&audio_clk_a>, <&cs2000>, + <&audio_clk_c>, + <&cpg CPG_CORE R8A7795_CLK_S0D4>; + + rcar_sound,dai { + dai0 { + playback = <&ssi0 &src0 &dvc0>; + capture = <&ssi1 &src1 &dvc1>; + }; + }; }; &sdhi0 { @@ -150,11 +257,19 @@ status = "okay"; }; +&ssi1 { + shared-pin; +}; + &wdt0 { timeout-sec = <60>; status = "okay"; }; +&audio_clk_a { + clock-frequency = <22579200>; +}; + &avb { pinctrl-0 = <&avb_pins>; pinctrl-names = "default"; -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
[parent not found: <1472817933-12018-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>]
* Re: [PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support [not found] ` <1472817933-12018-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> @ 2016-09-02 12:08 ` Vladimir Barinov 2016-09-02 12:38 ` Sergei Shtylyov 1 sibling, 0 replies; 9+ messages in thread From: Vladimir Barinov @ 2016-09-02 12:08 UTC (permalink / raw) To: Simon Horman, Magnus Damm, Rob Herring, Mark Rutland Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA On 02.09.2016 15:05, Vladimir Barinov wrote: > This supports SSI sound for H3ULCB board. > SSI DMA mode used. CS2000 used as AUDIO_CLK_B. > > Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> > --- > Changes in version 3: > - initially added > Changes in version 4: > - added comment for audio_clkout > > arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 115 +++++++++++++++++++++++++ > 1 file changed, 115 insertions(+) > Sorry for the subject typo. The proper one is v4: [PATCH v4 4/4] arm64: dts: h3ulcb: Sound SSI support -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support [not found] ` <1472817933-12018-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 2016-09-02 12:08 ` Vladimir Barinov @ 2016-09-02 12:38 ` Sergei Shtylyov [not found] ` <159bb1fc-aa36-d30f-5064-b61efa34c663-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> 1 sibling, 1 reply; 9+ messages in thread From: Sergei Shtylyov @ 2016-09-02 12:38 UTC (permalink / raw) To: Vladimir Barinov, Simon Horman, Magnus Damm, Rob Herring, Mark Rutland Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA Hello. On 9/2/2016 3:05 PM, Vladimir Barinov wrote: > This supports SSI sound for H3ULCB board. > SSI DMA mode used. CS2000 used as AUDIO_CLK_B. > > Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> > Acked-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> > --- > Changes in version 3: > - initially added > Changes in version 4: > - added comment for audio_clkout > > arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 115 +++++++++++++++++++++++++ > 1 file changed, 115 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > index bbd7928..a254231 100644 > --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts > @@ -45,6 +45,12 @@ > }; > }; > > + x12_clk: x12_clk { If the crystal name is X12, name the node "x12" too, this way the output clock will be named just "x12". > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <24576000>; > + }; > + > vcc_sdhi0: regulator-vcc-sdhi0 { > compatible = "regulator-fixed"; > [...] > @@ -136,6 +176,73 @@ [...] > + > + cs2000: clk_multiplier@4f { Don't use underscores in the node names, use hyphens instead. > + #clock-cells = <0>; > + compatible = "cirrus,cs2000-cp"; > + reg = <0x4f>; > + clocks = <&audio_clkout>, <&x12_clk>; > + clock-names = "clk_in", "ref_clk"; > + > + assigned-clocks = <&cs2000>; > + assigned-clock-rates = <24576000>; /* 1/1 divide */ > + }; > +}; [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <159bb1fc-aa36-d30f-5064-b61efa34c663-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>]
* Re: [PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support [not found] ` <159bb1fc-aa36-d30f-5064-b61efa34c663-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> @ 2016-09-02 14:33 ` Vladimir Barinov 0 siblings, 0 replies; 9+ messages in thread From: Vladimir Barinov @ 2016-09-02 14:33 UTC (permalink / raw) To: Sergei Shtylyov, Simon Horman, Magnus Damm, Rob Herring, Mark Rutland Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA Hi Sergei, Thank you for the review. Lemme fix it in v5 patchset. Regards, Vladimir On 02.09.2016 15:38, Sergei Shtylyov wrote: > Hello. > > On 9/2/2016 3:05 PM, Vladimir Barinov wrote: > >> This supports SSI sound for H3ULCB board. >> SSI DMA mode used. CS2000 used as AUDIO_CLK_B. >> >> Signed-off-by: Vladimir Barinov <vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org> >> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org> >> --- >> Changes in version 3: >> - initially added >> Changes in version 4: >> - added comment for audio_clkout >> >> arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts | 115 >> +++++++++++++++++++++++++ >> 1 file changed, 115 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >> b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >> index bbd7928..a254231 100644 >> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts >> @@ -45,6 +45,12 @@ >> }; >> }; >> >> + x12_clk: x12_clk { > > If the crystal name is X12, name the node "x12" too, this way the > output clock will be named just "x12". > >> + compatible = "fixed-clock"; >> + #clock-cells = <0>; >> + clock-frequency = <24576000>; >> + }; >> + >> vcc_sdhi0: regulator-vcc-sdhi0 { >> compatible = "regulator-fixed"; >> > [...] >> @@ -136,6 +176,73 @@ > [...] >> + >> + cs2000: clk_multiplier@4f { > > Don't use underscores in the node names, use hyphens instead. > >> + #clock-cells = <0>; >> + compatible = "cirrus,cs2000-cp"; >> + reg = <0x4f>; >> + clocks = <&audio_clkout>, <&x12_clk>; >> + clock-names = "clk_in", "ref_clk"; >> + >> + assigned-clocks = <&cs2000>; >> + assigned-clock-rates = <24576000>; /* 1/1 divide */ >> + }; >> +}; > [...] > > MBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-09-02 16:28 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-02 12:04 [PATCH v4 0/4] arm64: renesas: enable H3ULCB board peripherals Vladimir Barinov
2016-09-02 12:05 ` [PATCH v4 1/4] arm64: dts: h3ulcb: enable GPIO leds Vladimir Barinov
[not found] ` <1472817909-11901-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-09-02 16:28 ` Sergei Shtylyov
[not found] ` <1472817881-11860-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-09-02 12:05 ` [PATCH v4 2/4] arm64: dts: h3ulcb: enable GPIO keys Vladimir Barinov
2016-09-02 12:05 ` [PATCH v4 3/4] arm64: dts: h3ulcb: enable SDHI0 Vladimir Barinov
2016-09-02 12:05 ` [PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support Vladimir Barinov
[not found] ` <1472817933-12018-1-git-send-email-vladimir.barinov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-09-02 12:08 ` Vladimir Barinov
2016-09-02 12:38 ` Sergei Shtylyov
[not found] ` <159bb1fc-aa36-d30f-5064-b61efa34c663-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
2016-09-02 14:33 ` Vladimir Barinov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).