From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 446CBC4332F for ; Wed, 13 Apr 2022 19:40:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237112AbiDMTnG (ORCPT ); Wed, 13 Apr 2022 15:43:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233923AbiDMTnF (ORCPT ); Wed, 13 Apr 2022 15:43:05 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46CAF3F332 for ; Wed, 13 Apr 2022 12:40:42 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id u19so3457631ljd.11 for ; Wed, 13 Apr 2022 12:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=KSvbPWcgC+EYpvQJgWFy6k/bppn4PjhiXHZYOLmzGZQ=; b=DK7W1eF1DVRunhPz52c10Omi5ui/jCBWO3zXXAdXz7MqXfF5mpI+5WnAjjMheHwPqy 4gVXjPksWYf5suZpky6ntZ6YExRxIjvudoMs6GMYc5X2Ot+zQk6IcUx4WG7bBjEHQjuD qLdqLNoOH0vL/eug7Q8pdk6DiyYEWzNAfwRqNYZJ+CXC8oYggOSPoJ7XJGztKDxxqmVj rOrhvNB9dFz62OkS7B9brZQ04qm9OmR7bzs393IIGxCKi49IbRz3uVV384VKpPsaFKRH AMjrRmE6EAVyhQ/yN1wPGfn15z+pxkYErUC5JmJeAcgHASQw09I3wTVOHy/vTqiva9bC 260A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=KSvbPWcgC+EYpvQJgWFy6k/bppn4PjhiXHZYOLmzGZQ=; b=dhV5iAu5hC8fGgkFX0WR1HDOtgWG+UiOacbZEpWUJWpC7vc9SftHbi1j/DSr9W4mZZ E63wHQZqixMLk1Qdc5teaanMof83JDx0ZMKU6IehyEfnIVWxjx3cTyju5+aioYD6AJdK tYFyEuBJg9AG3yh6su3DohC0PCp/6hZQTJOYGDuFi88EHMKB5W8vvz9epVztjAxlEQxl lrfPYE9FDa0G3v2vfeFFZRtGwU4KkAg6lQ4M3MjSNdr7+iakK4GHz2UzjJAEXjpWD3sp ST418obIGFPXjPIWNrqjOW5Ltz21mFtL9/02qZ5qtQiAKefZdnw4tTKl4CEMyG4toaYb XXyQ== X-Gm-Message-State: AOAM531OdxiGF+dDOEKNVkjaFb3PEMm4AehPF/6PiqG+Zcz4f0EzefF1 /ocFwvIPdY9JUmRg5yFiMYwVQA== X-Google-Smtp-Source: ABdhPJw+fve7UmoJNDguXxV9w1RErcG8dtgyNN+2QOCsDgx6W/GK+8oz5oPqQhagCy7aKKYdw9TPrA== X-Received: by 2002:a2e:bd13:0:b0:246:1ff8:6da1 with SMTP id n19-20020a2ebd13000000b002461ff86da1mr27104815ljq.219.1649878840486; Wed, 13 Apr 2022 12:40:40 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id s13-20020ac2464d000000b0046cff822d0fsm406876lfo.225.2022.04.13.12.40.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Apr 2022 12:40:39 -0700 (PDT) Message-ID: Date: Wed, 13 Apr 2022 22:40:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v6 09/18] clk: qcom: krait-cc: drop pr_info and register qsb only if needed Content-Language: en-GB To: Ansuel Smith , Rob Herring , Bjorn Andersson , Andy Gross , Michael Turquette , Stephen Boyd , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org References: <20220321231548.14276-1-ansuelsmth@gmail.com> <20220321231548.14276-10-ansuelsmth@gmail.com> From: Dmitry Baryshkov In-Reply-To: <20220321231548.14276-10-ansuelsmth@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/03/2022 02:15, Ansuel Smith wrote: > Replace pr_info() with dev_info() to provide better diagnostics. > Register qsb fixed clk only if it's not declared in DTS. This can be split into two patches > > Signed-off-by: Ansuel Smith > --- > drivers/clk/qcom/krait-cc.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/qcom/krait-cc.c b/drivers/clk/qcom/krait-cc.c > index 645ad9e8dd73..e9508e3104ea 100644 > --- a/drivers/clk/qcom/krait-cc.c > +++ b/drivers/clk/qcom/krait-cc.c > @@ -308,7 +308,9 @@ static int krait_cc_probe(struct platform_device *pdev) > return -ENODEV; > > /* Rate is 1 because 0 causes problems for __clk_mux_determine_rate */ > - clk = clk_register_fixed_rate(dev, "qsb", NULL, 0, 1); > + if (IS_ERR(clk_get(dev, "qsb"))) > + clk = clk_register_fixed_rate(dev, "qsb", NULL, 0, 1); > + > if (IS_ERR(clk)) > return PTR_ERR(clk); > > @@ -363,25 +365,25 @@ static int krait_cc_probe(struct platform_device *pdev) > cur_rate = clk_get_rate(l2_pri_mux_clk); > aux_rate = 384000000; > if (cur_rate == 1) { > - pr_info("L2 @ QSB rate. Forcing new rate.\n"); > + dev_info(dev, "L2 @ QSB rate. Forcing new rate.\n"); > cur_rate = aux_rate; > } > clk_set_rate(l2_pri_mux_clk, aux_rate); > clk_set_rate(l2_pri_mux_clk, 2); > clk_set_rate(l2_pri_mux_clk, cur_rate); > - pr_info("L2 @ %lu KHz\n", clk_get_rate(l2_pri_mux_clk) / 1000); > + dev_info(dev, "L2 @ %lu KHz\n", clk_get_rate(l2_pri_mux_clk) / 1000); > for_each_possible_cpu(cpu) { > clk = clks[cpu]; > cur_rate = clk_get_rate(clk); > if (cur_rate == 1) { > - pr_info("CPU%d @ QSB rate. Forcing new rate.\n", cpu); > + dev_info(dev, "CPU%d @ QSB rate. Forcing new rate.\n", cpu); > cur_rate = aux_rate; > } > > clk_set_rate(clk, aux_rate); > clk_set_rate(clk, 2); > clk_set_rate(clk, cur_rate); > - pr_info("CPU%d @ %lu KHz\n", cpu, clk_get_rate(clk) / 1000); > + dev_info(dev, "CPU%d @ %lu KHz\n", cpu, clk_get_rate(clk) / 1000); > } > > of_clk_add_provider(dev->of_node, krait_of_get, clks); -- With best wishes Dmitry