From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 495C1283144 for ; Tue, 2 Sep 2025 19:04:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756839872; cv=none; b=o6PbIg1XeqPlOtFCFi8g7vwsi2jU7KXnNu3ZH5yIcHbGS7yxPDDvXFWuymXeUU0lYr16/i3Q6kMFeaN9It5GFcBEErjyK6CHX6faYZiYpaKvuneBFEYrF6bqdOA3taIJ6u539diBmGGWMK5XUxJv0WkMHfLVzjUw9hLJOC3FP3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756839872; c=relaxed/simple; bh=QqaVNvulk0xedvJaOU8+kp2l8TnarTA2bdwLvtGz7mY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UwXNhJkY7k4R8/Lg/wmelvk6xUO5IGfwrLGUFgqBII7Z2b8lq4TsVim7AEGR+i42jvUeCo326oOehcImdEiJ1m75uuWU8ta9G6Wz/oLhsvVCrO3c1TsAw0eqpy0zHTBpjQuJpc6VKP/A3SuagsvQK5vDAevcAMqPaQqYaygYjKc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=WCC7UbjV; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WCC7UbjV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756839870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KTRbTb03LTpsY+kMi3vTzUOF7OI46/nmbSDtqXQsQaA=; b=WCC7UbjVULVsnbQ8fpcroUecyMlCO1tn48mpzkF+zz4IYKltiKIuqzg/5kDwB6CrdDtkVA HC0kJqerzbW3+H2usrJ+01i+oxGAOQmlG5zWjx2XWFZwj0W1vPG2vvJ7ls1EBM1CLvFFDL WbasZWoqj0NhwmTmvbO+nGQIveV7W9E= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-358-DzfAJeMiN2SYlLao0c_Frw-1; Tue, 02 Sep 2025 15:04:29 -0400 X-MC-Unique: DzfAJeMiN2SYlLao0c_Frw-1 X-Mimecast-MFC-AGG-ID: DzfAJeMiN2SYlLao0c_Frw_1756839867 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-45b8dde54c1so14927785e9.1 for ; Tue, 02 Sep 2025 12:04:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756839867; x=1757444667; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KTRbTb03LTpsY+kMi3vTzUOF7OI46/nmbSDtqXQsQaA=; b=Yfo0KFmwn7fFjVyEplOOBzn4KJ0oNPJJbDyBEt5GG7fZwctMMFLSW8F9eR2SDv7n3n ih+RW3UoEze2u/TrCmMGcTcI8ZzkRK2F+QVzyjj7CUUViYgmCBUvH4yR+mQgD9t/rJpW wPftqy57X/Yef4MySRaYUqATQHLPgcFZzLTxiuNvBM5cCPD9nuuY6maXiNhpHVBdzaa8 n92hoOp0acDOs0e5e1Sg3f19w9jU3RLriiSGfXZ/+BeSNvforkKQkpoOpUruOsr+J3U8 PMPcw6mxdTxDuRqFb40gjKRTr/6k0vPUDmz06sihQ341i9QkgZ1gA6B6/qfr1hBZREF8 2NZQ== X-Forwarded-Encrypted: i=1; AJvYcCVsWyueZZOxF+Y6SuUU9qulNpLBQhpU4gHMj6IGVrZCALa+HZlx1WZSEIOs16RE3QIP0HJXHb4nYXbF@vger.kernel.org X-Gm-Message-State: AOJu0Yw2iEcak5kx1ZvHFaAocwswJda27o/df5qkz780vtCU40rPv0XP WjYbQI8hxOxPlGJx5MpbZ/aR6qB0C2yS+9LQWrf7k80oSn2kynNq9LkHAn/YufmINHxjZOfYnPw eslt0iVcnlNrWbKIu8JgeiZVnVbx1kZAvyqSbcr3+CAwu4cOCqTdk87B/XRH1LW4= X-Gm-Gg: ASbGncsQsiHnN5VoVsTsXIFLsCAsS4YvuBd53lcZkanqSDZ3U3R7/Bpa5MUjzfSIIhc maU+xT2GdqieRBeAqCaa+9dZq3yJlR1HPQwkfeDHYJ4Hxyt5S8NF9VbVmLCJasAJ8gsj44lHT3r XKuSbgW/jE7gCJ0x6DHLloQVFGjimy38duKvEjmqTZmpOFqE/R9w3QpzQHS2FdWsIgrfJw2cDxu +ZTfRPVPiTMLJqt03aHSusq3qT1tVenJmr+MWHXY47KfXoNElX07KZPwNCbROcsXWJfE0cwASvJ XqPxzjouraPdNLW/a5PwNeHqwLEn+jUL8obpMNDtkfF+DRwkmne86vjUdOksks5HJ3gRoCBzV0Y QuaSmExuG8p8vA5XbvElEHG+YS2XSBvkXegj0cIzrHNB/y9V4xpJh5gXGAwNLsyl1aGk= X-Received: by 2002:a05:600c:3543:b0:45b:8822:d683 with SMTP id 5b1f17b1804b1-45b88321c6dmr85814395e9.4.1756839866923; Tue, 02 Sep 2025 12:04:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4ZcW8yeA944p6sSftrTNNVzyMJNCGA2g5/WkaSIdV2mLjEgNupS0gXkk9kO1eEWTw0bxfSw== X-Received: by 2002:a05:600c:3543:b0:45b:8822:d683 with SMTP id 5b1f17b1804b1-45b88321c6dmr85814075e9.4.1756839866506; Tue, 02 Sep 2025 12:04:26 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1f:3f00:731a:f5e5:774e:d40c? (p200300d82f1f3f00731af5e5774ed40c.dip0.t-ipconnect.de. [2003:d8:2f1f:3f00:731a:f5e5:774e:d40c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b7e886619sm205500415e9.15.2025.09.02.12.04.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Sep 2025 12:04:25 -0700 (PDT) Message-ID: Date: Tue, 2 Sep 2025 21:04:24 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/9] mm/cma: Allow dynamically creating CMA areas To: Frank van der Linden , Thierry Reding Cc: David Airlie , Simona Vetter , Sumit Semwal , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Benjamin Gaignard , Brian Starkey , John Stultz , "T.J. Mercier" , Andrew Morton , Mike Rapoport , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org References: <20250902154630.4032984-1-thierry.reding@gmail.com> <20250902154630.4032984-4-thierry.reding@gmail.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> +>> +struct cma *__init cma_create(phys_addr_t base, phys_addr_t size, >> + unsigned int order_per_bit, const char *name) >> +{ >> + struct cma *cma; >> + int ret; >> + >> + ret = cma_check_memory(base, size); >> + if (ret < 0) >> + return ERR_PTR(ret); >> + >> + cma = kzalloc(sizeof(*cma), GFP_KERNEL); >> + if (!cma) >> + return ERR_PTR(-ENOMEM); >> + >> + cma_init_area(cma, name, size, order_per_bit); >> + cma->ranges[0].base_pfn = PFN_DOWN(base); >> + cma->ranges[0].early_pfn = PFN_DOWN(base); >> + cma->ranges[0].count = cma->count; >> + cma->nranges = 1; >> + >> + cma_activate_area(cma); >> + >> + return cma; >> +} >> + >> +void cma_free(struct cma *cma) >> +{ >> + kfree(cma); >> +} >> -- >> 2.50.0 > > > I agree that supporting dynamic CMA areas would be good. However, by > doing it like this, these CMA areas are invisible to the rest of the > system. E.g. cma_for_each_area() does not know about them. It seems a > bit inconsistent that there will now be some areas that are globally > known, and some that are not. Yeah, I'm not a fan of that. What is the big problem we are trying to solve here? Why do they have to be dynamic, why do they even have to support freeing? -- Cheers David / dhildenb