* [PATCH 1/3] perf/imx_ddr: Add MODULE_DEVICE_TABLE
2019-07-04 8:53 [PATCH 0/3] Enable imx ddr perfmon on imx8m Leonard Crestez
@ 2019-07-04 8:53 ` Leonard Crestez
2019-07-16 13:34 ` Frank Li
2019-07-04 8:53 ` [PATCH 2/3] arm64: dts: imx8m: Add ddr-pmu nodes Leonard Crestez
2019-07-04 8:53 ` [PATCH 3/3] arm64: defconfig: Build imx8 ddr pmu as module Leonard Crestez
2 siblings, 1 reply; 9+ messages in thread
From: Leonard Crestez @ 2019-07-04 8:53 UTC (permalink / raw)
To: Shawn Guo, Will Deacon, Frank Li
Cc: Mark Rutland, Dong Aisheng, Jacky Bai, devicetree, Andrey Smirnov,
Rob Herring, linux-imx, kernel, Fabio Estevam, linux-arm-kernel
This is required for automatic probing when driver is built as a module.
Fixes: 9a66d36cc7ac ("drivers/perf: imx_ddr: Add DDR performance counter support to perf")
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---
drivers/perf/fsl_imx8_ddr_perf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c
index 63fe21600072..0e3310dbb145 100644
--- a/drivers/perf/fsl_imx8_ddr_perf.c
+++ b/drivers/perf/fsl_imx8_ddr_perf.c
@@ -45,10 +45,11 @@ static DEFINE_IDA(ddr_ida);
static const struct of_device_id imx_ddr_pmu_dt_ids[] = {
{ .compatible = "fsl,imx8-ddr-pmu",},
{ .compatible = "fsl,imx8m-ddr-pmu",},
{ /* sentinel */ }
};
+MODULE_DEVICE_TABLE(of, imx_ddr_pmu_dt_ids);
struct ddr_pmu {
struct pmu pmu;
void __iomem *base;
unsigned int cpu;
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* RE: [PATCH 1/3] perf/imx_ddr: Add MODULE_DEVICE_TABLE
2019-07-04 8:53 ` [PATCH 1/3] perf/imx_ddr: Add MODULE_DEVICE_TABLE Leonard Crestez
@ 2019-07-16 13:34 ` Frank Li
0 siblings, 0 replies; 9+ messages in thread
From: Frank Li @ 2019-07-16 13:34 UTC (permalink / raw)
To: Leonard Crestez, Shawn Guo, Will Deacon
Cc: Mark Rutland, Aisheng Dong, Jacky Bai, devicetree@vger.kernel.org,
Andrey Smirnov, Rob Herring, dl-linux-imx, kernel@pengutronix.de,
Fabio Estevam, linux-arm-kernel@lists.infradead.org
> -----Original Message-----
> From: Leonard Crestez <leonard.crestez@nxp.com>
> Sent: Thursday, July 4, 2019 3:53 AM
> To: Shawn Guo <shawnguo@kernel.org>; Will Deacon <will@kernel.org>; Frank
> Li <frank.li@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Andrey Smirnov
> <andrew.smirnov@gmail.com>; Mark Rutland <mark.rutland@arm.com>;
> Aisheng Dong <aisheng.dong@nxp.com>; Fabio Estevam
> <fabio.estevam@nxp.com>; Jacky Bai <ping.bai@nxp.com>;
> devicetree@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx <linux-
> imx@nxp.com>; linux-arm-kernel@lists.infradead.org
> Subject: [PATCH 1/3] perf/imx_ddr: Add MODULE_DEVICE_TABLE
>
> This is required for automatic probing when driver is built as a module.
>
> Fixes: 9a66d36cc7ac ("drivers/perf: imx_ddr: Add DDR performance counter
> support to perf")
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Acked-by: Frank Li <frank.li@nxp.com>
> ---
> drivers/perf/fsl_imx8_ddr_perf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/perf/fsl_imx8_ddr_perf.c b/drivers/perf/fsl_imx8_ddr_perf.c
> index 63fe21600072..0e3310dbb145 100644
> --- a/drivers/perf/fsl_imx8_ddr_perf.c
> +++ b/drivers/perf/fsl_imx8_ddr_perf.c
> @@ -45,10 +45,11 @@ static DEFINE_IDA(ddr_ida); static const struct
> of_device_id imx_ddr_pmu_dt_ids[] = {
> { .compatible = "fsl,imx8-ddr-pmu",},
> { .compatible = "fsl,imx8m-ddr-pmu",},
> { /* sentinel */ }
> };
> +MODULE_DEVICE_TABLE(of, imx_ddr_pmu_dt_ids);
>
> struct ddr_pmu {
> struct pmu pmu;
> void __iomem *base;
> unsigned int cpu;
> --
> 2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/3] arm64: dts: imx8m: Add ddr-pmu nodes
2019-07-04 8:53 [PATCH 0/3] Enable imx ddr perfmon on imx8m Leonard Crestez
2019-07-04 8:53 ` [PATCH 1/3] perf/imx_ddr: Add MODULE_DEVICE_TABLE Leonard Crestez
@ 2019-07-04 8:53 ` Leonard Crestez
2019-07-16 13:35 ` Frank Li
2019-07-22 6:40 ` Shawn Guo
2019-07-04 8:53 ` [PATCH 3/3] arm64: defconfig: Build imx8 ddr pmu as module Leonard Crestez
2 siblings, 2 replies; 9+ messages in thread
From: Leonard Crestez @ 2019-07-04 8:53 UTC (permalink / raw)
To: Shawn Guo, Will Deacon, Frank Li
Cc: Mark Rutland, Dong Aisheng, Jacky Bai, devicetree, Andrey Smirnov,
Rob Herring, linux-imx, kernel, Fabio Estevam, linux-arm-kernel
The same ddr perfomance counter IP from 8qxp is also available on imx8m
series so add it to dts.
Tested with `perf stat` and `memtester` on imx8mm-evk and obtained
plausible results.
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 7 +++++++
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 7 +++++++
2 files changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index 232a7412755a..9a8d8cd21ef0 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -816,7 +816,14 @@
<0x38880000 0xc0000>; /* GICR (RD_base + SGI_base) */
#interrupt-cells = <3>;
interrupt-controller;
interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
};
+
+ ddr-pmu@3d800000 {
+ compatible = "fsl,imx8mm-ddr-pmu", "fsl,imx8m-ddr-pmu";
+ reg = <0x3d800000 0x400000>;
+ interrupt-parent = <&gic>;
+ interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
+ };
};
};
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index d09b808eff87..fb0fdee5f889 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -1031,7 +1031,14 @@
#interrupt-cells = <3>;
interrupt-controller;
interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
interrupt-parent = <&gic>;
};
+
+ ddr-pmu@3d800000 {
+ compatible = "fsl,imx8mq-ddr-pmu", "fsl,imx8m-ddr-pmu";
+ reg = <0x3d800000 0x400000>;
+ interrupt-parent = <&gic>;
+ interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
+ };
};
};
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* RE: [PATCH 2/3] arm64: dts: imx8m: Add ddr-pmu nodes
2019-07-04 8:53 ` [PATCH 2/3] arm64: dts: imx8m: Add ddr-pmu nodes Leonard Crestez
@ 2019-07-16 13:35 ` Frank Li
2019-07-22 6:40 ` Shawn Guo
1 sibling, 0 replies; 9+ messages in thread
From: Frank Li @ 2019-07-16 13:35 UTC (permalink / raw)
To: Leonard Crestez, Shawn Guo, Will Deacon
Cc: Mark Rutland, Aisheng Dong, Jacky Bai, devicetree@vger.kernel.org,
Andrey Smirnov, Rob Herring, dl-linux-imx, kernel@pengutronix.de,
Fabio Estevam, linux-arm-kernel@lists.infradead.org
> -----Original Message-----
> From: Leonard Crestez <leonard.crestez@nxp.com>
> Sent: Thursday, July 4, 2019 3:53 AM
> To: Shawn Guo <shawnguo@kernel.org>; Will Deacon <will@kernel.org>; Frank
> Li <frank.li@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Andrey Smirnov
> <andrew.smirnov@gmail.com>; Mark Rutland <mark.rutland@arm.com>;
> Aisheng Dong <aisheng.dong@nxp.com>; Fabio Estevam
> <fabio.estevam@nxp.com>; Jacky Bai <ping.bai@nxp.com>;
> devicetree@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx <linux-
> imx@nxp.com>; linux-arm-kernel@lists.infradead.org
> Subject: [PATCH 2/3] arm64: dts: imx8m: Add ddr-pmu nodes
>
> The same ddr perfomance counter IP from 8qxp is also available on imx8m
> series so add it to dts.
>
> Tested with `perf stat` and `memtester` on imx8mm-evk and obtained plausible
> results.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Acked-by: Frank Li <frank.li@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 7 +++++++
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 7 +++++++
> 2 files changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index 232a7412755a..9a8d8cd21ef0 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -816,7 +816,14 @@
> <0x38880000 0xc0000>; /* GICR (RD_base +
> SGI_base) */
> #interrupt-cells = <3>;
> interrupt-controller;
> interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> };
> +
> + ddr-pmu@3d800000 {
> + compatible = "fsl,imx8mm-ddr-pmu", "fsl,imx8m-ddr-
> pmu";
> + reg = <0x3d800000 0x400000>;
> + interrupt-parent = <&gic>;
> + interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
> + };
> };
> };
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index d09b808eff87..fb0fdee5f889 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -1031,7 +1031,14 @@
> #interrupt-cells = <3>;
> interrupt-controller;
> interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gic>;
> };
> +
> + ddr-pmu@3d800000 {
> + compatible = "fsl,imx8mq-ddr-pmu", "fsl,imx8m-ddr-
> pmu";
> + reg = <0x3d800000 0x400000>;
> + interrupt-parent = <&gic>;
> + interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
> + };
> };
> };
> --
> 2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 2/3] arm64: dts: imx8m: Add ddr-pmu nodes
2019-07-04 8:53 ` [PATCH 2/3] arm64: dts: imx8m: Add ddr-pmu nodes Leonard Crestez
2019-07-16 13:35 ` Frank Li
@ 2019-07-22 6:40 ` Shawn Guo
1 sibling, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2019-07-22 6:40 UTC (permalink / raw)
To: Leonard Crestez
Cc: Will Deacon, Frank Li, Rob Herring, Andrey Smirnov, Mark Rutland,
Dong Aisheng, Fabio Estevam, Jacky Bai, devicetree, kernel,
linux-imx, linux-arm-kernel
On Thu, Jul 04, 2019 at 11:53:21AM +0300, Leonard Crestez wrote:
> The same ddr perfomance counter IP from 8qxp is also available on imx8m
> series so add it to dts.
>
> Tested with `perf stat` and `memtester` on imx8mm-evk and obtained
> plausible results.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/3] arm64: defconfig: Build imx8 ddr pmu as module
2019-07-04 8:53 [PATCH 0/3] Enable imx ddr perfmon on imx8m Leonard Crestez
2019-07-04 8:53 ` [PATCH 1/3] perf/imx_ddr: Add MODULE_DEVICE_TABLE Leonard Crestez
2019-07-04 8:53 ` [PATCH 2/3] arm64: dts: imx8m: Add ddr-pmu nodes Leonard Crestez
@ 2019-07-04 8:53 ` Leonard Crestez
2019-07-16 13:35 ` Frank Li
2019-07-22 6:41 ` Shawn Guo
2 siblings, 2 replies; 9+ messages in thread
From: Leonard Crestez @ 2019-07-04 8:53 UTC (permalink / raw)
To: Shawn Guo, Will Deacon, Frank Li
Cc: Mark Rutland, Dong Aisheng, Jacky Bai, devicetree, Andrey Smirnov,
Rob Herring, linux-imx, kernel, Fabio Estevam, linux-arm-kernel
This is available on all imx8 but is not "boot critical" in any way so
build as a module.
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 812fe887477d..134a4067846f 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -766,10 +766,11 @@ CONFIG_PHY_ROCKCHIP_INNO_USB2=y
CONFIG_PHY_ROCKCHIP_PCIE=m
CONFIG_PHY_ROCKCHIP_TYPEC=y
CONFIG_PHY_UNIPHIER_USB2=y
CONFIG_PHY_UNIPHIER_USB3=y
CONFIG_PHY_TEGRA_XUSB=y
+CONFIG_FSL_IMX8_DDR_PMU=m
CONFIG_HISI_PMU=y
CONFIG_QCOM_L2_PMU=y
CONFIG_QCOM_L3_PMU=y
CONFIG_NVMEM_SUNXI_SID=y
CONFIG_NVMEM_IMX_OCOTP=y
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* RE: [PATCH 3/3] arm64: defconfig: Build imx8 ddr pmu as module
2019-07-04 8:53 ` [PATCH 3/3] arm64: defconfig: Build imx8 ddr pmu as module Leonard Crestez
@ 2019-07-16 13:35 ` Frank Li
2019-07-22 6:41 ` Shawn Guo
1 sibling, 0 replies; 9+ messages in thread
From: Frank Li @ 2019-07-16 13:35 UTC (permalink / raw)
To: Leonard Crestez, Shawn Guo, Will Deacon
Cc: Mark Rutland, Aisheng Dong, Jacky Bai, devicetree@vger.kernel.org,
Andrey Smirnov, Rob Herring, dl-linux-imx, kernel@pengutronix.de,
Fabio Estevam, linux-arm-kernel@lists.infradead.org
> -----Original Message-----
> From: Leonard Crestez <leonard.crestez@nxp.com>
> Sent: Thursday, July 4, 2019 3:53 AM
> To: Shawn Guo <shawnguo@kernel.org>; Will Deacon <will@kernel.org>; Frank
> Li <frank.li@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Andrey Smirnov
> <andrew.smirnov@gmail.com>; Mark Rutland <mark.rutland@arm.com>;
> Aisheng Dong <aisheng.dong@nxp.com>; Fabio Estevam
> <fabio.estevam@nxp.com>; Jacky Bai <ping.bai@nxp.com>;
> devicetree@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx <linux-
> imx@nxp.com>; linux-arm-kernel@lists.infradead.org
> Subject: [PATCH 3/3] arm64: defconfig: Build imx8 ddr pmu as module
>
> This is available on all imx8 but is not "boot critical" in any way so build as a
> module.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Acked-by: Frank Li <frank.li@nxp.com>
> ---
> arch/arm64/configs/defconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index 812fe887477d..134a4067846f 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -766,10 +766,11 @@ CONFIG_PHY_ROCKCHIP_INNO_USB2=y
> CONFIG_PHY_ROCKCHIP_PCIE=m CONFIG_PHY_ROCKCHIP_TYPEC=y
> CONFIG_PHY_UNIPHIER_USB2=y CONFIG_PHY_UNIPHIER_USB3=y
> CONFIG_PHY_TEGRA_XUSB=y
> +CONFIG_FSL_IMX8_DDR_PMU=m
> CONFIG_HISI_PMU=y
> CONFIG_QCOM_L2_PMU=y
> CONFIG_QCOM_L3_PMU=y
> CONFIG_NVMEM_SUNXI_SID=y
> CONFIG_NVMEM_IMX_OCOTP=y
> --
> 2.17.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 3/3] arm64: defconfig: Build imx8 ddr pmu as module
2019-07-04 8:53 ` [PATCH 3/3] arm64: defconfig: Build imx8 ddr pmu as module Leonard Crestez
2019-07-16 13:35 ` Frank Li
@ 2019-07-22 6:41 ` Shawn Guo
1 sibling, 0 replies; 9+ messages in thread
From: Shawn Guo @ 2019-07-22 6:41 UTC (permalink / raw)
To: Leonard Crestez
Cc: Mark Rutland, Dong Aisheng, Jacky Bai, devicetree, Andrey Smirnov,
Frank Li, Rob Herring, linux-imx, kernel, Fabio Estevam,
Will Deacon, linux-arm-kernel
On Thu, Jul 04, 2019 at 11:53:22AM +0300, Leonard Crestez wrote:
> This is available on all imx8 but is not "boot critical" in any way so
> build as a module.
>
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread