From: Dragan Simic <dsimic@manjaro.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: "Guido Günther" <guido.gunther@puri.sm>,
linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
sebastian.reichel@collabora.com, andyshrk@163.com,
jagan@edgeble.ai, daniel@ffwll.ch, airlied@gmail.com,
sam@ravnborg.org, neil.armstrong@linaro.org, megous@megous.com,
kernel@puri.sm, heiko@sntech.de, conor+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, robh+dt@kernel.org,
"Chris Morgan" <macromorgan@hotmail.com>,
"Ondrej Jirman" <megi@xff.cz>
Subject: Re: [PATCH 3/5] drm/panel: st7703: Add Powkiddy RGB30 Panel Support
Date: Mon, 16 Oct 2023 18:07:52 +0200 [thread overview]
Message-ID: <e52152b6783e3fce9aebb64a553c6922@manjaro.org> (raw)
In-Reply-To: <CADcbR4+i_B26g_gLrjTm8dxVzprb-WHRrx=r07wKhcJuei+96w@mail.gmail.com>
On 2023-10-16 17:52, Chris Morgan wrote:
> Confirmed that those pending patches DO fix the panel suspend issues.
> Thank you.
Awesome, that's great to hear! Perhaps a "Tested-by" in the original
LKML thread [1] could help with having the patch pulled sooner.
Links:
[1]
https://lore.kernel.org/lkml/33b72957-1062-1b66-85eb-c37dc5ca259b@redhat.com/T/
> On Mon, Oct 16, 2023 at 3:41 AM Guido Günther <guido.gunther@puri.sm>
> wrote:
>>
>> Hi Chris,
>> On Fri, Oct 13, 2023 at 01:39:16PM -0500, Chris Morgan wrote:
>> > From: Chris Morgan <macromorgan@hotmail.com>
>> >
>> > The Powkiddy RGB30 4 inch panel is a 4 inch 720x720 DSI panel used in
>> > the Powkiddy RGB30 handheld gaming device. Add support for it.
>> >
>> > TODO: The panel seems to not resume properly from suspend. I've
>> > confirmed on the other ST7703 based devices it works correctly.
>>
>> Regarding drm-misc-next has improvements regarding this prompted by
>> the
>> PinePhone. Maybe that fixes suspend for you too?
>>
>> Cheers,
>> -- Guido
>>
>> >
>> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
>> > ---
>> > drivers/gpu/drm/panel/panel-sitronix-st7703.c | 89 +++++++++++++++++++
>> > 1 file changed, 89 insertions(+)
>> >
>> > diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
>> > index 6a3945639535..a9892a4447fb 100644
>> > --- a/drivers/gpu/drm/panel/panel-sitronix-st7703.c
>> > +++ b/drivers/gpu/drm/panel/panel-sitronix-st7703.c
>> > @@ -433,6 +433,94 @@ static const struct st7703_panel_desc rg353v2_desc = {
>> > .init_sequence = rg353v2_init_sequence,
>> > };
>> >
>> > +static int rgb30panel_init_sequence(struct st7703 *ctx)
>> > +{
>> > + struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
>> > +
>> > + /* Init sequence extracted from Powkiddy RGB30 BSP kernel. */
>> > +
>> > + /*
>> > + * For some reason this specific panel must be taken out of sleep
>> > + * before the full init sequence, or else it will not display.
>> > + */
>> > + mipi_dsi_dcs_exit_sleep_mode(dsi);
>> > + msleep(250);
>> > +
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETEXTC, 0xf1, 0x12, 0x83);
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETMIPI, 0x33, 0x81, 0x05, 0xf9,
>> > + 0x0e, 0x0e, 0x20, 0x00, 0x00, 0x00, 0x00, 0x00,
>> > + 0x00, 0x00, 0x44, 0x25, 0x00, 0x90, 0x0a, 0x00,
>> > + 0x00, 0x01, 0x4f, 0x01, 0x00, 0x00, 0x37);
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETPOWER_EXT, 0x25, 0x22, 0xf0,
>> > + 0x63);
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_UNKNOWN_BF, 0x02, 0x11, 0x00);
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETRGBIF, 0x10, 0x10, 0x28,
>> > + 0x28, 0x03, 0xff, 0x00, 0x00, 0x00, 0x00);
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETSCR, 0x73, 0x73, 0x50, 0x50,
>> > + 0x00, 0x00, 0x12, 0x70, 0x00);
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETVDC, 0x46);
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETPANEL, 0x0b);
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETCYC, 0x80);
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETDISP, 0x3c, 0x12, 0x30);
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETEQ, 0x07, 0x07, 0x0b, 0x0b,
>> > + 0x03, 0x0b, 0x00, 0x00, 0x00, 0x00, 0xff, 0x00,
>> > + 0xc0, 0x10);
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETPOWER, 0x36, 0x00, 0x32,
>> > + 0x32, 0x77, 0xf1, 0xcc, 0xcc, 0x77, 0x77, 0x33,
>> > + 0x33);
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETBGP, 0x0a, 0x0a);
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETVCOM, 0x88, 0x88);
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETGIP1, 0xc8, 0x10, 0x0a, 0x10,
>> > + 0x0f, 0xa1, 0x80, 0x12, 0x31, 0x23, 0x47, 0x86,
>> > + 0xa1, 0x80, 0x47, 0x08, 0x00, 0x00, 0x0d, 0x00,
>> > + 0x00, 0x00, 0x00, 0x00, 0x0d, 0x00, 0x00, 0x00,
>> > + 0x48, 0x02, 0x8b, 0xaf, 0x46, 0x02, 0x88, 0x88,
>> > + 0x88, 0x88, 0x88, 0x48, 0x13, 0x8b, 0xaf, 0x57,
>> > + 0x13, 0x88, 0x88, 0x88, 0x88, 0x88, 0x00, 0x00,
>> > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
>> > + 0x00, 0x00, 0x00);
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETGIP2, 0x96, 0x12, 0x01, 0x01,
>> > + 0x01, 0x78, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00,
>> > + 0x4f, 0x31, 0x8b, 0xa8, 0x31, 0x75, 0x88, 0x88,
>> > + 0x88, 0x88, 0x88, 0x4f, 0x20, 0x8b, 0xa8, 0x20,
>> > + 0x64, 0x88, 0x88, 0x88, 0x88, 0x88, 0x23, 0x00,
>> > + 0x00, 0x01, 0x02, 0x00, 0x00, 0x00, 0x00, 0x00,
>> > + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
>> > + 0x00, 0x00, 0x40, 0xa1, 0x80, 0x00, 0x00, 0x00,
>> > + 0x00);
>> > + mipi_dsi_dcs_write_seq(dsi, ST7703_CMD_SETGAMMA, 0x00, 0x0a, 0x0f,
>> > + 0x29, 0x3b, 0x3f, 0x42, 0x39, 0x06, 0x0d, 0x10,
>> > + 0x13, 0x15, 0x14, 0x15, 0x10, 0x17, 0x00, 0x0a,
>> > + 0x0f, 0x29, 0x3b, 0x3f, 0x42, 0x39, 0x06, 0x0d,
>> > + 0x10, 0x13, 0x15, 0x14, 0x15, 0x10, 0x17);
>> > +
>> > + return 0;
>> > +}
>> > +
>> > +static const struct drm_display_mode rgb30panel_mode = {
>> > + .hdisplay = 720,
>> > + .hsync_start = 720 + 45,
>> > + .hsync_end = 720 + 45 + 4,
>> > + .htotal = 720 + 45 + 4 + 45,
>> > + .vdisplay = 720,
>> > + .vsync_start = 720 + 15,
>> > + .vsync_end = 720 + 15 + 3,
>> > + .vtotal = 720 + 15 + 3 + 11,
>> > + .clock = 36570,
>> > + .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
>> > + .width_mm = 76,
>> > + .height_mm = 76,
>> > +};
>> > +
>> > +static const struct st7703_panel_desc rgb30panel_desc = {
>> > + .mode = &rgb30panel_mode,
>> > + .lanes = 4,
>> > + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
>> > + MIPI_DSI_MODE_NO_EOT_PACKET | MIPI_DSI_MODE_LPM,
>> > + .format = MIPI_DSI_FMT_RGB888,
>> > + .init_sequence = rgb30panel_init_sequence,
>> > +};
>> > +
>> > static int st7703_enable(struct drm_panel *panel)
>> > {
>> > struct st7703 *ctx = panel_to_st7703(panel);
>> > @@ -694,6 +782,7 @@ static void st7703_remove(struct mipi_dsi_device *dsi)
>> >
>> > static const struct of_device_id st7703_of_match[] = {
>> > { .compatible = "anbernic,rg353v-panel-v2", .data = &rg353v2_desc },
>> > + { .compatible = "powkiddy,rgb30-panel", .data = &rgb30panel_desc },
>> > { .compatible = "rocktech,jh057n00900", .data = &jh057n00900_panel_desc },
>> > { .compatible = "xingbangda,xbd599", .data = &xbd599_desc },
>> > { /* sentinel */ }
>> > --
>> > 2.34.1
>> >
>>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2023-10-16 16:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 18:39 [PATCH 0/5] Add Support for RK3566 Powkiddy RGB30 Chris Morgan
2023-10-13 18:39 ` [PATCH 1/5] dt-bindings: vendor-prefixes: document Powkiddy Chris Morgan
2023-10-16 12:28 ` Krzysztof Kozlowski
2023-10-13 18:39 ` [PATCH 2/5] dt-bindings: panel: Add Powkiddy RGB30 panel compatible Chris Morgan
2023-10-16 12:29 ` Krzysztof Kozlowski
2023-10-13 18:39 ` [PATCH 3/5] drm/panel: st7703: Add Powkiddy RGB30 Panel Support Chris Morgan
2023-10-16 8:33 ` Guido Günther
2023-10-16 15:52 ` Chris Morgan
2023-10-16 16:07 ` Dragan Simic [this message]
2023-10-16 18:18 ` Heiko Stübner
2023-10-16 18:26 ` Chris Morgan
2023-10-17 7:43 ` Heiko Stübner
2023-10-13 18:39 ` [PATCH 4/5] dt-bindings: arm64: rockchip: add Powkiddy RGB30 Chris Morgan
2023-10-16 12:29 ` Krzysztof Kozlowski
2023-10-13 18:39 ` [PATCH 5/5] arm64: dts: rockchip: add support for " Chris Morgan
2023-10-16 20:58 ` (subset) [PATCH 0/5] Add Support for RK3566 " Heiko Stuebner
2023-10-16 21:02 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e52152b6783e3fce9aebb64a553c6922@manjaro.org \
--to=dsimic@manjaro.org \
--cc=airlied@gmail.com \
--cc=andyshrk@163.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=guido.gunther@puri.sm \
--cc=heiko@sntech.de \
--cc=jagan@edgeble.ai \
--cc=kernel@puri.sm \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=megi@xff.cz \
--cc=megous@megous.com \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).