From: Neil Armstrong <narmstrong@baylibre.com>
To: Boris Brezillon <boris.brezillon@collabora.com>
Cc: dri-devel@lists.freedesktop.org,
Mark Rutland <mark.rutland@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
kernel@collabora.com, Sam Ravnborg <sam@ravnborg.org>,
Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
Andrey Smirnov <andrew.smirnov@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chris Healy <cphealy@gmail.com>,
devicetree@vger.kernel.org, Jonas Karlman <jonas@kwiboo.se>,
Rob Herring <robh+dt@kernel.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Seung-Woo Kim <sw0312.kim@samsung.com>
Subject: Re: [PATCH v6 2/4] drm/bridge: Patch atomic hooks to take a drm_bridge_state
Date: Mon, 6 Jan 2020 15:46:56 +0100 [thread overview]
Message-ID: <e54886d2-052c-489e-3f38-f4e50336671f@baylibre.com> (raw)
In-Reply-To: <20200106154026.366f039e@collabora.com>
On 06/01/2020 15:40, Boris Brezillon wrote:
> On Mon, 6 Jan 2020 15:34:07 +0100
> Neil Armstrong <narmstrong@baylibre.com> wrote:
>
>> diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c
>> index 8ffa4fbbdeb3..b8b22dc55bdb 100644
>> --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c
>> +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c
>> @@ -590,8 +590,9 @@ static void __rcar_lvds_atomic_enable(struct drm_bridge *bridge,
>> }
>>
>> static void rcar_lvds_atomic_enable(struct drm_bridge *bridge,
>> - struct drm_atomic_state *state)
>> + struct drm_bridge_state *old_bridge_state)
>> {
>> + struct drm_atomic_state *state = old_bridge_state->base.state;
>> struct drm_connector *connector;
>> struct drm_crtc *crtc;
>>
>> @@ -603,7 +604,7 @@ static void rcar_lvds_atomic_enable(struct drm_bridge *bridge,
>> }
>>
>> static void rcar_lvds_atomic_disable(struct drm_bridge *bridge,
>> - struct drm_atomic_state *state)
>> + struct drm_bridge_state *state)
>
> Just a nit: maybe you should name that one old_bridge_state for
> consistency.
>
>> {
>> struct rcar_lvds *lvds = bridge_to_rcar_lvds(bridge);
>>
Sure, will update while applying.
Neil
next prev parent reply other threads:[~2020-01-06 14:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 14:34 [PATCH v6 0/4] drm: Add support for bus-format negotiation Neil Armstrong
2020-01-06 14:34 ` [PATCH v6 1/4] drm/bridge: Add a drm_bridge_state object Neil Armstrong
2020-01-07 14:46 ` Imre Deak
2020-01-06 14:34 ` [PATCH v6 2/4] drm/bridge: Patch atomic hooks to take a drm_bridge_state Neil Armstrong
2020-01-06 14:40 ` Boris Brezillon
2020-01-06 14:46 ` Neil Armstrong [this message]
2020-01-06 14:34 ` [PATCH v6 3/4] drm/bridge: Add an ->atomic_check() hook Neil Armstrong
2020-01-06 14:34 ` [PATCH v6 4/4] drm/bridge: Add the necessary bits to support bus format negotiation Neil Armstrong
2020-01-06 22:30 ` Jonas Karlman
2020-01-06 14:37 ` [PATCH v6 0/4] drm: Add support for bus-format negotiation Boris Brezillon
2020-01-07 9:24 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e54886d2-052c-489e-3f38-f4e50336671f@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=andrew.smirnov@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=cphealy@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=mark.rutland@arm.com \
--cc=nikita.yoush@cogentembedded.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=sw0312.kim@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox