From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ram Kumar Dwivedi <ram.dwivedi@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>
Cc: mani@kernel.org, alim.akhtar@samsung.com, avri.altman@wdc.com,
bvanassche@acm.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, James.Bottomley@hansenpartnership.com,
martin.petersen@oracle.com, quic_ahari@quicinc.com,
linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V1 2/3] dt-bindings: ufs: Document bindings for SA8255P UFS Host Controller
Date: Thu, 11 Dec 2025 07:30:41 +0100 [thread overview]
Message-ID: <e56989f9-c2a1-4103-8471-a8e550f940ef@kernel.org> (raw)
In-Reply-To: <23580203-3aa7-45af-872f-4bd86f39877b@oss.qualcomm.com>
On 10/12/2025 16:56, Ram Kumar Dwivedi wrote:
>>> +unevaluatedProperties: false
>>> +
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> +
>>> + soc {
>>> + #address-cells = <2>;
>>> + #size-cells = <2>;
>>> +
>>> + ufshc@1d84000 {
>>> + compatible = "qcom,sa8255p-ufshc";
>>> + reg = <0x0 0x01d84000 0x0 0x3000>;
>>
>> Drop the two 0x0 and you don't need to change address/size-cells.
>
> Hi Bjorn,
>
> All current Qualcomm chipsets, including lemans, sm8550, sm8650,sm8750,
> use a 2-cell format (#address-cells = <2>; #size-cells = <2>;) at the
> SoC level, so I followed the same pattern here for consistency.
> We plan to use the same 2-cell format in the device tree for
> this chipset as well. Please let me know your opinion.
That's not relevant. Read Bjorn's response again, till you agree and
change your code.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-11 6:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 14:56 [PATCH V1 0/3] ufs: ufs-qcom: Add support firmware managed platforms Ram Kumar Dwivedi
2025-11-14 14:56 ` [PATCH V1 1/3] MAINTAINERS: broaden UFS Qualcomm binding file pattern Ram Kumar Dwivedi
2025-11-19 8:21 ` Dmitry Baryshkov
2025-11-20 5:48 ` Manivannan Sadhasivam
2025-11-14 14:56 ` [PATCH V1 2/3] dt-bindings: ufs: Document bindings for SA8255P UFS Host Controller Ram Kumar Dwivedi
2025-11-14 19:32 ` Bjorn Andersson
2025-12-10 15:52 ` Ram Kumar Dwivedi
2025-12-10 15:56 ` Ram Kumar Dwivedi
2025-12-11 6:30 ` Krzysztof Kozlowski [this message]
2025-11-15 11:55 ` Krzysztof Kozlowski
2025-12-10 15:47 ` Ram Kumar Dwivedi
2025-11-14 14:56 ` [PATCH V1 3/3] ufs: ufs-qcom: Add support for firmware-managed resource abstraction Ram Kumar Dwivedi
2025-11-20 5:53 ` Manivannan Sadhasivam
2025-12-10 16:03 ` Ram Kumar Dwivedi
2025-12-12 0:45 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e56989f9-c2a1-4103-8471-a8e550f940ef@kernel.org \
--to=krzk@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=andersson@kernel.org \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_ahari@quicinc.com \
--cc=ram.dwivedi@oss.qualcomm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).