From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexandru Chimac <alex@chimac.ro>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Tomasz Figa <tomasz.figa@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] pinctrl: samsung: Add Exynos9610 pinctrl configuration
Date: Fri, 10 Oct 2025 14:30:48 +0200 [thread overview]
Message-ID: <e56a7e90-bf3e-473b-b898-4e1910156bbc@kernel.org> (raw)
In-Reply-To: <20250914-exynos9610-pinctrl-v1-3-90eda0c8fa03@chimac.ro>
On 14/09/2025 21:34, Alexandru Chimac wrote:
> Add pinctrl configuration for Exynos9610. The bank types
> used are the same as on Exynos850, so we can reuse the macros.
>
> Signed-off-by: Alexandru Chimac <alex@chimac.ro>
> ---
> drivers/pinctrl/samsung/pinctrl-exynos-arm64.c | 109 +++++++++++++++++++++++++
> drivers/pinctrl/samsung/pinctrl-samsung.c | 2 +
> drivers/pinctrl/samsung/pinctrl-samsung.h | 1 +
> 3 files changed, 112 insertions(+)
>
> diff --git a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
> index 5fe7c4b9f7bd424f396082f1b1b16bfb65f26cdf..a100962c51c28e2422c61a67d20faf03486f4f70 100644
> --- a/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
> +++ b/drivers/pinctrl/samsung/pinctrl-exynos-arm64.c
> @@ -1604,6 +1604,115 @@ const struct samsung_pinctrl_of_match_data exynos8895_of_data __initconst = {
> .num_ctrl = ARRAY_SIZE(exynos8895_pin_ctrl),
> };
>
> +/* pin banks of exynos9610 pin-controller 0 (ALIVE) */
> +static struct samsung_pin_bank_data exynos9610_pin_banks0[] = {
Please use upstream as your starting point, not downstream. Missing const.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-10 12:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-14 19:34 [PATCH 0/3] pinctrl: samsung: add Exynos9610 pinctrl support Alexandru Chimac
2025-09-14 19:34 ` [PATCH 1/3] dt-bindings: pinctrl: samsung: Add exynos9610-pinctrl compatible Alexandru Chimac
2025-09-22 15:42 ` Rob Herring (Arm)
2025-09-14 19:34 ` [PATCH 2/3] dt-bindings: pinctrl: samsung: Add exynos9610-wakeup-eint node Alexandru Chimac
2025-09-22 15:42 ` Rob Herring (Arm)
2025-09-14 19:34 ` [PATCH 3/3] pinctrl: samsung: Add Exynos9610 pinctrl configuration Alexandru Chimac
2025-10-10 12:30 ` Krzysztof Kozlowski [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-09-14 19:31 [PATCH 0/3] pinctrl: samsung: add Exynos9610 pinctrl support Alexandru Chimac
2025-09-14 19:32 ` [PATCH 3/3] pinctrl: samsung: Add Exynos9610 pinctrl configuration Alexandru Chimac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e56a7e90-bf3e-473b-b898-4e1910156bbc@kernel.org \
--to=krzk@kernel.org \
--cc=alex@chimac.ro \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).