* Re: [PATCH 2/2] arm: AT91: fix DT duplicate node name
[not found] ` <910fee2eb99b2d95e59fa6b997645b498f167022.1504037038.git.mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
@ 2017-09-14 16:53 ` Nicolas Ferre
2017-10-04 21:20 ` Michał Mirosław
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Ferre @ 2017-09-14 16:53 UTC (permalink / raw)
To: Michał Mirosław, Alexandre Belloni
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
On 29/08/2017 at 22:08, Michał Mirosław wrote:
> Fix following warning at bootup:
>
> device-tree: Duplicate name in fb@0x00500000, renamed to "display#1"
>
> Signed-off-by: Michał Mirosław <mirq-linux-CoA6ZxLDdyEEUmgCuDUIdw@public.gmane.org>
> ---
> arch/arm/boot/dts/at91sam9m10g45ek.dts | 48 +++++++++++++++++-----------------
> 1 file changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91sam9m10g45ek.dts b/arch/arm/boot/dts/at91sam9m10g45ek.dts
> index 9cf1f5163fbd..272af5867403 100644
> --- a/arch/arm/boot/dts/at91sam9m10g45ek.dts
> +++ b/arch/arm/boot/dts/at91sam9m10g45ek.dts
> @@ -223,30 +223,6 @@
> fb0: fb@0x00500000 {
> display = <&display0>;
> status = "okay";
> -
> - display0: display {
Michał, thanks for your patch.
Actually the DT binding requires this:
Documentation/devicetree/bindings/video/atmel,lcdc.txt
So it's somehow a bigger issue.
Moreover, several boards have exactly the same arrangement than the
at91sam9m10g45ek, so you probably need to modify them all at the same time.
After a brief look at drivers/video/fbdev/atmel_lcdfb.c it seems that
the name of the node is not so much important, so we can modify it
(something like display0: lcd-display {}) .
I suggest that you modify the binding, the board files affected and
re-submit a patch.
Best regards,
> - bits-per-pixel = <32>;
> - atmel,lcdcon-backlight;
> - atmel,dmacon = <0x1>;
> - atmel,lcdcon2 = <0x80008002>;
> - atmel,guard-time = <9>;
> - atmel,lcd-wiring-mode = "RGB";
> -
> - display-timings {
> - native-mode = <&timing0>;
> - timing0: timing0 {
> - clock-frequency = <9000000>;
> - hactive = <480>;
> - vactive = <272>;
> - hback-porch = <1>;
> - hfront-porch = <1>;
> - vback-porch = <40>;
> - vfront-porch = <1>;
> - hsync-len = <45>;
> - vsync-len = <1>;
> - };
> - };
> - };
> };
>
> nand0: nand@40000000 {
> @@ -293,6 +269,30 @@
> };
> };
>
> + display0: display {
> + bits-per-pixel = <32>;
> + atmel,lcdcon-backlight;
> + atmel,dmacon = <0x1>;
> + atmel,lcdcon2 = <0x80008002>;
> + atmel,guard-time = <9>;
> + atmel,lcd-wiring-mode = "RGB";
> +
> + display-timings {
> + native-mode = <&timing0>;
> + timing0: 480x272 {
> + clock-frequency = <9000000>;
> + hactive = <480>;
> + vactive = <272>;
> + hback-porch = <1>;
> + hfront-porch = <1>;
> + vback-porch = <40>;
> + vfront-porch = <1>;
> + hsync-len = <45>;
> + vsync-len = <1>;
> + };
> + };
> + };
> +
> pwmleds {
> compatible = "pwm-leds";
>
>
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread