From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dietmar Eggemann Subject: Re: [PATCH 6/7] arm, arm64: factorize common cpu capacity default code Date: Thu, 19 Jan 2017 16:00:45 +0000 Message-ID: References: <20170119143757.14537-1-juri.lelli@arm.com> <20170119143757.14537-7-juri.lelli@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170119143757.14537-7-juri.lelli@arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Juri Lelli , linux-kernel@vger.kernel.org Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, lorenzo.pieralisi@arm.com, vincent.guittot@linaro.org, linux-pm@vger.kernel.org, peterz@infradead.org, catalin.marinas@arm.com, broonie@kernel.org, will.deacon@arm.com, gregkh@linuxfoundation.org, Russell King , robh+dt@kernel.org, sudeep.holla@arm.com, linux@arm.linux.org.uk, morten.rasmussen@arm.com, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 19/01/17 14:37, Juri Lelli wrote: > arm and arm64 share lot of code relative to parsing CPU capacity > information from DT, using that information for appropriate scaling and > exposing a sysfs interface for chaging such values at runtime. > > Factorize such code in a common place (driver/base/arch_topology.c) in > preparation for further additions. > > Suggested-by: Will Deacon > Suggested-by: Mark Rutland > Suggested-by: Catalin Marinas > Cc: Russell King > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Greg Kroah-Hartman > Signed-off-by: Juri Lelli > --- > arch/arm/Kconfig | 1 + > arch/arm/kernel/topology.c | 213 ++------------------------------------ > arch/arm64/Kconfig | 1 + > arch/arm64/kernel/topology.c | 213 +------------------------------------- > drivers/base/Kconfig | 8 ++ > drivers/base/Makefile | 1 + > drivers/base/arch_topology.c | 240 +++++++++++++++++++++++++++++++++++++++++++ > 7 files changed, 260 insertions(+), 417 deletions(-) > create mode 100644 drivers/base/arch_topology.c [...] > +extern unsigned long > +arch_scale_cpu_capacity(struct sched_domain *sd, int cpu); How about adding a driver specific prefix 'foo_' to all driver interfaces? I'm asking because I would rather like to do a #define arch_scale_cpu_capacity foo_scale_cpu_capacity then a #define arch_scale_cpu_capacity arch_scale_cpu_capacity in arch/arm64/include/asm/topology.h later to wire cpu-invariant load-tracking support up to the task scheduler for ARM64. That's probably true too for all the 'driver' interfaces which get used in arch/arm{,64}/kernel/topology.c. [...]