From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0B32EB64DD for ; Sat, 1 Jul 2023 08:34:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230154AbjGAIeL (ORCPT ); Sat, 1 Jul 2023 04:34:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbjGAIeG (ORCPT ); Sat, 1 Jul 2023 04:34:06 -0400 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF6D813E for ; Sat, 1 Jul 2023 01:34:03 -0700 (PDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-9926623e367so311078166b.0 for ; Sat, 01 Jul 2023 01:34:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688200442; x=1690792442; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ln71CslK+wNkG4luuwS7YiYZydBZMEVnpr27Fg4FgP0=; b=Q2NkimT1scuu/IiVNGHS7pfdg2HjllvWeMMG8MZCygBWNeAyBQ4YZlE8VlWTun+qm+ qAbWN2xzkTCjjrRMRq4i/pkcFfBg+mP6KaYVMrm+rGQW/5BLU29xi6PRhNSTh4G5aqrd 3+OuNyObya/Nb6RQWikgKOie/dcsMauAim2cQxxYHcBAjUokVadSDDKl3HnHHeOfUaCX OQgjXn6Hu5AgIDFGXiBgTt4h1H26pwj4DbfK4eeTE9f52jY3HuljAk97JnPocjfJpSRA cUJ68KOn2nq3XIGz6rhz/YEBKQaS8xAi9gUoebuRWndad1Mrh8JEs5PQ8Qtq37iI3FmB IFZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688200442; x=1690792442; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ln71CslK+wNkG4luuwS7YiYZydBZMEVnpr27Fg4FgP0=; b=bynqro96OdHpsiescalNZYqKKvWOopr0ymIPIU7UuRtBm/jcUD/8B/eYYGaeQjPEq3 Ixqwt4phr8emAKrnc7IolsXw1HfFXYlw5OuWDAtOml8kIXD//2ejOYl2bJSGxIGhz0uz C/UJIxc9/h25KEQtRtuV7+G1ptAc1VJl76/S4JZ9NhfIgG3N+izWJmCDo8RL5p3egHDS sB4wIJd0GOW9gSSdu9OFhCkplVVQE5MrougldWbxaijN0QuTt40A8l+jtzwIlTK4zCYP bHHFl9tPbmDXveYA5PLPlXbGROKgH5S6fcZzDkLGGSfFPeS08qVoRx8JFWYuHjunA9Wf 4vqA== X-Gm-Message-State: ABy/qLYyKgk9P2D6H7WUQFpuKW14oI1HdxZI1JcIWiqUJZ7Wyc/kf3hy g/11wyZ3PRazqYsxKL1+ebfhrg== X-Google-Smtp-Source: APBJJlHxmuqetckhUv6v1CC+aVS7a9zdw4R4oa+2xmoDW0Qz3S/5/qPZdv0AD3U+alxjTqLMoko7jw== X-Received: by 2002:a17:906:854c:b0:98c:cc3c:194e with SMTP id h12-20020a170906854c00b0098ccc3c194emr3250372ejy.52.1688200442264; Sat, 01 Jul 2023 01:34:02 -0700 (PDT) Received: from [192.168.10.214] ([217.169.179.6]) by smtp.gmail.com with ESMTPSA id w6-20020a17090633c600b0098748422178sm8908124eja.56.2023.07.01.01.34.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Jul 2023 01:34:01 -0700 (PDT) Message-ID: Date: Sat, 1 Jul 2023 10:34:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 5/6] can: tcan4x5x: Add support for tcan4552/4553 Content-Language: en-US To: Markus Schneider-Pargmann , Marc Kleine-Budde Cc: Wolfgang Grandegger , Rob Herring , Krzysztof Kozlowski , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Conor Dooley , Chandrasekar Ramakrishnan , Michal Kubiak , Vivek Yadav , linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Simon Horman References: <20230621093103.3134655-1-msp@baylibre.com> <20230621093103.3134655-6-msp@baylibre.com> <32557326-650c-192d-9a82-ca5451b01f70@linaro.org> <20230621123158.fd3pd6i7aefawobf@blmsp> <21f12495-ffa9-a0bf-190a-11b6ae30ca45@linaro.org> <20230622122339.6tkajdcenj5r3vdm@blmsp> <20230627142300.heju4qccian5hsjk@blmsp> From: Krzysztof Kozlowski In-Reply-To: <20230627142300.heju4qccian5hsjk@blmsp> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/06/2023 16:23, Markus Schneider-Pargmann wrote: >>> The version information is always readable for that chip, regardless of >>> state and wake GPIOs as far as I know. So yes it is possible to setup >>> the GPIOs based on the content of the ID register. >>> >>> I personally would prefer separate compatibles. The binding >>> documentation needs to address that wake and state GPIOs are not >>> available for tcan4552/4553. I think having compatibles that are for >>> these chips would make sense then. However this is my opinion, you are >>> the maintainer. >> >> We do not talk about compatibles in the bindings here. This is >> discussion about your driver. The entire logic of validating DTB is >> flawed and not needed. Detect the variant and act based on this. > > I thought it was about the bindings, sorry. > > So to summarize the compatibles ti,tcan4552 and ti,tcan4553 are fine. > But the driver should use the ID register for detection and not compare > the detected variant with the given compatible? > > In my opinion it is useful to have an error messages that says there is > something wrong with the devicetree as this can be very helpful for the > developers who bringup new devices. This helps to quickly find issues > with the devicetree. That's not a current policy for other drivers, so this shouldn't be really special. Kernel is poor in validating DTS. It's not its job. It's the job of the DT schema. Best regards, Krzysztof