From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 309C7C761A6 for ; Tue, 28 Mar 2023 07:09:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230215AbjC1HJR (ORCPT ); Tue, 28 Mar 2023 03:09:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbjC1HJP (ORCPT ); Tue, 28 Mar 2023 03:09:15 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0E8230E1 for ; Tue, 28 Mar 2023 00:09:12 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id eh3so45490598edb.11 for ; Tue, 28 Mar 2023 00:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679987351; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SOVU8RBe7aR7D4CaCDozBWMIHjex6O25PxAUFtGHR20=; b=JzHU38sHO7In6qpvbTJgTbAqk1fVTJ2CQ0Wd9Ls7ggx9Em/S5v+64RwlQECakrVpcH zeJydAMiV53vnjPyJV1k73sd2vuMCJ3wXKTvNR8h7UNmQatNDCVwEGX6Up7Y9tDIjCJp UivJP29SM8DYeQ8B57yX+9xDbcFaTI8YVL92a7BIb3f5/0Ax/wcrosiNNiFXbpQxxHtu n5lNtMFWWdgpr+kwgqqNFyLc5ZMTuLPw2tOtTvQG8cLc+bC7yGIAn/T7/SI8l0MZrgym /pNmt13+4uWtqwlnqayT+YQ0cnPqrJy4cGayO9ZM3477EFTdjPjCuzp4vxdY276sf3DF 21YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679987351; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SOVU8RBe7aR7D4CaCDozBWMIHjex6O25PxAUFtGHR20=; b=1WK5TqIuUAPVGWvuFLK/vdeP6E2f4LswofoS1ZrUYS245h5C9y9rPeHqhelbdaIpUt FcQ/1nFh8xUii5jyoJ9WYYvjKs6UWTQVRgGDEO8iFzmQRG3SOlC+dNe3PwlxyogcPTJv G/+XXAfA8upiyNLXecjcpUX1CE/oVrAH94XDdPd8PkHaIXxoEngD82dVl74Vfj5EXH0i ZTt9X+zD9BwsEK8ZF7kCUqxna/Y6lAKp4Bx91Q2hzzRvQfH48MIQBVXWMDrMwDuC5OQP hw3Okx0AamlJgVjitDGt5703TpY/UF9r+bijBj3wRNifRpV3t9x7agI6cDvq1D8Ofmm3 avLw== X-Gm-Message-State: AO0yUKVYygJ4cW7kNJR8m0wQd9OeV2H8/OJHltuJpwURb1ZrknGo5kF9 PQkQxNDDyA3AsPO170hzpN4pIA== X-Google-Smtp-Source: AK7set++FIrmezxGT+XslLTQjEdJlsT5IB14A1jKFakYYMeGeD3Uyo1qplKKlDhDanwJTz/sSprUyw== X-Received: by 2002:a05:6402:1c95:b0:4af:7bdc:188e with SMTP id cy21-20020a0564021c9500b004af7bdc188emr22837333edb.16.1679987351279; Tue, 28 Mar 2023 00:09:11 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:9e92:dca6:241d:71b6? ([2a02:810d:15c0:828:9e92:dca6:241d:71b6]) by smtp.gmail.com with ESMTPSA id j30-20020a508a9e000000b004af5968cb3bsm15378561edj.17.2023.03.28.00.09.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Mar 2023 00:09:10 -0700 (PDT) Message-ID: Date: Tue, 28 Mar 2023 09:09:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v4 7/8] arm64: dts: qcom: ipq9574: Add USB related nodes Content-Language: en-US To: Varadarajan Narayanan , agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org, kishon@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, quic_wcheng@quicinc.com, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-clk@vger.kernel.org References: From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/03/2023 11:30, Varadarajan Narayanan wrote: > Add USB phy and controller related nodes > > Signed-off-by: Varadarajan Narayanan > --- > Changes in v4: > - Use newer bindings without subnodes > - Fix coding style issues > > Changes in v3: > - Insert the nodes at proper location > > Changes in v2: > - Fixed issues flagged by Krzysztof > - Fix issues reported by make dtbs_check > - Remove NOC related clocks (to be added with proper > interconnect support) > --- > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 83 +++++++++++++++++++++++++++++++++++ > 1 file changed, 83 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > index 2bb4053..5379c25 100644 > --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi > @@ -215,6 +215,45 @@ > #size-cells = <1>; > ranges = <0 0 0 0xffffffff>; > > + qusb_phy_0: phy@7b000 { > + compatible = "qcom,ipq9574-qusb2-phy"; > + reg = <0x0007b000 0x180>; > + #phy-cells = <0>; > + > + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>, > + <&xo_board_clk>; > + clock-names = "cfg_ahb", > + "ref"; > + > + resets = <&gcc GCC_QUSB2_0_PHY_BCR>; > + status = "disabled"; > + }; > + > + ssphy_0: phy@7d000 { > + compatible = "qcom,ipq9574-qmp-usb3-phy"; > + reg = <0x0007d000 0xa00>; > + #clock-cells = <1>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; Why do you need these three? > + > + clocks = <&gcc GCC_USB0_AUX_CLK>, > + <&gcc GCC_USB0_PHY_CFG_AHB_CLK>, > + <&gcc GCC_USB0_PIPE_CLK>; > + clock-names = "aux", > + "cfg_ahb", > + "pipe"; > + > + resets = <&gcc GCC_USB0_PHY_BCR>, > + <&gcc GCC_USB3PHY_0_PHY_BCR>; > + reset-names = "phy", > + "common"; > + status = "disabled"; > + > + #phy-cells = <0>; > + clock-output-names = "usb0_pipe_clk"; Does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). > + }; > + > pcie0_phy: phy@84000 { > compatible = "qcom,ipq9574-qmp-gen3x1-pcie-phy"; > reg = <0x00084000 0x1bc>; /* Serdes PLL */ > @@ -436,6 +475,50 @@ > status = "disabled"; > }; > > + usb3: usb3@8a00000 { usb@ > + compatible = "qcom,ipq9574-dwc3", "qcom,dwc3"; > + reg = <0x08af8800 0x400>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges; > + > + clocks = <&gcc GCC_SNOC_USB_CLK>, > + <&gcc GCC_ANOC_USB_AXI_CLK>, > + <&gcc GCC_USB0_MASTER_CLK>, > + <&gcc GCC_USB0_SLEEP_CLK>, > + <&gcc GCC_USB0_MOCK_UTMI_CLK>; > + > + clock-names = "sys_noc_axi", > + "anoc_axi", > + "master", > + "sleep", > + "mock_utmi"; > + > + assigned-clocks = <&gcc GCC_USB0_MASTER_CLK>, > + <&gcc GCC_USB0_MOCK_UTMI_CLK>; > + assigned-clock-rates = <200000000>, > + <24000000>; > + > + resets = <&gcc GCC_USB_BCR>; > + status = "disabled"; > + > + dwc_0: usb@8a00000 { > + compatible = "snps,dwc3"; > + reg = <0x8a00000 0xcd00>; > + clocks = <&gcc GCC_USB0_MOCK_UTMI_CLK>; > + clock-names = "ref"; > + interrupts = ; > + phys = <&qusb_phy_0>, <&ssphy_0>; > + phy-names = "usb2-phy", "usb3-phy"; > + tx-fifo-resize; > + snps,is-utmi-l1-suspend; > + snps,hird-threshold = /bits/ 8 <0x0>; > + snps,dis_u2_susphy_quirk; > + snps,dis_u3_susphy_quirk; > + dr_mode = "host"; Are you saying that peripheral mode cannot work on this USB controller? Never? Best regards, Krzysztof