From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B7C9C433FE for ; Thu, 29 Sep 2022 11:14:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234756AbiI2LOF (ORCPT ); Thu, 29 Sep 2022 07:14:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234421AbiI2LOC (ORCPT ); Thu, 29 Sep 2022 07:14:02 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AFDCEBD6C for ; Thu, 29 Sep 2022 04:14:01 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id 10so1733337lfy.5 for ; Thu, 29 Sep 2022 04:14:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=JCh++P5qIzDBHCAdkyavsqkmhn8xd4gauTae0eHjI/s=; b=asdXkChlFju1IPfKnT9Zzz6BqO2nzkgscO8FO1TEbmmzGObR03XAcp68Q31idxjF8b +IWu1Mz5jExFv8XhVka2L2sp6GVtnewzz78xdUNgjd6RfnkVF3H1vFMeLx1QrMBC5MKU oep7vR7UyH/T5/zYUinW1WizcVWnmUU82z1y37x0OWrZKbIh7zebtVBy7f5am7X/utUH bgpQL2hPF9v6sc6aSMfNJhKg8RqDRbWyemuG3xqhO7ZDIieabIX9iZr+4TOhNur4GpcN Cd8to3ntEON8IOE1YP0IxdrQ9Rh3rvSfJmLeLR1iHYJq9VnycbtbBusGVFL1XncctcJ+ ytGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=JCh++P5qIzDBHCAdkyavsqkmhn8xd4gauTae0eHjI/s=; b=7NyOAEK27s2PbUb/ToqO9zuwYPD2/E6Xa+8/nlapWhdB6njpqgEpUNUalqoGkNaYyx 33jjppKvdML6rxiJoKn6Bqa44ylTeqqF1F37aZcw6SM7avthF6KhsiViTvpx5Qntfxcx 0NBJBiICwxnS01GdPcMFb/koV48n/MdAHV+f8DisvSOyDw+9jl636cHMmm4neQgL3lPJ hcyC70ea1IdpAuc1SyYAVZCmLYR3j7rhk8n/3mrv6mu7ikFqHV2swbGJWfSJH2RL2y1d v5CC+FfO2KN8bx5N0zOvXxkH3V0caArpy2od3ls1eE2X340eJ0c6kdscyTKNpxDAFh/A aDpw== X-Gm-Message-State: ACrzQf3D5ta+LLbrWNyC1x2gdA+Wm1ExmpCRVCNP8SaMyQ5xiZVizQOs dIy2lJiUKPp5IIsWGN7f/IdN4A== X-Google-Smtp-Source: AMsMyM7bglyEuBmB9wRohtd/U31Y9OxzxlLBUyiz3f5gaY77GVWK03UTalRPBdrK2kpVNQprzV8gdQ== X-Received: by 2002:a05:6512:401c:b0:49f:4b2e:7153 with SMTP id br28-20020a056512401c00b0049f4b2e7153mr1115352lfb.443.1664450039671; Thu, 29 Sep 2022 04:13:59 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id u1-20020a056512128100b0049a5a59aa68sm757355lfs.10.2022.09.29.04.13.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 04:13:59 -0700 (PDT) Message-ID: Date: Thu, 29 Sep 2022 13:13:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v1 2/2] dt-bindings: add bindings for QCOM flash LED Content-Language: en-US To: Fenglin Wu , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Pavel Machek , Rob Herring , Krzysztof Kozlowski , linux-leds@vger.kernel.org, devicetree@vger.kernel.org Cc: quic_collinsd@quicinc.com, quic_subbaram@quicinc.com References: <20220928024239.3843909-1-quic_fenglinw@quicinc.com> <20220928024239.3843909-3-quic_fenglinw@quicinc.com> <6c0e5083-baae-3ed3-5eed-e08bbb9e7576@linaro.org> <2d6fac8d-0ac1-75bb-0b4c-c2c34583b09e@quicinc.com> <107dfb13-85fc-123d-d244-962ce6c1cdb7@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <107dfb13-85fc-123d-d244-962ce6c1cdb7@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/09/2022 12:56, Fenglin Wu wrote: >> If driver binds to only one compatible, it is expected to be the >> fallback for all others. There might be exception for this rule but it >> does not look like here. >> >>> But I was thinking to give out the PMIC names >>> here so anyone who is using the driver could easily identify if the >>> driver is suitable for the HW that he/she is using. >> >> I did not say to remove other compatibles, but to use one fallback for >> all of them. >> > Do you mean to update it similar to this? > > compatible: > items: > - enum: > - qcom,pm8150c-flash-led > - qcom,pm8150l-flash-led > - qcom,pm8350c-flash-led > - const: > - qcom,spmi-flash-led Yes, just const is not a list, so "const: qcom,spmi-flash-led" Best regards, Krzysztof