From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A661AC05027 for ; Fri, 20 Jan 2023 16:49:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230491AbjATQtn (ORCPT ); Fri, 20 Jan 2023 11:49:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230456AbjATQtm (ORCPT ); Fri, 20 Jan 2023 11:49:42 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B18E228D2F for ; Fri, 20 Jan 2023 08:49:41 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id q5so726011wrv.0 for ; Fri, 20 Jan 2023 08:49:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ReqL3/KdTtoMI5gOn47wEfy8Brch/hDuTRzHxmxqXLI=; b=HrWAbzIu1bfu5+Ce6Jw2FEMPVasYO23fFdoUKI+s2D5dbd/iFNqYGuO1NWjYcusFKy fP9liXt78VZOHABtZOIYTAWWAAwkkrz7GVp/N10X76oFvPrJmDlHk+4Fgwv8rjCKwuus tFouDnkYAVUa4IIcvCYAQxzY/2uIqD/2hPonHIq4+yuN/6kQgGsnpArb/o55+WXIgbEB tRn0xd4tH8ozAowgLV/G7pe9Hr7HEcWabeLEvmDCDJNMCpwGvWH2rIokvMONX8B9UE5M pQuSJnDvLsfG3xLeUvaKGtLV2rDhWCWwojOJBeUj/zyGuO6T4FPiweqaOlj1sZm9tP9y mvEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ReqL3/KdTtoMI5gOn47wEfy8Brch/hDuTRzHxmxqXLI=; b=E7r8ryqvQFJ+laaB4jYyLe83+mNmb+QocTC31MpX/5BgTDOPSi59TkzvZcxtBreOi9 EZwHSMfrAVweJH0bucCaemhjS5v6vdNjqd+Pfh846DGD88Bz8ZEzXeRiS/TQImy7QoHv lUwru/0+t0AJx6nEBRXhY1Yhx5mBJzRg0JTQ6IqOP6WNpc6/QJxR4cqgSeErpPsgiGtD Qssm+rVv1yi2kQT4ho6Fe4Brs2spzsxqJVKquMuAI5htMim85tIQRU2OUv1HUSpLTOQi +DNSuARQPgseCmB84ICOZDS7DmEh08qM13S5U7ssjQxpsgWwN03lcpVpBmdTPwb8S/gU 4KNQ== X-Gm-Message-State: AFqh2kqeb9O26h/nqdSAjV7mFGruYImHNQCSDobCqHNbJ9z7ZadBDvPf Y9aJmfQVcEYgvRgCs2aK4Q9chg== X-Google-Smtp-Source: AMrXdXtEWQc0BoNfAHarjgxoITnBqOmzi3Fm+XNUr6JyoaeecEc3V7G+XJtcFtNOp9ktTOsRs0d5CQ== X-Received: by 2002:a5d:4e84:0:b0:2be:c94c:ebff with SMTP id e4-20020a5d4e84000000b002bec94cebffmr1852291wru.56.1674233380271; Fri, 20 Jan 2023 08:49:40 -0800 (PST) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id y18-20020a5d6152000000b002425be3c9e2sm35581781wrt.60.2023.01.20.08.49.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Jan 2023 08:49:39 -0800 (PST) Message-ID: Date: Fri, 20 Jan 2023 16:49:38 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 2/4] arm64: dts: qcom: sm6350: Add camera clock controller Content-Language: en-US To: Luca Weiss , Andy Gross , Bjorn Andersson , Konrad Dybcio , Loic Poulain , Robert Foss , Rob Herring , Krzysztof Kozlowski Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221213-sm6350-cci-v2-0-15c2c14c34bb@fairphone.com> <20221213-sm6350-cci-v2-2-15c2c14c34bb@fairphone.com> From: Bryan O'Donoghue In-Reply-To: <20221213-sm6350-cci-v2-2-15c2c14c34bb@fairphone.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 20/01/2023 13:13, Luca Weiss wrote: > + camcc: clock-controller@ad00000 { > + compatible = "qcom,sm6350-camcc"; > + reg = <0 0x0ad00000 0 0x16000>; > + clocks = <&rpmhcc RPMH_CXO_CLK>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + #power-domain-cells = <1>; > + }; Should you include required-opps = <&rpmhpd_opp_low_svs>; ? --- bod