* [PATCH] ARM: dts: enable WLAN for Mecer Xtreme Mini S6
@ 2020-04-05 11:00 Justin Swartz
2020-04-06 9:57 ` Johan Jonker
0 siblings, 1 reply; 6+ messages in thread
From: Justin Swartz @ 2020-04-05 11:00 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Mark Rutland
Cc: Justin Swartz, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel
The Mecer Xtreme Mini S6 features a wireless module, based on a
Realtek 8723BS, which provides WLAN and Bluetooth connectivity via
SDIO and UART interfaces respectively.
Define a simple MMC power sequence that declares the GPIO pins
connected to the module's WLAN Disable and Bluetooth Disable pins
as active low reset signals, because both signals must be deasserted
for WLAN radio operation.
Configure the host's SDIO interface for High Speed mode with 1.8v
I/O signalling and IRQ detection over a 4-bit wide bus.
Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
---
arch/arm/boot/dts/rk3229-xms6.dts | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/rk3229-xms6.dts b/arch/arm/boot/dts/rk3229-xms6.dts
index 679fc2b00..cdfcef41b 100644
--- a/arch/arm/boot/dts/rk3229-xms6.dts
+++ b/arch/arm/boot/dts/rk3229-xms6.dts
@@ -39,6 +39,12 @@
};
};
+ sdio_pwrseq: sdio-pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ reset-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>,
+ <&gpio2 29 GPIO_ACTIVE_LOW>;
+ };
+
vcc_host: vcc-host-regulator {
compatible = "regulator-fixed";
enable-active-high;
@@ -202,6 +208,18 @@
status = "okay";
};
+&sdio {
+ bus-width = <4>;
+ cap-sd-highspeed;
+ cap-sdio-irq;
+ disable-wp;
+ mmc-pwrseq = <&sdio_pwrseq>;
+ non-removable;
+ num-slots = <1>;
+ vqmmc-supply = <&vccio_1v8>;
+ status = "okay";
+};
+
&sdmmc {
cap-mmc-highspeed;
disable-wp;
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: enable WLAN for Mecer Xtreme Mini S6
2020-04-05 11:00 [PATCH] ARM: dts: enable WLAN for Mecer Xtreme Mini S6 Justin Swartz
@ 2020-04-06 9:57 ` Johan Jonker
2020-04-06 13:50 ` [PATCH v2] " Justin Swartz
2020-04-06 13:50 ` [PATCH] ARM: dts: remove disable-wp from rk3229-xms6 emmc Justin Swartz
0 siblings, 2 replies; 6+ messages in thread
From: Johan Jonker @ 2020-04-06 9:57 UTC (permalink / raw)
To: justin.swartz
Cc: devicetree, heiko, linux-arm-kernel, linux-kernel, linux-rockchip,
mark.rutland, robh+dt
Hi Justin,
Have a look at the documents:
Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml
Documentation/devicetree/bindings/mmc/synopsys-dw-mshc-common.yaml
Documentation/devicetree/bindings/mmc/mmc-controller.yaml
Fix &emmc as well.
> From: Justin Swartz <justin.swartz@risingedge.co.za>
> To: Heiko Stuebner <heiko@sntech.de>,
> Rob Herring <robh+dt@kernel.org>,
> Mark Rutland <mark.rutland@arm.com>
> Cc: Justin Swartz <justin.swartz@risingedge.co.za>,
> linux-arm-kernel@lists.infradead.org,
> linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
> linux-kernel@vger.kernel.org
> Subject: [PATCH] ARM: dts: enable WLAN for Mecer Xtreme Mini S6
> Date: Sun, 5 Apr 2020 11:00:21 +0000
> Message-ID: <20200405110022.3849-1-justin.swartz@risingedge.co.za> (raw)
>
> The Mecer Xtreme Mini S6 features a wireless module, based on a
> Realtek 8723BS, which provides WLAN and Bluetooth connectivity via
> SDIO and UART interfaces respectively.
>
> Define a simple MMC power sequence that declares the GPIO pins
> connected to the module's WLAN Disable and Bluetooth Disable pins
> as active low reset signals, because both signals must be deasserted
> for WLAN radio operation.
>
> Configure the host's SDIO interface for High Speed mode with 1.8v
> I/O signalling and IRQ detection over a 4-bit wide bus.
>
> Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
> ---
> arch/arm/boot/dts/rk3229-xms6.dts | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3229-xms6.dts b/arch/arm/boot/dts/rk3229-xms6.dts
> index 679fc2b00..cdfcef41b 100644
> --- a/arch/arm/boot/dts/rk3229-xms6.dts
> +++ b/arch/arm/boot/dts/rk3229-xms6.dts
> @@ -39,6 +39,12 @@
> };
> };
>
> + sdio_pwrseq: sdio-pwrseq {
> + compatible = "mmc-pwrseq-simple";
> + reset-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>,
> + <&gpio2 29 GPIO_ACTIVE_LOW>;
> + };
> +
> vcc_host: vcc-host-regulator {
> compatible = "regulator-fixed";
> enable-active-high;
> @@ -202,6 +208,18 @@
> status = "okay";
> };
>
> +&sdio {
> + bus-width = <4>;
> + cap-sd-highspeed;
> + cap-sdio-irq;
> + disable-wp;
Not used in combination with sdio and emmc.
> + mmc-pwrseq = <&sdio_pwrseq>;
> + non-removable;
> + num-slots = <1>;
Deprecated.
> + vqmmc-supply = <&vccio_1v8>;
> + status = "okay";
> +};
> +
> &sdmmc {
> cap-mmc-highspeed;
> disable-wp;
> --
> 2.11.0
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] ARM: dts: enable WLAN for Mecer Xtreme Mini S6
2020-04-06 9:57 ` Johan Jonker
@ 2020-04-06 13:50 ` Justin Swartz
2020-05-18 22:42 ` Heiko Stuebner
2020-04-06 13:50 ` [PATCH] ARM: dts: remove disable-wp from rk3229-xms6 emmc Justin Swartz
1 sibling, 1 reply; 6+ messages in thread
From: Justin Swartz @ 2020-04-06 13:50 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Mark Rutland
Cc: Justin Swartz, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel
The Mecer Xtreme Mini S6 features a wireless module, based on a
Realtek 8723BS, which provides WLAN and Bluetooth connectivity via
SDIO and UART interfaces respectively.
Define a simple MMC power sequence that declares the GPIO pins
connected to the module's WLAN Disable and Bluetooth Disable pins
as active low reset signals, because both signals must be deasserted
for WLAN radio operation.
Configure the host's SDIO interface for High Speed mode with 1.8v
I/O signalling and IRQ detection over a 4-bit wide bus.
Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
---
Changes in v2:
- Remove unused disable-wp and deprecated num-slots attributes
from &sdio, as suggested by Johan Jonker.
arch/arm/boot/dts/rk3229-xms6.dts | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/rk3229-xms6.dts b/arch/arm/boot/dts/rk3229-xms6.dts
index 679fc2b00..6890af0b7 100644
--- a/arch/arm/boot/dts/rk3229-xms6.dts
+++ b/arch/arm/boot/dts/rk3229-xms6.dts
@@ -39,6 +39,12 @@
};
};
+ sdio_pwrseq: sdio-pwrseq {
+ compatible = "mmc-pwrseq-simple";
+ reset-gpios = <&gpio2 26 GPIO_ACTIVE_LOW>,
+ <&gpio2 29 GPIO_ACTIVE_LOW>;
+ };
+
vcc_host: vcc-host-regulator {
compatible = "regulator-fixed";
enable-active-high;
@@ -202,6 +208,16 @@
status = "okay";
};
+&sdio {
+ bus-width = <4>;
+ cap-sd-highspeed;
+ cap-sdio-irq;
+ mmc-pwrseq = <&sdio_pwrseq>;
+ non-removable;
+ vqmmc-supply = <&vccio_1v8>;
+ status = "okay";
+};
+
&sdmmc {
cap-mmc-highspeed;
disable-wp;
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] ARM: dts: enable WLAN for Mecer Xtreme Mini S6
2020-04-06 13:50 ` [PATCH v2] " Justin Swartz
@ 2020-05-18 22:42 ` Heiko Stuebner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2020-05-18 22:42 UTC (permalink / raw)
To: Rob Herring, Justin Swartz, Mark Rutland
Cc: Heiko Stuebner, linux-arm-kernel, devicetree, linux-kernel,
linux-rockchip
On Mon, 6 Apr 2020 13:50:04 +0000, Justin Swartz wrote:
> The Mecer Xtreme Mini S6 features a wireless module, based on a
> Realtek 8723BS, which provides WLAN and Bluetooth connectivity via
> SDIO and UART interfaces respectively.
>
> Define a simple MMC power sequence that declares the GPIO pins
> connected to the module's WLAN Disable and Bluetooth Disable pins
> as active low reset signals, because both signals must be deasserted
> for WLAN radio operation.
>
> [...]
Applied, thanks!
[1/1] ARM: dts: enable WLAN for Mecer Xtreme Mini S6
commit: 6067ec2c7ffacab4689ddfed3df74a467d112efe
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: remove disable-wp from rk3229-xms6 emmc
2020-04-06 9:57 ` Johan Jonker
2020-04-06 13:50 ` [PATCH v2] " Justin Swartz
@ 2020-04-06 13:50 ` Justin Swartz
2020-05-18 22:42 ` Heiko Stübner
1 sibling, 1 reply; 6+ messages in thread
From: Justin Swartz @ 2020-04-06 13:50 UTC (permalink / raw)
To: Heiko Stuebner, Rob Herring, Mark Rutland
Cc: Justin Swartz, linux-arm-kernel, linux-rockchip, devicetree,
linux-kernel
Remove the disable-wp attribute from &emmc as it is, according to
Documentation/devicetree/bindings/mmc/mmc-controller.yaml:
"Not used in combination with eMMC or SDIO."
Suggested-by: Johan Jonker <jbx6244@gmail.com>
Signed-off-by: Justin Swartz <justin.swartz@risingedge.co.za>
---
arch/arm/boot/dts/rk3229-xms6.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/rk3229-xms6.dts b/arch/arm/boot/dts/rk3229-xms6.dts
index 6890af0b7..e75624d46 100644
--- a/arch/arm/boot/dts/rk3229-xms6.dts
+++ b/arch/arm/boot/dts/rk3229-xms6.dts
@@ -137,7 +137,6 @@
&emmc {
cap-mmc-highspeed;
- disable-wp;
non-removable;
status = "okay";
};
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-18 22:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-05 11:00 [PATCH] ARM: dts: enable WLAN for Mecer Xtreme Mini S6 Justin Swartz
2020-04-06 9:57 ` Johan Jonker
2020-04-06 13:50 ` [PATCH v2] " Justin Swartz
2020-05-18 22:42 ` Heiko Stuebner
2020-04-06 13:50 ` [PATCH] ARM: dts: remove disable-wp from rk3229-xms6 emmc Justin Swartz
2020-05-18 22:42 ` Heiko Stübner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).