From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62C49381AE for ; Wed, 15 Nov 2023 16:21:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nkWcuGjH" Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0DD4D40 for ; Wed, 15 Nov 2023 08:21:19 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2c5056059e0so100075861fa.3 for ; Wed, 15 Nov 2023 08:21:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1700065278; x=1700670078; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vVv1D9dMzK2tGtDx8E6+Meyyl7KM9X9Cid8vZyXVWLQ=; b=nkWcuGjHWJlB5oS6s7QCKl3FJKD8BYVs9YdjKPKINd9d1LnpFfakwqEXoBS7xW5Nt5 Gtcc37cKfSDpibVFQ2NsQLabGSJ2a4xAJ3BY+g5hEQHo505zfTZGvkKfY90pQ0BrqgOg sqAg1UIbM9In5PqbYpkX0DSsgDCzkAYFGUhfBPqAirROTXdLQBZ2m5iFBWKa775OEjpD y72smCeEQIzruatQXYPlhJEvptIWmrYSb0kq0GKwiYZCgqK1BkAIM624D/gHbsmhKmO7 EGbE7NkgOfSu2eKZ5qlTTLcM1xmHkk9S2GnrhOHnD2j/z1KeqPJHXp2j352wQ/Y8INFf tqRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700065278; x=1700670078; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vVv1D9dMzK2tGtDx8E6+Meyyl7KM9X9Cid8vZyXVWLQ=; b=njVlf0YVWcJ0u4d/j2WTfRASyCTb7JTX48dIlf/NLMpiQS1bYPHZDysiMcRBEbtDTJ Pcczl1su8XHcYvor/kwB2jmiFjSxSN/8QZMCRY9V5B0kOK9uZe6uHl9sF7x51PD9M1j2 j60lf/TAeD4qVb0cQeOEHy3MZIJu7tkD9rLURkS+SjUV+FjOefSolpE/Ro871VHV0UXC gYVF4pJUEIl3N7V/u3gPgsqWEbhkQ92AiETJw+/Fyw9+gjNcPtSZtO49lfESjBJaHQUR 05jpOxK/KIJbRjGH55aUcmeKvsFVcSy8dMkU98Fslf2zkXToz1r0u5EYWMMmxaSX9oM8 pdVg== X-Gm-Message-State: AOJu0YzXxp0pB5LcTMSHUQ9WZa4A+8yM+zxQaAA0QoLNJdBXB3z6fR4k n0B2WzWyiLomz19DXiAGjXOFlQ== X-Google-Smtp-Source: AGHT+IFCLx6HHI+jGJHV1et2rTKGgSRQshmq5seiuQChkp/OhZAw87J/KqKNvRdslV7HkciiBmhLaA== X-Received: by 2002:a2e:7811:0:b0:2c5:1e70:7d30 with SMTP id t17-20020a2e7811000000b002c51e707d30mr4743696ljc.30.1700065277935; Wed, 15 Nov 2023 08:21:17 -0800 (PST) Received: from [172.30.204.150] (UNUSED.212-182-62-129.lubman.net.pl. [212.182.62.129]) by smtp.gmail.com with ESMTPSA id k8-20020a05651c0a0800b002bce77e4ddfsm1699622ljq.97.2023.11.15.08.21.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Nov 2023 08:21:17 -0800 (PST) Message-ID: Date: Wed, 15 Nov 2023 17:21:16 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/3] dt-bindings: connector: usb: provide bindings for altmodes Content-Language: en-US To: Dmitry Baryshkov , Hans de Goede Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Mark Gross , Heikki Krogerus , Greg Kroah-Hartman , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org References: <20231113145328.42575-1-dmitry.baryshkov@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: * On 11/13/23 23:13, Dmitry Baryshkov wrote: > On Mon, 13 Nov 2023 at 18:07, Hans de Goede wrote: >> >> Hi Dmitry, >> >> On 11/13/23 15:33, Dmitry Baryshkov wrote: >>> In some cases we need a way to specify USB-C AltModes that can be >>> supportd on the particular USB-C connector. For example, x86 INT33FE >>> driver does this by populating fwnode properties internally. For the >>> Qualcomm Robotics RB5 platform (and several similar devices which use >>> Qualcomm PMIC TCPM) we have to put this information to the DT. >>> >>> Provide the DT bindings for this kind of information and while we are at >>> it, change svid property to be 16-bit unsigned integer instead of a >>> simple u32. >> >> Thank you for your patches. I'm fine with this, one remark though: >> >> Since at least the existing arch/arm64/boot/dts/qcom/qrb5165-rb5.dts >> is already using this I'm not sure of changing the svid property to >> an u16 is really a good idea from devicetree compatibility pov ? > > Usually we try to keep DT compatible, that's true. And I also do not > fully like the u16 notation. However I'm not sure whether using full > u32 for explicitly u16 value is correct. I'll wait for the guidance > from DT binding and USB maintainers. > > I'll mention the qrb5165-rb5 explicitly in the cover letter. I'd say it's fine since it was incorrect from the start (+ bindings shouldn't describe linux's flaws) Konrad