From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 205E8ECAAA1 for ; Thu, 27 Oct 2022 15:24:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234884AbiJ0PYv (ORCPT ); Thu, 27 Oct 2022 11:24:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235292AbiJ0PYt (ORCPT ); Thu, 27 Oct 2022 11:24:49 -0400 Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44D9D1E3F8 for ; Thu, 27 Oct 2022 08:24:46 -0700 (PDT) Received: by mail-qv1-xf2e.google.com with SMTP id o8so1590275qvw.5 for ; Thu, 27 Oct 2022 08:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/Iv4yihl8R3+MqrWIVJu+D8Wg49pHiLfK8EszmRHeyo=; b=rYo/ycT7Egnx1TQLXOyxX1Hk+6kivX/M0VmYU7ymYjx15dxxEHKP9apakp39s3bKpA M85Mh72GwaMpK4/LaUfsLUOycolZ5nErtUMduT3H5eQ1TRGDwgRry887xbEEBDhzTxGf tPy4ytGIU0a4kZQ3SY/hgzL5pMk8A3dSWNHQLMqqpI25agMwN+RBMuZzYVWXql2J5xqR B2c8o7UWHhwbcvOzM+tMjga4KUrv0sk+7GVmQXovJ7RtMWynySnyYNry2B+ugQI8pn9H oZ6r872cBnWHyG2au7Q5XDOJgaOIAn3DXkgxA6bIlzU2twmlZKTsUqVbVlVp6sbdnGVX FnTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/Iv4yihl8R3+MqrWIVJu+D8Wg49pHiLfK8EszmRHeyo=; b=HKUIxLZYoPFUOvAR5BUyKA49Wve79EFJIVPiERpXivbrraeF1UpAlydpOS9R8+WifT meIvdJu+TDcPcsTUHw1PQD07EvPiRLkIn8AAIdbvCn+XO1SRXGFVsppFP1BZG79QZowL Ds2tURouxenDrIa8tDve1c9wv0PfZbrNwn4qnsRnWeebe09nzd88+wC4v46qp6Umxd// /35bqum/YLND4RJulSwWVOSU4kap9Zn+eG93w8bYo4QhxA2HSolMdafPRt82QB5RfPSI 9WEdgDqCrWZlLlb+k2HqIGtxq30vtoeW08C8aerOsd+yCwYP0tbo6slG8x42/P76RjHy 6b/g== X-Gm-Message-State: ACrzQf3spjWW6lQ06SGMswlj7+Hv4k9h/k7q6z4Eig+91iYQm5TxssB6 O0/w3QdfS6D5oLSXBYvPYuwF/g== X-Google-Smtp-Source: AMsMyM5PcfyOaaWBzPJbnCh6VCwZ0bHo7Q37fM6oG5KBT7P6CcCtGK+/dpog6JFwhJjRtLq9AH3how== X-Received: by 2002:a05:6214:ac7:b0:4bb:6236:e190 with SMTP id g7-20020a0562140ac700b004bb6236e190mr22366552qvi.87.1666884285577; Thu, 27 Oct 2022 08:24:45 -0700 (PDT) Received: from [192.168.1.11] ([64.57.193.93]) by smtp.gmail.com with ESMTPSA id j3-20020a05620a410300b006eef13ef4c8sm1143237qko.94.2022.10.27.08.24.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Oct 2022 08:24:45 -0700 (PDT) Message-ID: Date: Thu, 27 Oct 2022 11:24:43 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v3 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles Content-Language: en-US To: Melody Olvera , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: Robert Marko , Guru Das Srinagesh , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221026190549.4005703-1-quic_molvera@quicinc.com> <20221026190549.4005703-2-quic_molvera@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20221026190549.4005703-2-quic_molvera@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 26/10/2022 15:05, Melody Olvera wrote: > Add compatibles for scm driver for QDU1000 and QRU1000 platforms. > > Signed-off-by: Melody Olvera > --- > .../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > index be1b5746eddb..5352181aa393 100644 > --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > @@ -38,6 +38,7 @@ properties: > - qcom,scm-msm8994 > - qcom,scm-msm8996 > - qcom,scm-msm8998 > + - qcom,scm-qdu1000 > - qcom,scm-sc7180 > - qcom,scm-sc7280 > - qcom,scm-sc8280xp > @@ -81,6 +82,20 @@ properties: > description: TCSR hardware block > > allOf: > + - if: > + properties: > + compatible: > + contains: > + const: qcom,scm-qdu1000 > + then: > + properties: > + '#reset-cells': > + maxItems: 1 This is wrong... how can you have here more items? > + clocks: false > + clock-names: false > + > + required: > + - '#reset-cells' Missing blank line. > - if: > properties: > compatible: Best regards, Krzysztof