From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18CF6C77B75 for ; Fri, 5 May 2023 17:55:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231623AbjEERzf (ORCPT ); Fri, 5 May 2023 13:55:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232167AbjEERzY (ORCPT ); Fri, 5 May 2023 13:55:24 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5ADB81CFDE for ; Fri, 5 May 2023 10:55:02 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-96598a7c5e0so332438966b.3 for ; Fri, 05 May 2023 10:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683309294; x=1685901294; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HnrC5KbWM7NW+1rdcdep21pD1YRsAygMgxxRqzKCAY8=; b=vflr857KdOHNGGSgi1/lYVg09hlv83Gvww0WupAJDSWmXrq9Sljm03Vk+O1Y8FGXHH 8nfgHVuW5j2gFyUGsBfAJUjpu0TtIf8jO6M+6N5lGHvyAznhi3XMKmYi5eR2q69m2kjv nr3LJhfBH7d+k1QYM7mtzIzR3/jQdB5lEbq6KygbXhF15vkRMCvALeuidWFljblY1v0B tMzx3gpLfmDCRIZoxcOvphZU3JE3WRSrA5IACVjFAaSN5bYvPjd5gBH7L36g6or0mdq+ EREFp2P61hPqqQB2zBNVJUG3glZaXLDTN6rJ91TFQjOUWQRlKVECKrQ96Vhp/FsOeb/D o4cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683309294; x=1685901294; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HnrC5KbWM7NW+1rdcdep21pD1YRsAygMgxxRqzKCAY8=; b=aginxaqDb6wDo22HvN4DBZfaJyQp3hsZUcyxOxctiB5XsgKVBcmZrLWifl/gONGGBT 8sA6J0fFPN/uvluoS3rXc2ku5QY/7Xpbpiw/3kBYh0MWa4FUQnGZkU1+IVlB4DKeTEc/ e3kJn6BHpEnB/gV6RdZUYAEarY/jO2+/Ty70F7P14mUSk5KyM8wUyWNua43R4eXwoY9+ lu2NW/uXI1F/oVIHY99Jw+SrYr1d8K5g2bW0USNvpsWJinDMnWWECetq3pD/LTL3pvw9 yuJmb7w/q71nHmKpfnUGEqYzZjSkyp8FdrTKM4LbuQFYQ8TEUoxN22FX8nw6xGxJ4BnM tZwg== X-Gm-Message-State: AC+VfDyD4q2leQ5eUbn1/MI+Uc0uXWpYOjWEE2cIhN7rxIEn4YrzAt1K asln8cc5bJBr4Z2TwDWXjSI6zw== X-Google-Smtp-Source: ACHHUZ6qwa4b7FK5QlqahPRiXKFKWV6KzKwBRMW7+KVwzSD6Xh0orsW703ArW5+qjxpHuSOr26vkyA== X-Received: by 2002:a17:906:fe4e:b0:94a:44ef:853d with SMTP id wz14-20020a170906fe4e00b0094a44ef853dmr1810355ejb.68.1683309294295; Fri, 05 May 2023 10:54:54 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:52e:24ce:bbc1:127d? ([2a02:810d:15c0:828:52e:24ce:bbc1:127d]) by smtp.gmail.com with ESMTPSA id ia24-20020a170907a07800b00959b3c30f2csm1195972ejc.222.2023.05.05.10.54.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 May 2023 10:54:53 -0700 (PDT) Message-ID: Date: Fri, 5 May 2023 19:54:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v4 2/5] dt-bindings: soc: qcom: eud: Add SM6115 / SM4250 support Content-Language: en-US To: Bhupesh Sharma Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, linux-kernel@vger.kernel.org, bhupesh.linux@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org References: <20230505064039.1630025-1-bhupesh.sharma@linaro.org> <20230505064039.1630025-3-bhupesh.sharma@linaro.org> <1374d7ea-94a3-60b0-f9db-7528aae22a34@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/05/2023 18:27, Bhupesh Sharma wrote: > Hi Krzysztof, > > On Fri, 5 May 2023 at 21:54, Krzysztof Kozlowski > wrote: >> >> On 05/05/2023 08:40, Bhupesh Sharma wrote: >>> Add dt-bindings for EUD found on Qualcomm SM6115 / SM4250 SoC. >>> >>> On this SoC (and derivatives) the enable bit inside 'tcsr_check_reg' >>> needs to be set first to 'enable' the eud module. >>> >>> So, update the dt-bindings to accommodate the third register >>> property (TCSR Base) required by the driver on these SoCs. >>> >>> Also for these SoCs, introduce a new bool property >>> 'qcom,secure-mode-enable', which indicates that the mode manager >>> needs to be accessed only via the secure world. >> >> Cannot it be implied by compatible? > > I can see this will be used by future SoCs as well from the available > EUD documentation. > > So let's keep a dedicated dt property as suggested by Bjorn in earlier > reviews, as otherwise the compatible checks would start getting bigger > / messier in the driver code, in my opinion, when we add EUD support > for other SoCs + boards. I don't understand the last part about compatible checks would grow. Why would you have any compatible check in the driver? This looks standard as we do with all SoC properties, so via driver data. Best regards, Krzysztof