From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EA1DC001B0 for ; Sat, 24 Jun 2023 09:38:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233062AbjFXJiX (ORCPT ); Sat, 24 Jun 2023 05:38:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232769AbjFXJiW (ORCPT ); Sat, 24 Jun 2023 05:38:22 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDD941BE7 for ; Sat, 24 Jun 2023 02:38:20 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-51bec86b9c9so1568661a12.2 for ; Sat, 24 Jun 2023 02:38:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687599499; x=1690191499; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zXBFCivXYU4jqrNenN0qqCdwRcocFvfR8QjuhlC/BNA=; b=R68zl3EL0G2cCxmLykHsoLVBaFLnVsVmuPYJGvZiSFCkHgoVSkrCVf+n9i4Q0yOWDg +s3so7MPt6yCrcnH39+6/mDLpjDbQlfumyCDRYM5HqCSpU9oTSBp+QQf2zvVy7sT5rAD 2ykkyJqbMz5FGn0oRZxWJqtn5SDEWmV05NL2H7P+GTJcYpMBAe2nmTcWDWq0phXF2Vy1 V35CVaORp5+zHfJsaY6+dDEXzyY8zC53AGNPotbheHGgrCeaEZc/QW00F8XsLkmTsR8o D8y22pr6oO09jUpK6NSkr1fXkD/x7wTyaXTr+xcvIe5OsPJ8dmTwsBZ1tW8HKDYaQt/u cq0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687599499; x=1690191499; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zXBFCivXYU4jqrNenN0qqCdwRcocFvfR8QjuhlC/BNA=; b=d9CJ6UihPQce8Q4xDAU02SawJubPYYoIoETXRorNDmwagYYFTsMHuxi8jSQjXBIjvo A8NH2RVpWH9yAbliuiGLo7WGytq454YAmE8UsO6C0Seixc3b9xkpeSePUjpf7P9lvdT/ 9/D1TyC3bEcdxRQlYFkFmP1vdtMY/W8pbUFZzdB6BzKvRcYW6TqkTGPNFfPIuhLbhaYx a45za+Gsjl9uy+hnJKUbzLwQR/DWH9RSUDNVQqgys0hpVgrkk1TZK1i3E4u7nHqzUK+q y/BbK/krnKj+Y2PMCyJ/bBZ3ZOPZOYUB61zHLWuCnupFC2OwMzvBQt/7BTT2yRO+ufKF pcgg== X-Gm-Message-State: AC+VfDxu9h2VrqEHaVGg5pkQexfnvwM+AILaG0Y4SFd1dhbjRw3SjBy+ PJaEXBaY7d7SzIn698tfo0hBEw== X-Google-Smtp-Source: ACHHUZ7PVLABuL30C6bX/NntvPW8rghUXjMj6NCmfnVnVEa70oQE8lUdlRmnW05GgXT5nQ/s5wXJbw== X-Received: by 2002:aa7:c14a:0:b0:51b:deaf:a489 with SMTP id r10-20020aa7c14a000000b0051bdeafa489mr5936677edp.12.1687599499110; Sat, 24 Jun 2023 02:38:19 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id v9-20020aa7cd49000000b005187a42b44fsm474958edw.58.2023.06.24.02.38.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Jun 2023 02:38:18 -0700 (PDT) Message-ID: Date: Sat, 24 Jun 2023 11:38:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 1/7] dt-bindings: soc: qcom: Add qcom-pbs bindings Content-Language: en-US To: Anjelique Melendez , pavel@ucw.cz, lee@kernel.org, thierry.reding@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org Cc: konrad.dybcio@linaro.org, u.kleine-koenig@pengutronix.de, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org References: <20230621185949.2068-1-quic_amelende@quicinc.com> <20230621185949.2068-2-quic_amelende@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <20230621185949.2068-2-quic_amelende@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/06/2023 20:59, Anjelique Melendez wrote: > Add binding for the Qualcomm Programmable Boot Sequencer device. > > Signed-off-by: Anjelique Melendez > --- > .../bindings/soc/qcom/qcom-pbs.yaml | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom-pbs.yaml Except missing testing... few more comments: > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom-pbs.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom-pbs.yaml > new file mode 100644 > index 000000000000..0a89c334f95c > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom-pbs.yaml Filename matching compatibles, so qcom,pbs > @@ -0,0 +1,41 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/soc/qcom/qcom-pbs.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. PBS Qualcomm PBS foo bar a bit more than just one word. E.g. expand PBS acronym > + > +maintainers: > + - Anjelique Melendez > + > +description: | > + Qualcomm PBS (programmable boot sequencer) supports triggering sequences > + for clients upon request. I don't understand what's this. What is "triggering sequences"? What sequences? > + > +properties: > + compatible: > + const: qcom,pbs Missing SoC specific comaptibles. > + > + reg: > + description: | > + Base address of the PBS peripheral. Drop description, it's obvious. > + maxItems: 1 > + Binding looks very incomplete... > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + pmic { > + #address-cells = <1>; > + #size-cells = <0>; > + > + qcom,pbs@7400 { That's not a proper node name. Do you see anywhere such node? Please, do not work on downstream code, but on mainline. > + compatible = "qcom,pbs"; > + reg = <0x7400>; > + }; > + }; Best regards, Krzysztof