From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F6F23A2574 for ; Wed, 13 May 2026 18:19:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696370; cv=none; b=jTI5wv5wWhWUBxstgxfvFg3WJK388HF6W4KokvlIZjGNvGDDjFTripP6TkN6AXxQbf2GLWOBlCAz+mw6lNb1Ni4GTsS8P4cn/xXuL8gjPR2N69TOF403v+8Kpab5MrV8PELsV8K7KdllM69QTVC6oKwDKxvOjvFDoZttBz/WRTk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696370; c=relaxed/simple; bh=OV4PfceyG19hBTR3s6fFftTS+Jdev4XVhsmwAWPNwj4=; h=Message-ID:Date:MIME-Version:Subject:To:References:From:Cc: In-Reply-To:Content-Type; b=gePTXOAXN3pS4hHBHQTQ58yjdBum9ZT7EsWkML8c9bf3FYp6/Y/Qa5bPLKfrJZz+OiD8ZgrWykDsK8i/fAW91TwV3u634fgeekeJ3wcQUEwr9hc2H15nb9nls/Lho/XQ5gas9u7yQGG5p/XJ/0LUZZFHAKhmFtAL6Q4ntJR9AWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U7liTCF+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=d8AjoiLw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U7liTCF+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="d8AjoiLw" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64DF3lNt4159672 for ; Wed, 13 May 2026 18:19:27 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= /2wytpUijrKO0T5ubOcr0fnwpc//VPFoJ2V9cgdQyr0=; b=U7liTCF+jEkricGz tIQQDX5CwfAb0PWYCyQo9gN9nOGXa/OyPq88JGhzlPTxoE1z7OIzlKxn8EoudZu9 LVfnTCZNIwAWyctJghdVxjPt4KYW1gqa7SE1MmB/JNbWeY6tM3m1vYBDj7P9mZSI 33C9bH+zDaJKBZCgXCDRqVKdVqcKe9mF2meOdeV6raQE1vGgmNKFfAsUJal3bSH7 6ql83UFwZW1DiigvE3JlZ+9Y4uoKFvbz5/saWUUhbsD1y65davuYpo4Vn2kTKf9k paqqODdiA5sMm5oDorqHQjS6oC7uXJOdy3JH8DaJihQIgA0+A4n7zuI3uk4uSLzo ptX/zw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e4p91t7jk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 13 May 2026 18:19:27 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2b9b8137828so75342435ad.0 for ; Wed, 13 May 2026 11:19:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778696367; x=1779301167; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:cc:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=/2wytpUijrKO0T5ubOcr0fnwpc//VPFoJ2V9cgdQyr0=; b=d8AjoiLwQGdmkNBLSgqGaNJYOF+ORmNJZnxhW533mBnYdYhI6HdmgYZxDDNQxnCKbQ vGiuQ3sFwZEDxqkjypKI8uX0nez0jvGhjKx5R8eHqOvomseiPNtFL4/baQbg6DofmETt jcsUii5gPb67EZgHE7hT34t4k57o67y/BhdLA4vLL6fTbXNsu02SrzQZp4lPv2HVoVKp X/qk1spmtrAO7RNBnDijcL4HGb6Zcc8VKZRRoMb8So09KjY2xtutjzlwAk6jFqB+H+fn Bm+vYloTbF8F0I/CklDfIjVIcOxvyhp6iFT+q0a6cBbrES8D+O+dfuGTnC/agRO7HIU8 rLfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778696367; x=1779301167; h=content-transfer-encoding:in-reply-to:cc:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/2wytpUijrKO0T5ubOcr0fnwpc//VPFoJ2V9cgdQyr0=; b=WOnpsCcwAzfEDXqkGj967EPe8yhbGR5AfXUr+Ib9wQnRUXregdWgqp+fCl7jZxflzS 3hvMcU0hwnqtibnP426o8B38n7PAKaehUdzVzgfecTWVXEZeMSbAU6IGVk+xfFTVuS+H pLmIdriyiD1glHqcLBkDsY4cPHec6Shf4gC8jFT7J2brOaF1BIjOFtIdBh2K4FvPzNzi Rhb5tkK3ONq6PCFbUMXJpKla+gk5OZLXnJT5fYDathviEVWBV2w+bBGWkDaS/dIuuEHf 6LPbomiQE/W+A8cYKQlWJVtZlPadrEa1RAQvM4kApa27P/7XT20UmS79ctUdhSCUcO0l /kng== X-Forwarded-Encrypted: i=1; AFNElJ+8ESbvxUoD6p3+JrGJv1U0lrXOFz2JHgt9PNh6qbLuAxk1UdTse8yU8UJookS164vHEd4pFQochfAv@vger.kernel.org X-Gm-Message-State: AOJu0Yz1ajAegSt1PMNGwC1ay+7BRnPXzV1CD1kB44E7hNV+WxjbtClh bspBpDDcDls4Wi6h6nN8Mrxeop/PYaDgnFJBhdrcSWNfww+jBmpbOQdcgyEsRp2eQo7rXb91yrm G8Kk7pA164H6u7+sogiLFIEJDE9QNrV4WGhBMvRcD2CHdZXDBjmJnpRIy06+j09N7 X-Gm-Gg: Acq92OHNjh/+kbawPhZSSL0uuaH7qg2e7htwz9HJm8bTYd9hv9RvsCnG6imu6EVYQDC ihCLLbUrF7zkcH2nqPFOcCVDbzU+p8rcoltDEgMEybkWXhX6Sqgu0N/LlZu3ZuI/dN7yh9CKV3y mujahAgHJ7guvfcSDxNlZBKKwoyE8oSvISTqXnDhiu2zi8y0LuS7YaGqtNF+dKs5rH6cHBBWURV KVVXTXu3vKtnK9WtbrPgAcPJC0KPYrNv2m+X5/SAy5jeLO0XGJJAUblQoXVDD9FzUdtmDYBTtPo yLiPrPPDbs4hx4nJXkdOi0lUSqzA6xbUh5HCkYe8vWBwlV1wTKK1crlHxWUUf1zpEiQ6Ob6+rfc m/W8zQ0Mnd5oKjSWjv+WE/NW/b9yk72gqegR2xhJvRKtHmx4QYGQoDCOIYbcgtQ== X-Received: by 2002:a05:6a20:3d22:b0:39b:fbb2:5e46 with SMTP id adf61e73a8af0-3afb1a0a4fbmr4184397637.40.1778696366908; Wed, 13 May 2026 11:19:26 -0700 (PDT) X-Received: by 2002:a05:6a20:3d22:b0:39b:fbb2:5e46 with SMTP id adf61e73a8af0-3afb1a0a4fbmr4184362637.40.1778696366337; Wed, 13 May 2026 11:19:26 -0700 (PDT) Received: from [192.168.0.110] ([183.82.29.182]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c826768acf3sm18897017a12.10.2026.05.13.11.19.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 11:19:25 -0700 (PDT) Message-ID: Date: Wed, 13 May 2026 23:49:20 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 0/6] Add new driver for WCSS secure PIL loading To: Bjorn Andersson References: <20260505102310.2925956-1-varadarajan.narayanan@oss.qualcomm.com> Content-Language: en-US From: Vignesh Viswanathan Cc: Varadarajan Narayanan , mathieu.poirier@linaro.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, konradybcio@kernel.org, manikanta.mylavarapu@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20260505102310.2925956-1-varadarajan.narayanan@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: IR7lQljmags3yYPUBCHyDtJS9AF4vWMb X-Proofpoint-GUID: IR7lQljmags3yYPUBCHyDtJS9AF4vWMb X-Authority-Analysis: v=2.4 cv=G9Ys1dk5 c=1 sm=1 tr=0 ts=6a04c0af cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=zhxe3pEVf5X/RQkgbsjYTw==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=LpQP-O61AAAA:8 a=EUspDBNiAAAA:8 a=UqCG9HQmAAAA:8 a=2DIguSIwZBnVL4SAOv4A:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=TjNXssC_j7lpFel5tvFf:22 a=pioyyrs4ZptJ924tMmac:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEzMDE4MiBTYWx0ZWRfX6/jsyAlFLBXz qsBKJ0KhmSy5dCW+IqAp5pS4OZoKXOu/6in3weRv6JCJr1M26o9MK+VUrqZfSD85wz3Z9WYw8mK 5dxeRxF54IDuSrfTLKOiU9TiyRaMxMIfNH/7Y5qU2/Ld1tsevmC//TtXtDKgx7jr3yNQnU9d0fE g0KZB+dBkP2QnLuDIBclj/zPaP0ZX+xQbj2PviZb6YhRmM9bAHBOC3urYUTFj0VcbME9XKTj7xD 9/nuL7PUmpj3mCU0Pp5i5fsM2QiDGQYOnYCeioSVP5+stGlZ3xO5HpLBXYXA2+0kNx3ea4w8TiY +72rLiDv+mi0N0cqCrHnEJsCP/0a1SKYcAHlKrIKGZf2UYjjvumAgzT0BfS/uaoa226TtvbMm1K QNZtJ2BZaOsYCySBUD+WlfKEgMXZiB/045/Q1b9guomc7OCeDqmF+YGmErtyOZbyBfnTHqL1iR1 YtfltpCnj22sB/qzF3w== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-13_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 malwarescore=0 adultscore=0 spamscore=0 phishscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605130182 Hi Bjorn, A gentle reminder to review this series. All the patches have picked up R-b tags. If it looks okay to you, could you please help pick it up in the current merge window. Thanks Vignesh On 5/5/2026 3:53 PM, Varadarajan Narayanan wrote: > As discussed in [4] posting this series after dropping IPQ5424 support > to remove dependency on Sricharan's tmel-qmp mailbox driver series v4 [1]. > > Imported from 20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com. > > Imported from f20250417061245.497803-1-gokul.sriram.p@oss.qualcomm.com > I've resumed Gokul's work as the last submission dates back April 2025. > > - Secure PIL is signed, firmware images which only TrustZone (TZ) > can authenticate and load. Linux kernel will send a request to TZ to > authenticate and load the PIL images. > > - When secure PIL support was added to the existing wcss PIL driver > earlier in [2], Bjorn suggested not to overload the existing WCSS > rproc driver, instead post a new driver for PAS based IPQ WCSS driver. > This series adds a new secure PIL driver for the same. > > - Also adds changes to scm to pass metadata size as required for IPQ5332, > reposted from [3]. > > [1] > https://patchwork.kernel.org/project/linux-arm-msm/cover/20250327181750.3733881-1-quic_srichara@quicinc.com/ > > [2] > https://patchwork.kernel.org/project/linux-arm-msm/patch/1611984013-10201-3-git-send-email-gokulsri@codeaurora.org/ > > [3] > https://patchwork.kernel.org/project/linux-arm-msm/patch/20240820055618.267554-6-quic_gokulsri@quicinc.com/ > > [4] > https://lore.kernel.org/linux-arm-msm/aUN7Aer%2FGG1d5Om9@hu-varada-blr.qualcomm.com/ > > Changes in v12: > - No code change > - Rebase to ToT > - Change quicinc mail ids to oss.qualcomm.com mail ids > - Link to v11: https://lore.kernel.org/linux-arm-msm/20260326043320.2507890-1-varadarajan.narayanan@oss.qualcomm.com/ > > Changes in v11: > - Add R-b tags > - Rebase the first patch ("firmware: qcom_scm: ipq5332: add support to pass metadata size") to top of tree > - No change in other patches > - Link to v10: https://lore.kernel.org/linux-arm-msm/20260113092021.1887980-1-varadarajan.narayanan@oss.qualcomm.com/ > > Changes in v10: > - Add R-b tags > - Remove unused fields from 'struct wcss_sec' > - Remove glink and ssr subdev if wcss_sec_probe() fails > - Link to v9: https://lore.kernel.org/linux-arm-msm/20260106105412.3529898-1-varadarajan.narayanan@oss.qualcomm.com/ > > Changes in v9: > - Add R-b from Konrad for dts patches > - Renamed qcom,wcss-sec-pil.yaml -> qcom,ipq5018-wcss-sec-pil.yaml > - Restore clocks & clock-names in above yaml > - Fix DCO on two patches > - Link to v8: https://lore.kernel.org/linux-arm-msm/20251219031010.2919875-1-varadarajan.narayanan@oss.qualcomm.com/ > > Changes in v8: > - Dropped Krzysztof's 'Reviewed-by' as the bindings file has changed significantly > * IPQ5018 support added in v6 > * IPQ5424 support dropped in v8 > * Updated to use IPQ9574 as example > - dt-bindings-check and dtbs-check passed > - Dropped IPQ5424 support from drivers/remoteproc/qcom_q6v5_wcss_sec.c > - Updated copyrights of drivers/remoteproc/qcom_q6v5_wcss_sec.c > - Change 'qcom,smem-state-names' order to resolve dt-bindings-check error in ipq5018.dtsi > - Dropped changes to ipq5424.dtsi > - Link to v7: https://lore.kernel.org/linux-arm-msm/20251215-ipq5018-wifi-v7-0-ec4adba941b5@outlook.com/ > > Changes in v7: > - correctly sorted QCOM_SCM_PIL_PAS_INIT_IMAGE_V2 by command ID > - correctly sorted smp2p-wcss nodes in dtsi files > - Link to v6: https://lore.kernel.org/r/20251208-ipq5018-wifi-v6-0-d0ce2facaa5f@outlook.com > > Changes in v6: > - added patch to fix IPC register offset for ipq5424 > - changed phandle description for mboxes property in dt-bindings > - updated bindings to define the right clocks per SoC based on > compatible. Ran make dt_binding_check for validation of all > SoCs > - use of more descriptive match data property (use_tmelcom) and > added a condition in wcss_start to not error out if tmelcom > isn't used > - mitigated potential off-by-one > - adopted use of of_reserved_mem_region_to_resource to acquire > memory-region resource > - added driver support for ipq5018 SoC > - corrected size of reg properties as per Konrad's comments > - added patch to bring up Q6 in ipq5018 dtsi > - Link to v5: https://lore.kernel.org/r/20250417061245.497803-1-gokul.sriram.p@oss.qualcomm.com > > Changes in v5: > - retained all the patches as in v3 and addressed comments in > v3. > - reverted changes to dt-bindings done in v4 and retained as in > v3 and fixed firmware format from .mdt to .mbn and retained > reviewed-by. > - dropped 2 patches in v4 that adds support for q6 dtb loading. > Will post them as a new series. > > Following tests were done: > - checkpatch > - dt_binding_check and dtbs_check > - Link to v4: https://lore.kernel.org/r/20250327181750.3733881-1-quic_srichara@quicinc.com > > Changes in v4: > - changed q6 firmware image format from .mdt to .mbn > - corrected arrangement of variable assignemnts as per comments > in qcom_scm.c > - added scm call to get board machid > - added support for q6 dtb loading with support for additional > reserved memory for q6 dtb in .mbn format > - updated dt-bindings to include new dts entry qcom,q6-dtb-info > and additional item in memory-region for q6 dtb region. > - removed unnecessary dependency for QCOM_Q6V5_WCSS_SEC in > Kconfig > - removed unwanted header files in qcom_q6v5_wcss_sec.c > - removed repeated dtb parsing during runtime in qcom_q6v5_wcss_sec.c > - added required check for using tmelcom, if available. Enabled > fallback to scm based authentication, if tmelcom is unavailable. > - added necessary padding for 8digt hex address in dts > - Link to v3: https://lore.kernel.org/r/20250107101320.2078139-1-quic_gokulsri@quicinc.com > > Following tests were done: > - checkpatch > - kernel-doc > - dt_binding_check and dtbs_check > > Changes in v3: > - fixed copyright years and markings based on Jeff's comments. > - replaced devm_ioremap_wc() with ioremap_wc() in > wcss_sec_copy_segment(). > - replaced rproc_alloc() and rproc_add() with their devres > counterparts. > - added mailbox call to tmelcom for secure image authentication > as required for IPQ5424. Added ipq5424 APCS comatible required. > - added changes to scm call to pass metadata size as required for > IPQ5332. > - Link to v2: https://lore.kernel.org/r/20240829134021.1452711-1-quic_gokulsri@quicinc.com > > Changes in v2: > - Removed dependency of this series to q6 clock removal series > as recommended by Krzysztof > - Link to v1: https://lore.kernel.org/r/20240820085517.435566-1-quic_gokulsri@quicinc.com > > George Moussalem (1): > arm64: dts: qcom: ipq5018: add nodes to bring up q6 > > Manikanta Mylavarapu (4): > firmware: qcom_scm: ipq5332: add support to pass metadata size > dt-bindings: remoteproc: qcom: document hexagon based WCSS secure PIL > arm64: dts: qcom: ipq5332: add nodes to bring up q6 > arm64: dts: qcom: ipq9574: add nodes to bring up q6 > > Vignesh Viswanathan (1): > remoteproc: qcom: add hexagon based WCSS secure PIL driver > > .../remoteproc/qcom,ipq5018-wcss-sec-pil.yaml | 178 ++++++++++ > arch/arm64/boot/dts/qcom/ipq5018.dtsi | 64 ++++ > arch/arm64/boot/dts/qcom/ipq5332.dtsi | 64 +++- > arch/arm64/boot/dts/qcom/ipq9574.dtsi | 60 +++- > drivers/firmware/qcom/qcom_scm.c | 14 +- > drivers/firmware/qcom/qcom_scm.h | 1 + > drivers/remoteproc/Kconfig | 19 + > drivers/remoteproc/Makefile | 1 + > drivers/remoteproc/qcom_q6v5_wcss_sec.c | 325 ++++++++++++++++++ > include/linux/remoteproc.h | 2 + > 10 files changed, 723 insertions(+), 5 deletions(-) > create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,ipq5018-wcss-sec-pil.yaml > create mode 100644 drivers/remoteproc/qcom_q6v5_wcss_sec.c > > > base-commit: 9d0d467c3572e93c5faa2e5906a8bbcd70b24efd