From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96904C83F11 for ; Sun, 27 Aug 2023 12:00:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230026AbjH0MAW (ORCPT ); Sun, 27 Aug 2023 08:00:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229817AbjH0MAR (ORCPT ); Sun, 27 Aug 2023 08:00:17 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB7EE13E for ; Sun, 27 Aug 2023 05:00:12 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9a19bf6ab66so300706066b.3 for ; Sun, 27 Aug 2023 05:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693137611; x=1693742411; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=A1vb1NKNxPWmF22t3LyBlcMBv4ZL6aYsl1zImyCmPqk=; b=nkU9QDA3ZQPrE80K5WNGyInIxQ+rjGO9+Y4Z8NK3FX1YJWYxfR7fjbDSFwSImABVDH mbe2eh0mTre7O4pp4wCf+6X4jRtTLqa2PUZZKoW/ZvG5GF2LO2sed8c7OXzDTFtn3LQ+ LPZbcQXOI5ABjn1Zq1JssUMUBZp/svujuVqjbJBLcf/ydP0ypHWCa/pCMRvMbKT6r7Xk RHvdiFofd8NiFURYeL0gJ2wKwK/4q1ssGyQARjsVPjFKJenIRN9VcAUWg37/GiNyxMm5 ubi0xkOFN34WVQPEMIKTSyZZwrShzqb8fk4TPyncxI/tDiNojq9UvDAqSgWtnrwrh+mZ MlwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693137611; x=1693742411; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A1vb1NKNxPWmF22t3LyBlcMBv4ZL6aYsl1zImyCmPqk=; b=Hrl66/qzBXOddkZc/jy4HmiM3faL492+e5CJ1Sfa48mdKgfE2DJg46iFdhAx4CN1JJ m0bqb+uX6ICrhdJ2DTZ2e3qrv6QooHMhVf1bFriwir2pQPf4iVGWGWsWkHJECjifookn H/pnsUcRAaiF+pKlyKxQC05Or7HqIINyfHsMMcmAVPSnPo01cZdJsZ9BKYvGO12eAX3X FfsC+bys7CxJcB087ownp1gG5LHfeURSyYwKP1qtUlinG2k4H0eSbPtCv0Q/DfNn3Wbb 0H+3T8oX1o6MCLFwt/3pSSw9H7g8eHgtfo5q7vBfBSKSqzDJW0yXXQ3smXDCAcsCdH7o p7zQ== X-Gm-Message-State: AOJu0Ywjj9kFA5PUEV45C4NyBfNOhYXvE4nYY6MwOv2deenRc7ub0lA/ rEoja8TZ+r5tlBc5oWyDtD/q/Q== X-Google-Smtp-Source: AGHT+IHfvkkfwHnTPi8nCl9XpByE/JPq0GfNI6XI37kZ85boixd1ibZVDvSULqUh7Q6KLm4+pQXTmw== X-Received: by 2002:a17:906:18a1:b0:99d:fab5:e888 with SMTP id c1-20020a17090618a100b0099dfab5e888mr16063184ejf.34.1693137611153; Sun, 27 Aug 2023 05:00:11 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.225]) by smtp.gmail.com with ESMTPSA id w26-20020a1709064a1a00b009786c8249d6sm3385960eju.175.2023.08.27.05.00.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Aug 2023 05:00:10 -0700 (PDT) Message-ID: Date: Sun, 27 Aug 2023 14:00:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v4 03/38] dt-bindings: mfd: qcom-pm8xxx: allow using interrupts-extended To: Dmitry Baryshkov Cc: devicetree@vger.kernel.org, Lee Jones , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , linux-iio@vger.kernel.org, Dmitry Torokhov , linux-input@vger.kernel.org, Pavel Machek , linux-leds@vger.kernel.org References: <20230827005920.898719-1-dmitry.baryshkov@linaro.org> <20230827005920.898719-4-dmitry.baryshkov@linaro.org> <39af3ab5-4fa5-5b3c-395a-e86e70bbe803@linaro.org> <74dcc5b4-dda2-5de7-9e58-4191a0fb7972@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/08/2023 13:48, Dmitry Baryshkov wrote: > On Sun, 27 Aug 2023 at 14:12, Krzysztof Kozlowski > wrote: >> >> On 27/08/2023 12:42, Dmitry Baryshkov wrote: >>> On Sun, 27 Aug 2023 at 11:35, Krzysztof Kozlowski >>> wrote: >>>> >>>> On 27/08/2023 02:58, Dmitry Baryshkov wrote: >>>>> Allow using interrupts-extended, which is a preferred form of interrupts >>>>> specification compared to the interrupt-parrent + interrupts pair. >>>>> >>>>> Signed-off-by: Dmitry Baryshkov >>>>> --- >>>>> Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml | 10 +++++++++- >>>>> 1 file changed, 9 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml >>>>> index 7fe3875a5996..33d9615e63c8 100644 >>>>> --- a/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml >>>>> +++ b/Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml >>>>> @@ -37,6 +37,9 @@ properties: >>>>> interrupts: >>>>> maxItems: 1 >>>>> >>>>> + interrupts-extended: >>>>> + maxItems: 1 >>>> >>>> The entire patch is not needed. At least should not be needed. What >>>> problem are you trying to solve here? >>> >>> The main problem is the next chunk, which (currently) explicitly >>> requires `interrupts' property. My goal is to allow >>> `interrupts-extended' in addition to `interrupts'. >> >> They are allowed. Why do you think they aren't? That's why I don't >> understand what real problem is here. > > qcom-pm8xxx.yaml lists `interrupts' property under the `required' > clause. So I can not simply replace it with `interrupts-extended' Since when? So again: The entire patch is not needed. Best regards, Krzysztof