From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3284247CA9F for ; Tue, 18 Aug 2026 19:07:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787080070; cv=none; b=eb3CJE1r+jBG/LTawBWucjG3feJupPTN+Nu+KlfYzIEOlw4cXIbL3stP2oC8CyVabT9Lj+9pg0XvEP6B0voZYgo8Qxr2kN1oLti6j2dtlsf+2kyEeSQbUguilG4EQeDuoZXpbzyKaSKsrM0ULASeUVpIpcxvoX64ZDyKHpp0lwc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787080070; c=relaxed/simple; bh=+UESlRR/8ib3mSxysgwZsO+cPigBB/bpNY2eOyvRg3A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dVqCVJnrNTm7tuWtjsDKZPCx+ycEo0zmUax/VlwOhD2efUWVXBqm2GNULnDlBNTPasORFq7MyPvHtDp2NpLyrNXmRQ9kBCDmoZ1/SeHnKIzMbo+hNbGv+IZCqv+KFVRvWytOXe+BVqX9bZhM9yeASfG8y6l6S2Wd5nWjosP0EHI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ORWLhVB2; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ORWLhVB2" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-cbedd5aece4so1038209a12.0 for ; Tue, 18 Aug 2026 12:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1787080068; x=1787684868; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ho5Ut4zy/7Lfy6I1/eZq6GBEnTONort7hcGZ8vJucpo=; b=ORWLhVB2q/niNkqaKBdo+ZV1cfz67L3yuGkeyADAbPKtEwf+PApETRcE5Q3AXJ33k8 bUuRRUFxwHwAqJUWaiLQE1S0vMuwwI/385JBrU4fYuKpsFFzejr9Uy89bepY8nxbkhG6 IdNR0BlLbXHfuacn/PmCVt36nZMqlPQSxrwSaiekb0ZaN3g1UeTud0cN91Y0m/WTnArH hX4czYdV9RWv8NUK31F+4a/m4Zdzo00OFwfq+sDkEKY7wfvfhcKrlNwc+wsmJypVKJFR Kx8+i1V65mWsYb3BuOxLX/eJNa0Py40rCAjJcVtEG27t7DQ/At6DyCQ6TBn8llRE+K8F YTPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787080068; x=1787684868; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=ho5Ut4zy/7Lfy6I1/eZq6GBEnTONort7hcGZ8vJucpo=; b=jiJKTqb76ECOVizXcKkLneWrkCczLAlvNcDps5MqAZrj453cnrq/Nos4ctYeqYyOJh JNgWLEBKOrt+yGFGMaxMANZcNEke3QLDHtGaL4de3xg3dXPSbJxxuMZxJpHosS2hR1PL Dp+czyw2ItCKdRV24BMTOZF/UFpWDd0plPwc3dfqlAR4X7ZMwfJIdF+UULb0gGqnfI8i mALZmTvgp+jXdQKzin3N3uW9RVvZqhjanRWxQ51BociHYyOB+v4++TIWhbjKooM0NeUL aD3fsEQVYD/PTuWjkzzvnynxCAsmvJnkvmOj4BQnl/JTST8ZOSwpXuPxiWtQfIaha5Tb Qvcg== X-Forwarded-Encrypted: i=1; AHgh+RqxpE+oNMTRqIXEbMpPioRFurEzRv5cGT7NcVL4feJ0HpmgwEdjzc8n5VUbGmhy9IJ1RZCr6ed3qj5M@vger.kernel.org X-Gm-Message-State: AOJu0Yw5VZhuwCrS3dmlybDDlHfVD9onSb4nOUydutgxkWch4e3AyQeq RKaV52ViY4jL7bQ9YEAa9YOlLf7uAUUPSigtNNsRyQcJ8ePX6XTPIiT/ X-Gm-Gg: AR+sD12mZywwbrOwDWzozvlul1SwVPjSsV9IxyMJgj+IOpJA0KtayVwTPw87Cx35ODQ 8RGDzA6OWKljvJnVnrMo+TKvG85bbW8if22spLWFI0/gqbdP+18ToBmBJpDOHkqSDmOPWbY1pEi 2a/FxwSWeyae2/bIhgAhuZc/Bc12HfyP/2QES8cf3uEdBHF+4IdF+D/p8OOWLOhT+aqG4bC3YNf ns6LbN9Lj3hSCesy+nRIKuJRBUJam82YMQShY69Z8FNP60fJqNZaADQL5Yg5ClNHzN1QPERiv7P HWptUoC+h595ZMa3c/wdzZdVK4LyAo1sdFn9vfRlLazaNQgKtRQxb1J826Mt9kiIWAcRk0hX6JB arLwAzQjOvwvWparbRdWzkXR+KrotGRHKfn+um23UylPDcY0PThSD+OsBjOsxyNYQxakT85kj0k wjzTwMipQOfiqrrLfvHtZCNFtcRIekIxuvDoSooAIW/KcyAE46dWo6yR8HwD8xzyL1Js9KeV7Z8 Wt5PD1P/KzDYptRrB9GodgMlv1nfl5MLean51AO9HgHRQKu X-Received: by 2002:a17:90b:37cb:b0:38e:4f31:8412 with SMTP id 98e67ed59e1d1-3955f173613mr8638273a91.11.1787080068218; Tue, 18 Aug 2026 12:07:48 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1415317054dsm17788131c88.12.2026.08.18.12.07.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Aug 2026 12:07:47 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Tue, 18 Aug 2026 12:07:46 -0700 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] watchdog: s3c2410_wdt: Add exynos5515-wdt compatible data To: Aiden Isik Cc: sashiko-reviews@lists.linux.dev, Aiden Isik , devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, linux-watchdog@vger.kernel.org References: <20260818-for-next-lucky7-watchdog-v2-0-6743f479a47f@member.fsf.org> <20260818-for-next-lucky7-watchdog-v2-2-6743f479a47f@member.fsf.org> <20260818155332.9E0DD1F000E9@smtp.kernel.org> <8919c7f3-2dcb-4666-91e0-a91edc378c28@roeck-us.net> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/18/26 10:56, Aiden Isik wrote: > Hi Guenter, > >> Aiden, >> >> On 8/18/26 08:53, sashiko-bot@kernel.org wrote: >>> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: >>> - [High] The `drv_data_exynos5515` variant includes `QUIRK_HAS_PMU_AUTO_DISABLE` but fails to define `.disable_reg`, resulting in PMU register corruption at offset 0x0. >>> - [High] The `drv_data_exynos5515` variant uses an INT_EN register for masking but fails to set `.mask_reset_inv = true`, inverting the watchdog masking logic. >>> -- >>> >> Please either address or explain why those are non-issues. >> > > For the 'disable_reg' issue Sashiko flagged, downstream says this: > >> /* PMU registers are changed. >> * MASK_RESET register was replaced by CLUSTERx_NONCPU_INT_TYPE register. >> * DISABLE register was removed and its value was always fixed by 0. >> */ > > Which is why I omitted disable_reg. It no longer exists. > What is "downstream" ? I do not see this comment in the patch, not in linux-next as of next-20260817. Guenter