Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Alexandre TORGUE <alexandre.torgue@foss.st.com>,
	Rob Herring <robh@kernel.org>,
	Hugues Fruchet <hugues.fruchet@foss.st.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	linux-media@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-kernel@vger.kernel.org,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Subject: Re: [PATCH] media: dt-bindings: media: add access-controllers to STM32MP25 video codecs
Date: Thu, 11 Apr 2024 15:36:37 +0200	[thread overview]
Message-ID: <e6465ed5-c52c-44c2-8032-2ce0bbcf07a2@linaro.org> (raw)
In-Reply-To: <278bccaa-edc0-4f3d-8e9e-6159d2b47394@foss.st.com>

On 11/04/2024 14:57, Alexandre TORGUE wrote:
> Hi Rob
> 
> On 4/10/24 18:31, Rob Herring wrote:
>>
>> On Wed, 10 Apr 2024 16:42:22 +0200, Hugues Fruchet wrote:
>>> access-controllers is an optional property that allows a peripheral to
>>> refer to one or more domain access controller(s).
>>>
>>> Signed-off-by: Hugues Fruchet <hugues.fruchet@foss.st.com>
>>> ---
>>>   .../devicetree/bindings/media/st,stm32mp25-video-codec.yaml   | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> yamllint warnings/errors:
>>
>> dtschema/dtc warnings/errors:
>> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/st,stm32mp25-video-codec.yaml: access-controllers: missing type definition
>>
>> doc reference errors (make refcheckdocs):
>>
>> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240410144222.714172-1-hugues.fruchet@foss.st.com
>>
>> The base for the series is generally the latest rc1. A different dependency
>> should be noted in *this* patch.
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure 'yamllint' is installed and dt-schema is up to
>> date:
>>
>> pip3 install dtschema --upgrade
>>
>> Please check and re-submit after running the above command yourself. Note
>> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
>> your schema. However, it must be unset to test all examples with your schema.
>>
> 
> This patch depends on STM32 firewall bus YAML which has been recently 
> added in stm32-next branch. I tested it on top of stm32-next and there 

Where is it expressed in the patch? How maintainers are supposed to know
if this patch should be applied or not?

> is no YAML issues (neiter dt-bindings checks nor dtbs_check). If you 
> agree to ack it, I could merge it on stm32-next.

Drop redundant second "media" from the subject. One media is enough.

With the subject fixed:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


  reply	other threads:[~2024-04-11 13:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-10 14:42 [PATCH] media: dt-bindings: media: add access-controllers to STM32MP25 video codecs Hugues Fruchet
2024-04-10 16:31 ` Rob Herring
2024-04-11 12:57   ` Alexandre TORGUE
2024-04-11 13:36     ` Krzysztof Kozlowski [this message]
2024-04-11 14:06 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e6465ed5-c52c-44c2-8032-2ce0bbcf07a2@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hugues.fruchet@foss.st.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mchehab@kernel.org \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox