From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C0CEC19F29 for ; Wed, 27 Jul 2022 09:55:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231586AbiG0Jy5 (ORCPT ); Wed, 27 Jul 2022 05:54:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231538AbiG0Jyy (ORCPT ); Wed, 27 Jul 2022 05:54:54 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15BFE4505E for ; Wed, 27 Jul 2022 02:54:51 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id t22so19957570lfg.1 for ; Wed, 27 Jul 2022 02:54:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Ff9uzpMBrXqtRLFs8NSqZkB6LNqgU3H0pEbAZBJ643Y=; b=FLtiM/k/98uLhDy19aELtykjXsB8d1jzCKSTQGaTTlgTJ9+Jaee4eIhmeIDeCXxH5V bRlkzSag4e/yBVTqxZrKqmv+oeLEayoOujtTbJL8Co5NEkhLCrw4m6OU9FzoMFYhBxv9 jHu5FbqvAmMHCP+oKPc3OW/saCXX4Q3ZYrj9X8oieH+f29ci+aq5jMGorU9Y4Up8fPd+ ODutAk4au7sLUN5fgtfTW2Dbwos6Y5R+D46HFXoSg4E2pvN2ieurrpjzwICisVtZ0+qm u9nD0eo3iVsYADCwSZw6QfQWNHD5ZiRO7x6OUEZ45f19O2xkY5z4aAXGMyQGgSVSOpat LV1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Ff9uzpMBrXqtRLFs8NSqZkB6LNqgU3H0pEbAZBJ643Y=; b=s0DuuRGncOCXsmrv0IMmmktO9Su2wL5fEzasam/4IBYStFUE9ow66nwc11w+sp4UUq EiC3cy+z1Fz99msx5AjaJIRtKAiqQlzEo1MA6GvXM4834W+sph2Hhc4wxGfOzoa2oIiY SBqKwriNYPq+SfaqqteMlPDEcZbAUdJ99enMTJ1LGYawGI+m/fio5qZu6ouP3vB8vTHG af7CnZ0HEMwnDCqjE2D++n6/gNBJ10dmBO2y7av5Vx9oG+9Ch2htBv38XwaeZanDTpN3 3PyG/wiGFAr1NNgizAU+UDC300bQzdnYihtjmLNoRGtzuv5iKZvVT3x2APB3L24Oigia 5tIA== X-Gm-Message-State: AJIora9zZhZY583m6oy8H7mhGRgSyZb2jL7P9AG4mypYMi4htb4ulC+x AzVGN+Yv1YpOz+KNTQbXosi1rQ== X-Google-Smtp-Source: AGRyM1v1YCF4kJczG5ZSx9902fpbqwGosBeUxKcyUZZfWk9h56A0kf1q4gNwb5pRg03vSQ8Ka30Ifw== X-Received: by 2002:a05:6512:4004:b0:48a:8d72:2434 with SMTP id br4-20020a056512400400b0048a8d722434mr4867601lfb.200.1658915689038; Wed, 27 Jul 2022 02:54:49 -0700 (PDT) Received: from [192.168.3.197] (78-26-46-173.network.trollfjord.no. [78.26.46.173]) by smtp.gmail.com with ESMTPSA id b23-20020a056512071700b0048aa0ab6448sm861073lfs.15.2022.07.27.02.54.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 02:54:48 -0700 (PDT) Message-ID: Date: Wed, 27 Jul 2022 11:54:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 4/6] dt-bindings: riscv: Add DT binding documentation for Renesas RZ/Five SoC and SMARC EVK Content-Language: en-US To: "Lad, Prabhakar" Cc: Lad Prabhakar , Geert Uytterhoeven , Magnus Damm , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Anup Patel , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-riscv , LKML , Biju Das References: <20220726180623.1668-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20220726180623.1668-5-prabhakar.mahadev-lad.rj@bp.renesas.com> <636e9214-4b36-e9a6-3c6b-b6edb944335e@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/07/2022 11:05, Lad, Prabhakar wrote: > Hi Krzysztof, > > Thank you for the review. > > On Wed, Jul 27, 2022 at 9:54 AM Krzysztof Kozlowski > wrote: >> >> On 26/07/2022 20:06, Lad Prabhakar wrote: >>> Document Renesas RZ/Five (R9A07G043) SoC and SMARC EVK based on this SoC. >>> >>> Signed-off-by: Lad Prabhakar >>> --- >>> .../devicetree/bindings/riscv/renesas.yaml | 49 +++++++++++++++++++ >>> 1 file changed, 49 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/riscv/renesas.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/riscv/renesas.yaml b/Documentation/devicetree/bindings/riscv/renesas.yaml >>> new file mode 100644 >>> index 000000000000..f72f8aea6a82 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/riscv/renesas.yaml >>> @@ -0,0 +1,49 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/riscv/renesas.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Renesas RZ/Five Platform Device Tree Bindings >>> + >>> +maintainers: >>> + - Geert Uytterhoeven >>> + - Lad Prabhakar >>> + >>> +# We want to ignore this schema if the board is SMARC EVK based on ARM64 arch >>> +select: >>> + not: >>> + properties: >>> + compatible: >>> + contains: >>> + items: >> >> I think you should rather ignore the RiscV SoCs, not specific board. >> > You mean to ignore ARM/64 SoCs? > > Agreed just the below enum, should do the trick. > > - enum: > - renesas,r9a07g043u11 > - renesas,r9a07g043u12 > - renesas,r9a07g044c1 > - renesas,r9a07g044c2 > - renesas,r9a07g044l1 > - renesas,r9a07g044l2 > - renesas,r9a07g054l1 > - renesas,r9a07g054l2 > > >>> + - const: renesas,smarc-evk >>> + - enum: >>> + - renesas,r9a07g043u11 >>> + - renesas,r9a07g043u12 >>> + - renesas,r9a07g044c1 >>> + - renesas,r9a07g044c2 >>> + - renesas,r9a07g044l1 >>> + - renesas,r9a07g044l2 >>> + - renesas,r9a07g054l1 >>> + - renesas,r9a07g054l2 >>> + - enum: >>> + - renesas,r9a07g043 >>> + - renesas,r9a07g044 >>> + - renesas,r9a07g054 >> >> Did you actually test that it works and properly matches? >> > Yes I have run the dtbs_check and dt_binding _check for ARM64 and > RISC-V. Do you see any cases where it can fail? Just remove the renesas,smarc-evk2 from arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dts. Do you see the error? Not from this schema. The only error you will see is that no matching schema was found. I don't think you can use such selects... Best regards, Krzysztof