Re: [PATCH v2 03/10] dt-bindings: display: msm: document DSI controller and phy on SA8775P

[Ayushi Makhija <quic_amakhija@quicinc.com>]

Hi Krzysztof/Dmitry,

On 4/10/2025 2:46 PM, Dmitry Baryshkov wrote:
> On Thu, Apr 10, 2025 at 08:08:17AM +0200, Krzysztof Kozlowski wrote:
>> On 09/04/2025 17:24, Dmitry Baryshkov wrote:
>>> On 09/04/2025 09:07, Krzysztof Kozlowski wrote:
>>>> On 08/04/2025 22:26, Dmitry Baryshkov wrote:
>>>>>>>>>>> +          - const: qcom,sa8775p-dsi-ctrl
>>>>>>>>>>> +          - const: qcom,mdss-dsi-ctrl
>>>>>>>>>>
>>>>>>>>>> Drop fallback
>>>>>>>>>>
>>>>>>>>>    
>>>>>>>>> Hi Krzysztof,
>>>>>>>>>
>>>>>>>>> I couldn't understand the meaning of "Drop fallback", could please elaborate it ?
>>>>>>>> Look at SM8750 example on the lists. Keep only front compatible.
>>>>>>>
>>>>>>> Why?
>>>>>>
>>>>>> To make things simpler and shorter.
>>>>>
>>>>> I'd prefer consistency. Previous platforms use qcom,mdss-dsi-ctrl.
>>>> Then you should have objected month(s) ago when Rob asked for dropping
>>>> fallback and since then we consistently drop it.
>>>
>>> Well... It's still not merged. is it?
>>> For SM8750 it kinda makes sense, because the clock handling is different 
>>> from all other current platforms. For the existing devices... I'm not 
>>> that sure.
>> How does it differ? The clock handling does not matter - this is just
>> select of schema for the child node.
> 
> Ah.... I'm sorry, I misinterpreted the email. Yes, having only a single
> compat here is perfectly fine. Please excuse me for the confusion.
> 

Thanks, for the review.

I will write single compatible string. Will update it in next patchset.

+  "^dsi@[0-9a-f]+$":
+    type: object
+    additionalProperties: true
+    properties:
+      compatible:
+        contains:
+          const: qcom,sa8775p-dsi-ctrl
+

Thanks,
Ayushi